Re: [igt-dev] [PATCH i-g-t] lib: sync i915_pciids.h with kernel

Dixit, Ashutosh
2020-10-23T15:56:00Z

On Fri, 23 Oct 2020 01:03:24 -0700, Petri Latvala wrote:
>
> On Fri, Oct 23, 2020 at 10:59:27AM +0300, Petri Latvala wrote:
> > On Thu, Oct 22, 2020 at 08:18:59PM -0700, Ashutosh Dixit wrote:
> > > Align with kernel commits:
> > >
> > > 605f9c290c1a2 ("drm/i915: Sort ICL PCI IDs")
> > > 514dc424ce4f5 ("drm/i915: Sort CNL PCI IDs")
> > > 32d4ec9a1681d ("drm/i915: Sort CFL PCI IDs")
> > > df3478af1d73c ("drm/i915: Sort CML PCI IDs")
> > > cd988984cbea0 ("drm/i915: Sort KBL PCI IDs")
> > > b04d36f737712 ("drm/i915: Sort SKL PCI IDs")
> > > 9c0b2d30441b5 ("drm/i915: Sort HSW PCI IDs")
> > > 79033a0a78984 ("drm/i915: Ocd the HSW PCI ID hex numbers")
> > > cfb3db8fdae25 ("drm/i915: Try to fix the SKL GT3/4 vs. GT3e/4e comments")
> > > 03e399020cd20 ("drm/i915: Add SKL GT1.5 PCI IDs")
> > > 812f044df08cc ("drm/i915: Reclassify SKL 0x1923 and 0x1927 as ULT")
> > > 194909a32aed0 ("drm/i915: Reclassify SKL 0x192a as GT3")
> > > 82e84284ab7dd ("drm/i915: Update Haswell PCI IDs")
> > > 24ea098b7c0d8 ("drm/i915/jsl: Split EHL/JSL platform info and PCI ids")
> > > b50b7991b739c ("drm/i915/dg1: add more PCI ids")
> > >
> > > Cc: Petri Latvala <petri.latvala@intel.com>
> > > Signed-off-by: Ashutosh Dixit <ashutosh.dixit@intel.com>
> > > ---
> >
> > I get really confused by commit messages like this. Which commit is
> > this now copied from, and which repo has that commit?

Hi Petri, yes I wasn't happy either doing this since it appears a simple
commit message like "Sync i915_pciids.h with the drm-tip kernel as of
today" should have been sufficient. But the previous git log for the file
has followed this format for the commit message. The format is the same as
that for "git log --oneline" for include/drm/i915_pciids.h on drm-tip,
newest commits on top.

But yes, I should have said it's the drm-tip kernel.

> Regardless of that confusion, the file matches what's in drm-tip so
>
> Reviewed-by: Petri Latvala <petri.latvala@intel.com>

Thanks.