From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mga03.intel.com (mga03.intel.com [134.134.136.65]) by gabe.freedesktop.org (Postfix) with ESMTPS id 5BE9B10E135 for ; Fri, 30 Sep 2022 04:00:41 +0000 (UTC) Message-ID: Date: Fri, 30 Sep 2022 09:30:29 +0530 To: Bhanuprakash Modem , References: <20220922160004.2041598-21-bhanuprakash.modem@intel.com> <20220928090900.2336045-1-bhanuprakash.modem@intel.com> Content-Language: en-US From: Karthik B S In-Reply-To: <20220928090900.2336045-1-bhanuprakash.modem@intel.com> Content-Type: text/plain; charset="UTF-8"; format=flowed Content-Transfer-Encoding: 7bit MIME-Version: 1.0 Subject: Re: [igt-dev] [i-g-t V5 20/52] tests/kms_multipipe_modeset: Find the suitable mode instead of using default List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: igt-dev-bounces@lists.freedesktop.org Sender: "igt-dev" List-ID: On 9/28/2022 2:39 PM, Bhanuprakash Modem wrote: > As we are trying to run this subtest on all pipes + all outputs, It is not > possible to use 8K mode. To use 8K mode on a pipe then the consecutive pipe > must be free which is not true here. > > Instead, reduce the resolution from 8K and run the test otherwise we'll endup > with the test failures. > > V2: > - Fix commit message > > Signed-off-by: Bhanuprakash Modem Reviewed-by: Karthik B S > --- > tests/kms_multipipe_modeset.c | 9 +++++++++ > 1 file changed, 9 insertions(+) > > diff --git a/tests/kms_multipipe_modeset.c b/tests/kms_multipipe_modeset.c > index 6358d930..6ba6943e 100644 > --- a/tests/kms_multipipe_modeset.c > +++ b/tests/kms_multipipe_modeset.c > @@ -46,6 +46,15 @@ static void run_test(data_t *data, int valid_outputs) > drmModeModeInfo *mode; > int i = 0; > > + /* Find suitable mode/resolution combo */ > + for_each_connected_output(display, output) { > + pipe = &display->pipes[i]; > + igt_output_set_pipe(output, i); > + > + i++; > + } > + igt_require(igt_override_all_active_output_modes_to_fit_bw(display)); > + > for_each_connected_output(display, output) { > mode = igt_output_get_mode(output); > igt_assert(mode);