Re: [PATCH i-g-t] tests/intel/kms_dsc: Use high resolution mode for output format subtests

["Modem, Bhanuprakash" <bhanuprakash.modem@intel.com>]

On 22-03-2024 01:44 pm, Ankit Nautiyal wrote:
> Currently, we are not using the highest resolution mode for output formats
> other than RGB. For testing other formats we force an output format, and
> try the mode from list of modes.
> Lets call get_highres_mode before using the modes, so that we try modes
> that are sorted in descending order of resolution. This is to ensure we
> try with higher resolution mode and use DSC with that mode.
> 
> Signed-off-by: Ankit Nautiyal <ankit.k.nautiyal@intel.com>
> ---
>   tests/intel/kms_dsc.c | 6 +++---
>   1 file changed, 3 insertions(+), 3 deletions(-)
> 
> diff --git a/tests/intel/kms_dsc.c b/tests/intel/kms_dsc.c
> index b5c0fa6ab925..9b48caf762f1 100644
> --- a/tests/intel/kms_dsc.c
> +++ b/tests/intel/kms_dsc.c
> @@ -184,10 +184,10 @@ static void update_display(data_t *data, uint32_t test_type)
>   	igt_skip_on(!igt_plane_has_format_mod(primary, data->plane_format,
>   		    DRM_FORMAT_MOD_LINEAR));
>   
> +	mode = get_highres_mode(output);

Irrespective of the formats, this ensures to try with the highest 
possible resolution.

Reviewed-by: Bhanuprakash Modem <bhanuprakash.modem@intel.com>

> +
>   	do {
> -		if (data->output_format == DSC_FORMAT_RGB)
> -			mode = get_highres_mode(output);
> -		else
> +		if (data->output_format != DSC_FORMAT_RGB && index > 0)
>   			mode = get_next_mode(output, index++);
>   
>   		if (mode == NULL)