* [PATCH 1/2] dt-bindings: arm: fsl: Add Kobo Clara HD rev B
2024-05-04 21:53 [PATCH 0/2] ARM: dts: mix: Add Kobo Clara HD rev B Andreas Kemnade
@ 2024-05-04 21:53 ` Andreas Kemnade
2024-05-05 8:28 ` Krzysztof Kozlowski
2024-05-04 21:53 ` [PATCH 2/2] ARM: dts: imx: Add Kobo Clara HD rev b Andreas Kemnade
2024-05-06 20:40 ` [PATCH 0/2] ARM: dts: mix: Add Kobo Clara HD rev B Rob Herring (Arm)
2 siblings, 1 reply; 6+ messages in thread
From: Andreas Kemnade @ 2024-05-04 21:53 UTC (permalink / raw)
To: robh, krzk+dt, conor+dt, shawnguo, s.hauer, kernel, festevam,
marex, leoyang.li, devicetree, linux-kernel, imx,
linux-arm-kernel
Cc: Andreas Kemnade
Add a board revision of the Kobo Clara HD with different regulator
setup. Since the original compatible seems to be found in userspace
in the wild, keep it as a fallback compatible.
Signed-off-by: Andreas Kemnade <andreas@kemnade.info>
---
Documentation/devicetree/bindings/arm/fsl.yaml | 6 ++++++
1 file changed, 6 insertions(+)
diff --git a/Documentation/devicetree/bindings/arm/fsl.yaml b/Documentation/devicetree/bindings/arm/fsl.yaml
index 0027201e19f8b..8dda627cffd84 100644
--- a/Documentation/devicetree/bindings/arm/fsl.yaml
+++ b/Documentation/devicetree/bindings/arm/fsl.yaml
@@ -609,6 +609,12 @@ properties:
- kobo,librah2o
- const: fsl,imx6sll
+ - description: i.IMX6SLL Kobo Clara variants
+ items:
+ - const: kobo,clarahd-b # variant wit different regulator setup
+ - const: kobo,clarahd
+ - const: fsl,imx6sll
+
- description: i.MX6SX based Boards
items:
- enum:
--
2.39.2
^ permalink raw reply related [flat|nested] 6+ messages in thread* [PATCH 2/2] ARM: dts: imx: Add Kobo Clara HD rev b
2024-05-04 21:53 [PATCH 0/2] ARM: dts: mix: Add Kobo Clara HD rev B Andreas Kemnade
2024-05-04 21:53 ` [PATCH 1/2] dt-bindings: arm: fsl: " Andreas Kemnade
@ 2024-05-04 21:53 ` Andreas Kemnade
2024-05-18 9:41 ` Andreas Kemnade
2024-05-06 20:40 ` [PATCH 0/2] ARM: dts: mix: Add Kobo Clara HD rev B Rob Herring (Arm)
2 siblings, 1 reply; 6+ messages in thread
From: Andreas Kemnade @ 2024-05-04 21:53 UTC (permalink / raw)
To: robh, krzk+dt, conor+dt, shawnguo, s.hauer, kernel, festevam,
marex, leoyang.li, devicetree, linux-kernel, imx,
linux-arm-kernel
Cc: Andreas Kemnade
There is a variation of the Kobo Clara HD containing a PMIC with different
default settings for the regulators in the OTP and therefore also
regulators wired up in a different way, so add a proper devicetree for it
to avoid some magic smoke.
Signed-off-by: Andreas Kemnade <andreas@kemnade.info>
---
arch/arm/boot/dts/nxp/imx/Makefile | 1 +
.../dts/nxp/imx/imx6sll-kobo-clarahd-b.dts | 79 +++++++++++++++++++
2 files changed, 80 insertions(+)
create mode 100644 arch/arm/boot/dts/nxp/imx/imx6sll-kobo-clarahd-b.dts
diff --git a/arch/arm/boot/dts/nxp/imx/Makefile b/arch/arm/boot/dts/nxp/imx/Makefile
index 4052cad859fa9..a4826d128dfc7 100644
--- a/arch/arm/boot/dts/nxp/imx/Makefile
+++ b/arch/arm/boot/dts/nxp/imx/Makefile
@@ -288,6 +288,7 @@ dtb-$(CONFIG_SOC_IMX6SL) += \
dtb-$(CONFIG_SOC_IMX6SLL) += \
imx6sll-evk.dtb \
imx6sll-kobo-clarahd.dtb \
+ imx6sll-kobo-clarahd-b.dtb \
imx6sll-kobo-librah2o.dtb
dtb-$(CONFIG_SOC_IMX6SX) += \
imx6sx-nitrogen6sx.dtb \
diff --git a/arch/arm/boot/dts/nxp/imx/imx6sll-kobo-clarahd-b.dts b/arch/arm/boot/dts/nxp/imx/imx6sll-kobo-clarahd-b.dts
new file mode 100644
index 0000000000000..09b890fe915ab
--- /dev/null
+++ b/arch/arm/boot/dts/nxp/imx/imx6sll-kobo-clarahd-b.dts
@@ -0,0 +1,79 @@
+// SPDX-License-Identifier: (GPL-2.0)
+/*
+ * Device tree for the Kobo Clara HD Rev B ebook reader
+ *
+ * Name on mainboard is: 37NB-E60K00+4B0
+ * Serials start with: E60K02 (a number also seen in
+ * vendor kernel sources)
+ *
+ * Copyright 2024 Andreas Kemnade
+ */
+
+/dts-v1/;
+
+#include "imx6sll-kobo-clarahd.dts"
+
+/ {
+ model = "Kobo Clara HD Rev B";
+ compatible = "kobo,clarahd-b", "kobo,clarahd", "fsl,imx6sll";
+};
+
+&cpu0 {
+ arm-supply = <&dcdc5_reg>;
+ soc-supply = <&dcdc2_reg>;
+};
+
+&dcdc1_reg {
+ /delete-property/ regulator-min-microvolt;
+ /delete-property/ regulator-max-microvolt;
+
+ regulator-state-mem {
+ regulator-suspend-min-microvolt = <1040000>;
+ regulator-suspend-max-microvolt = <1040000>;
+ };
+};
+
+&dcdc2_reg {
+ regulator-min-microvolt = <660000>;
+ regulator-max-microvolt = <1000000>;
+
+ regulator-state-mem {
+ regulator-suspend-min-microvolt = <660000>;
+ regulator-suspend-max-microvolt = <660000>;
+ };
+};
+
+&dcdc3_reg {
+ /delete-property/ regulator-min-microvolt;
+ /delete-property/ regulator-max-microvolt;
+
+ regulator-state-mem {
+ regulator-suspend-min-microvolt = <3300000>;
+ regulator-suspend-max-microvolt = <3300000>;
+ };
+};
+
+&dcdc4_reg {
+ /delete-property/ regulator-min-microvolt;
+ /delete-property/ regulator-max-microvolt;
+
+ regulator-state-mem {
+ regulator-suspend-min-microvolt = <1700000>;
+ regulator-suspend-max-microvolt = <1700000>;
+ };
+};
+
+&dcdc5_reg {
+ regulator-min-microvolt = <710000>;
+ regulator-max-microvolt = <1100000>;
+
+ regulator-state-mem {
+ regulator-suspend-min-microvolt = <710000>;
+ regulator-suspend-max-microvolt = <710000>;
+ };
+};
+
+&ldo8_reg {
+ /delete-property/ regulator-min-microvolt;
+ /delete-property/ regulator-max-microvolt;
+};
--
2.39.2
^ permalink raw reply related [flat|nested] 6+ messages in thread* Re: [PATCH 0/2] ARM: dts: mix: Add Kobo Clara HD rev B
2024-05-04 21:53 [PATCH 0/2] ARM: dts: mix: Add Kobo Clara HD rev B Andreas Kemnade
2024-05-04 21:53 ` [PATCH 1/2] dt-bindings: arm: fsl: " Andreas Kemnade
2024-05-04 21:53 ` [PATCH 2/2] ARM: dts: imx: Add Kobo Clara HD rev b Andreas Kemnade
@ 2024-05-06 20:40 ` Rob Herring (Arm)
2 siblings, 0 replies; 6+ messages in thread
From: Rob Herring (Arm) @ 2024-05-06 20:40 UTC (permalink / raw)
To: Andreas Kemnade
Cc: kernel, s.hauer, shawnguo, leoyang.li, krzk+dt, conor+dt,
linux-kernel, festevam, linux-arm-kernel, marex, imx, devicetree
On Sat, 04 May 2024 23:53:42 +0200, Andreas Kemnade wrote:
> Apparently there exists another revision of the Kobo Clara HD
> which has just different regulator setup. So add support for it.
>
> For details: https://gitlab.com/postmarketOS/pmaports/-/issues/2356
>
> Andreas Kemnade (2):
> dt-bindings: arm: fsl: Add Kobo Clara HD rev B
> ARM: dts: imx: Add Kobo Clara HD rev b
>
> .../devicetree/bindings/arm/fsl.yaml | 6 ++
> arch/arm/boot/dts/nxp/imx/Makefile | 1 +
> .../dts/nxp/imx/imx6sll-kobo-clarahd-b.dts | 79 +++++++++++++++++++
> 3 files changed, 86 insertions(+)
> create mode 100644 arch/arm/boot/dts/nxp/imx/imx6sll-kobo-clarahd-b.dts
>
> --
> 2.39.2
>
>
>
My bot found new DTB warnings on the .dts files added or changed in this
series.
Some warnings may be from an existing SoC .dtsi. Or perhaps the warnings
are fixed by another series. Ultimately, it is up to the platform
maintainer whether these warnings are acceptable or not. No need to reply
unless the platform maintainer has comments.
If you already ran DT checks and didn't see these error(s), then
make sure dt-schema is up to date:
pip3 install dtschema --upgrade
New warnings running 'make CHECK_DTBS=y nxp/imx/imx6sll-kobo-clarahd-b.dtb' for 20240504215344.861327-1-andreas@kemnade.info:
arch/arm/boot/dts/nxp/imx/imx6sll-kobo-clarahd-b.dtb: /soc/bus@2000000/spba-bus@2000000/spdif@2004000: failed to match any schema with compatible: ['fsl,imx6sl-spdif', 'fsl,imx35-spdif']
arch/arm/boot/dts/nxp/imx/imx6sll-kobo-clarahd-b.dtb: serial@2034000: dma-name: b'rx\x00tx\x00' is not of type 'object', 'array', 'boolean', 'null'
from schema $id: http://devicetree.org/schemas/dt-core.yaml#
arch/arm/boot/dts/nxp/imx/imx6sll-kobo-clarahd-b.dtb: timer@2098000: compatible:
'oneOf' conditional failed, one must be fixed:
['fsl,imx6sl-gpt'] is too short
'fsl,imx1-gpt' was expected
'fsl,imx21-gpt' was expected
'fsl,imx27-gpt' was expected
'fsl,imx31-gpt' was expected
'fsl,imx6sl-gpt' is not one of ['fsl,imx25-gpt', 'fsl,imx50-gpt', 'fsl,imx51-gpt', 'fsl,imx53-gpt', 'fsl,imx6q-gpt']
'fsl,imx6dl-gpt' was expected
'fsl,imx6sl-gpt' is not one of ['fsl,imx6ul-gpt', 'fsl,imx7d-gpt']
from schema $id: http://devicetree.org/schemas/timer/fsl,imxgpt.yaml#
arch/arm/boot/dts/nxp/imx/imx6sll-kobo-clarahd-b.dtb: anatop@20c8000: '#address-cells', '#size-cells', 'regulator-3p0@20c8120', 'temperature-sensor' do not match any of the regexes: 'pinctrl-[0-9]+', 'regulator-((1p1)|(2p5)|(3p0)|(vddcore)|(vddpu)|(vddsoc))$'
from schema $id: http://devicetree.org/schemas/soc/imx/fsl,imx-anatop.yaml#
arch/arm/boot/dts/nxp/imx/imx6sll-kobo-clarahd-b.dtb: regulator-3p0@20c8120: Unevaluated properties are not allowed ('reg' was unexpected)
from schema $id: http://devicetree.org/schemas/regulator/anatop-regulator.yaml#
arch/arm/boot/dts/nxp/imx/imx6sll-kobo-clarahd-b.dtb: temperature-sensor: '#thermal-sensor-cells' is a required property
from schema $id: http://devicetree.org/schemas/thermal/imx-thermal.yaml#
arch/arm/boot/dts/nxp/imx/imx6sll-kobo-clarahd-b.dtb: /soc/bus@2000000/interrupt-controller@20dc000: failed to match any schema with compatible: ['fsl,imx6sll-gpc', 'fsl,imx6q-gpc']
arch/arm/boot/dts/nxp/imx/imx6sll-kobo-clarahd-b.dtb: /soc/bus@2000000/pinctrl@20e0000: failed to match any schema with compatible: ['fsl,imx6sll-iomuxc']
arch/arm/boot/dts/nxp/imx/imx6sll-kobo-clarahd-b.dtb: /soc/bus@2000000/csi@20e8000: failed to match any schema with compatible: ['fsl,imx6sll-csi', 'fsl,imx6s-csi']
arch/arm/boot/dts/nxp/imx/imx6sll-kobo-clarahd-b.dtb: /soc/bus@2000000/csi@20e8000: failed to match any schema with compatible: ['fsl,imx6sll-csi', 'fsl,imx6s-csi']
arch/arm/boot/dts/nxp/imx/imx6sll-kobo-clarahd-b.dtb: lcd-controller@20f8000: compatible:
'oneOf' conditional failed, one must be fixed:
['fsl,imx6sll-lcdif', 'fsl,imx28-lcdif'] is too long
'fsl,imx6sll-lcdif' is not one of ['fsl,imx23-lcdif', 'fsl,imx28-lcdif', 'fsl,imx6sx-lcdif', 'fsl,imx8mp-lcdif', 'fsl,imx93-lcdif']
'fsl,imx6sx-lcdif' was expected
from schema $id: http://devicetree.org/schemas/display/fsl,lcdif.yaml#
arch/arm/boot/dts/nxp/imx/imx6sll-kobo-clarahd-b.dtb: lcd-controller@20f8000: clocks: [[2, 129], [2, 123], [2, 0]] is too long
from schema $id: http://devicetree.org/schemas/display/fsl,lcdif.yaml#
arch/arm/boot/dts/nxp/imx/imx6sll-kobo-clarahd-b.dtb: lcd-controller@20f8000: clock-names: ['pix', 'axi', 'disp_axi'] is too long
from schema $id: http://devicetree.org/schemas/display/fsl,lcdif.yaml#
^ permalink raw reply [flat|nested] 6+ messages in thread