From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from mx0a-0031df01.pphosted.com (mx0a-0031df01.pphosted.com [205.220.168.131]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id DD8E835A92E for ; Fri, 9 Jan 2026 16:11:47 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=205.220.168.131 ARC-Seal:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1767975109; cv=none; b=Y84qTr3czpspLbA2smDkVL+mhnOeoCGVJTuXpeU69LoHyJSQThxzURJh1zvvsFgB5XEn5DcHc4bmNMkMMeLVc5+1+ANaObdO6eO/bvLzO6sUHwQx5ZkPNuuawxAneLaPFUe4GJUAULwMQQTlEZB0i+dy/DzWU7hhcEtNwj/MPUc= ARC-Message-Signature:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1767975109; c=relaxed/simple; bh=bRsahIX3ht0GHBJx1blAhDC+PMafKVdC6FTNh9VJlp4=; h=Message-ID:Date:MIME-Version:Subject:To:Cc:References:From: In-Reply-To:Content-Type; b=ZssiR3R5Gii6JyqRCTyyB8CDQk8nX5aduWFDKKYSSZFZ7nKEGI+PX1czmvydtPvaJGonFOq8tTGPJWy5ecFhN8ZSXdHdYgQpkSau5MlBHfmNogorZaecmd4DXCLzQw+iG+DtcoZHMjG8fhLZ2K15kEJg4n61WXgzSZ8VUvxiH3Y= ARC-Authentication-Results:i=1; smtp.subspace.kernel.org; dmarc=pass (p=reject dis=none) header.from=oss.qualcomm.com; spf=pass smtp.mailfrom=oss.qualcomm.com; dkim=pass (2048-bit key) header.d=qualcomm.com header.i=@qualcomm.com header.b=LHHNohgL; dkim=pass (2048-bit key) header.d=oss.qualcomm.com header.i=@oss.qualcomm.com header.b=AIL8JIue; arc=none smtp.client-ip=205.220.168.131 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=reject dis=none) header.from=oss.qualcomm.com Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=oss.qualcomm.com Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=qualcomm.com header.i=@qualcomm.com header.b="LHHNohgL"; dkim=pass (2048-bit key) header.d=oss.qualcomm.com header.i=@oss.qualcomm.com header.b="AIL8JIue" Received: from pps.filterd (m0279863.ppops.net [127.0.0.1]) by mx0a-0031df01.pphosted.com (8.18.1.11/8.18.1.11) with ESMTP id 6099NCZP473084 for ; Fri, 9 Jan 2026 16:11:47 GMT DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=qualcomm.com; h= cc:content-transfer-encoding:content-type:date:from:in-reply-to :message-id:mime-version:references:subject:to; s=qcppdkim1; bh= y0F3msY51CEG685pZ5Vd9mM1nAPXE1h7mU6gkqrwSxw=; b=LHHNohgL+h8Dn5BK Ux0iUHBCy+yQettxBalskTQBCp9f7oc/8kKry1xzZZAg/e3HaDlMuSC1eH0k2mZv NLdHhuDM1ICNanc+q02wF5T1l+Usdnj2MdK6MQcHS/Q6VnnEnRDvaDV6wLA1lldb ypeirGKyy1Zqh1J3qSsREe8bJxe+iRebKpO4DmkFW42xoHb2T+QTHt7djRdBeZAh IXE7Efyg03dJBZQscswdBQASgMnfVelmSNrC5zcGzHVIOCrAv3T9OzC5IzQ6vcow 4X/1XN8dGT+CnXNDgHwnRIaTBslEI1RnXfBK8h1plNlHnK+Yg27Rb4uX6AveXiZ7 cB4S0w== Received: from mail-qk1-f200.google.com (mail-qk1-f200.google.com [209.85.222.200]) by mx0a-0031df01.pphosted.com (PPS) with ESMTPS id 4bjy0a15mp-1 (version=TLSv1.3 cipher=TLS_AES_128_GCM_SHA256 bits=128 verify=NOT) for ; Fri, 09 Jan 2026 16:11:47 +0000 (GMT) Received: by mail-qk1-f200.google.com with SMTP id af79cd13be357-8b2de6600c0so1113438385a.1 for ; Fri, 09 Jan 2026 08:11:47 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=oss.qualcomm.com; s=google; t=1767975106; x=1768579906; darn=lists.linux.dev; h=content-transfer-encoding:in-reply-to:autocrypt:content-language :from:references:cc:to:subject:user-agent:mime-version:date :message-id:from:to:cc:subject:date:message-id:reply-to; bh=y0F3msY51CEG685pZ5Vd9mM1nAPXE1h7mU6gkqrwSxw=; b=AIL8JIuej+fZga1uDh+M9/ZmU677qVwKvVvD67zfoagv6WhFocVKOlvPc4Y3FHgKWS /fUtczEoaAMVFfuB+MO8yTREI/kfumdmkGAnfkvKNvP9CLE8R3D5ml9uGTbFULMbkTO3 VuTA6DIbcghQOD/zNIoZ+RrJtu78bk3cB5JYBY6pY/pFY5a8scXXosyJEset1CZ/YygP 6imzk4tB5o6PWzVa4urCPWUd+g65B8uZzFqKGxycrgwyQcv+6X7OHaK83tcUhhYyvI7H hBJGF6kuBoZkx9VWTmuOY6t90tdOTNBFODwmIhq7m4jqyaCl970VHz2qAHMTx1Wolrwi VmLw== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1767975106; x=1768579906; h=content-transfer-encoding:in-reply-to:autocrypt:content-language :from:references:cc:to:subject:user-agent:mime-version:date :message-id:x-gm-gg:x-gm-message-state:from:to:cc:subject:date :message-id:reply-to; bh=y0F3msY51CEG685pZ5Vd9mM1nAPXE1h7mU6gkqrwSxw=; b=qURs6zn2R7ZNrvAZ9/ulQuyO1haCNRRxqMnfceHxE+vncxWvNzxs+EAmKKR7ftw+SZ KI9Shf6/wXArwbdPSIhgGys/bX8qMLKf6KQRcTRLxcoiJuwpF3/5iLYE8bQX5N7+nWXo /LJvUXUggSOmw9ufxPO4v/69eT8oOmP2l1KM94jgz60L+xS5SqZEppDIZSwDCjU2er/j chX1p6wxagdzhR1p8Xn7fAju0psxwNkB/yAGzsUtiYJN8O5/GdAogD/1kQVDjREf3Ye6 EcKWpBtQlQMk/JobTqzT0q1Geb2uas6aVhrGcugIVZnr4RS0a+QNVzkJwW1Bgths4CZv X6Nw== X-Forwarded-Encrypted: i=1; AJvYcCUyr+dXNaPEwBqcZZ1FRGNIKd5LyVMZS864MDZLHCTiArlw166yirwpsTyNqQRSHeZnUIk=@lists.linux.dev X-Gm-Message-State: AOJu0Yzlj70tnHaijL12Jx3bsYvIivz0Mut/F//U7csoVBrOCxp8ygdF 1CJo0croDJ82fgrFXM6jVP5YuP3gLBPIgl2F3yoFEJeVF0SzeMugtaT6RNdHgoqRc1kSQfz3ZZp +YA8GoojqqgImaFLN+JTBAXup+lQBJlHe/mgljZBus3RbE8qc0OJlxXY= X-Gm-Gg: AY/fxX6UXLWreXNUOK2Y6WI3j90philouwTmQcup8WUsid2myhDrdZq0ALlPb5kILu4 jpsSm9pIXWppfNWQ636TXICWmsgBpNrYasvvrCwL3Nt6oygJBiyCQhH5bpkD4B302dZqxEfI2Ap kmIo15MAA4Bd1nPq4SraJMwGz+AXRgCKnPB4Kb+JgprWOyAwWLClASqPpnfcsU9BDpDyrvYXDwB lcYDw7n6peNZ8WB81C9wQ3ssqC7NUmGXdmm1kiptyQEaoD+U+XiNKW7Ih61K9VsbpcOO30B7cgh dBrxmnFtbvT+T2Fj5wqY4KKlbcApuyVXjFsyX/oothR3tfd4csH1oviEZBA7S7I4Og4IEQQobMh 7uA6iU07l6W7twXWcmA7SrUMo4cSSJKS18LcePg== X-Received: by 2002:a05:620a:2849:b0:8b1:f1e4:a3d2 with SMTP id af79cd13be357-8c3893917c6mr1302268085a.24.1767975106089; Fri, 09 Jan 2026 08:11:46 -0800 (PST) X-Google-Smtp-Source: AGHT+IGy5T1E7jUrBX1bssLpIPnC4OcyFtfkLbBfyt51Wt45hTzCQ0qm3TofJwyMoPJOoK6/cA59Eg== X-Received: by 2002:a05:620a:2849:b0:8b1:f1e4:a3d2 with SMTP id af79cd13be357-8c3893917c6mr1302260485a.24.1767975105583; Fri, 09 Jan 2026 08:11:45 -0800 (PST) Received: from [192.168.1.29] ([178.197.218.229]) by smtp.gmail.com with ESMTPSA id a640c23a62f3a-b842a4d31e7sm1189140466b.42.2026.01.09.08.11.42 (version=TLS1_3 cipher=TLS_AES_128_GCM_SHA256 bits=128/128); Fri, 09 Jan 2026 08:11:44 -0800 (PST) Message-ID: <09bc1f51-1836-4981-9fec-e3385c61aac6@oss.qualcomm.com> Date: Fri, 9 Jan 2026 17:11:41 +0100 Precedence: bulk X-Mailing-List: imx@lists.linux.dev List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 User-Agent: Mozilla Thunderbird Subject: Re: [PATCH 06/11] cdx: Simplify with scoped for each OF child loop To: Jonathan Cameron Cc: Miguel Ojeda , Rob Herring , Saravana Kannan , Nathan Chancellor , Nick Desaulniers , Bill Wendling , Justin Stitt , Russell King , Nicolas Ferre , Alexandre Belloni , Claudiu Beznea , Krzysztof Kozlowski , Alim Akhtar , Madhavan Srinivasan , Michael Ellerman , Nicholas Piggin , "Christophe Leroy (CS GROUP)" , Nipun Gupta , Nikhil Agarwal , Abel Vesa , Peng Fan , Michael Turquette , Stephen Boyd , Shawn Guo , Sascha Hauer , Pengutronix Kernel Team , Fabio Estevam , Vinod Koul , Sylwester Nawrocki , Mauro Carvalho Chehab , "Rafael J. Wysocki" , Viresh Kumar , linux-kernel@vger.kernel.org, devicetree@vger.kernel.org, llvm@lists.linux.dev, linux-arm-kernel@lists.infradead.org, linux-samsung-soc@vger.kernel.org, linuxppc-dev@lists.ozlabs.org, linux-clk@vger.kernel.org, imx@lists.linux.dev, dmaengine@vger.kernel.org, linux-media@vger.kernel.org, linux-pm@vger.kernel.org References: <20260105-of-for-each-compatible-scoped-v1-0-24e99c177164@oss.qualcomm.com> <20260105-of-for-each-compatible-scoped-v1-6-24e99c177164@oss.qualcomm.com> <20260106101733.000059e9@huawei.com> From: Krzysztof Kozlowski Content-Language: en-US Autocrypt: addr=krzysztof.kozlowski@oss.qualcomm.com; keydata= xsFNBFVDQq4BEAC6KeLOfFsAvFMBsrCrJ2bCalhPv5+KQF2PS2+iwZI8BpRZoV+Bd5kWvN79 cFgcqTTuNHjAvxtUG8pQgGTHAObYs6xeYJtjUH0ZX6ndJ33FJYf5V3yXqqjcZ30FgHzJCFUu JMp7PSyMPzpUXfU12yfcRYVEMQrmplNZssmYhiTeVicuOOypWugZKVLGNm0IweVCaZ/DJDIH gNbpvVwjcKYrx85m9cBVEBUGaQP6AT7qlVCkrf50v8bofSIyVa2xmubbAwwFA1oxoOusjPIE J3iadrwpFvsZjF5uHAKS+7wHLoW9hVzOnLbX6ajk5Hf8Pb1m+VH/E8bPBNNYKkfTtypTDUCj NYcd27tjnXfG+SDs/EXNUAIRefCyvaRG7oRYF3Ec+2RgQDRnmmjCjoQNbFrJvJkFHlPeHaeS BosGY+XWKydnmsfY7SSnjAzLUGAFhLd/XDVpb1Een2XucPpKvt9ORF+48gy12FA5GduRLhQU vK4tU7ojoem/G23PcowM1CwPurC8sAVsQb9KmwTGh7rVz3ks3w/zfGBy3+WmLg++C2Wct6nM Pd8/6CBVjEWqD06/RjI2AnjIq5fSEH/BIfXXfC68nMp9BZoy3So4ZsbOlBmtAPvMYX6U8VwD TNeBxJu5Ex0Izf1NV9CzC3nNaFUYOY8KfN01X5SExAoVTr09ewARAQABzTpLcnp5c3p0b2Yg S296bG93c2tpIDxrcnp5c3p0b2Yua296bG93c2tpQG9zcy5xdWFsY29tbS5jb20+wsGXBBMB CgBBFiEEm9B+DgxR+NWWd7dUG5NDfTtBYpsFAmkknB4CGwMFCRaWdJoFCwkIBwICIgIGFQoJ CAsCBBYCAwECHgcCF4AACgkQG5NDfTtBYpuCRw/+J19mfHuaPt205FXRSpogs/WWdheqNZ2s i50LIK7OJmBQ8+17LTCOV8MYgFTDRdWdM5PF2OafmVd7CT/K4B3pPfacHATtOqQFHYeHrGPf 2+4QxUyHIfx+Wp4GixnqpbXc76nTDv+rX8EbAB7e+9X35oKSJf/YhLFjGOD1Nl/s1WwHTJtQ a2XSXZ2T9HXa+nKMQfaiQI4WoFXjSt+tsAFXAuq1SLarpct4h52z4Zk//ET6Xs0zCWXm9HEz v4WR/Q7sycHeCGwm2p4thRak/B7yDPFOlZAQNdwBsnCkoFE1qLXI8ZgoWNd4TlcjG9UJSwru s1WTQVprOBYdxPkvUOlaXYjDo2QsSaMilJioyJkrniJnc7sdzcfkwfdWSnC+2DbHd4wxrRtW kajTc7OnJEiM78U3/GfvXgxCwYV297yClzkUIWqVpY2HYLBgkI89ntnN95ePyTnLSQ8WIZJk ug0/WZfTmCxX0SMxfCYt36QwlWsImHpArS6xjTvUwUNTUYN6XxYZuYBmJQF9eLERK2z3KUeY 2Ku5ZTm5axvlraM0VhUn8yv7G5Pciv7oGXJxrA6k4P9CAvHYeJSTXYnrLr/Kabn+6rc0my/l RMq9GeEUL3LbIUadL78yAtpf7HpNavYkVureuFD8xK8HntEHySnf7s2L28+kDbnDi27WR5kn u/POwU0EVUNcNAEQAM2StBhJERQvgPcbCzjokShn0cRA4q2SvCOvOXD+0KapXMRFE+/PZeDy fv4dEKuCqeh0hihSHlaxTzg3TcqUu54w2xYskG8Fq5tg3gm4kh1Gvh1LijIXX99ABA8eHxOG mLPRIBkXHqJYoHtCvPc6sYKNM9xbp6I4yF56xVLmHGJ61KaWKf5KKWYgA9kfHufbja7qR0c6 H79LIsiYqf92H1HNq1WlQpu/fh4/XAAaV1axHFt/dY/2kU05tLMj8GjeQDz1fHas7augL4ar gt4e+jum3NwtyupodQBxncKAUbzwKcDrPqUFmfRbJ7ARw8491xQHZDsP82JRj4cOJX32sBg8 nO2N5OsFJOcd5IE9v6qfllkZDAh1Rb1h6DFYq9dcdPAHl4zOj9EHq99/CpyccOh7SrtWDNFF knCmLpowhct95ZnlavBrDbOV0W47gO33WkXMFI4il4y1+Bv89979rVYn8aBohEgET41SpyQz 7fMkcaZU+ok/+HYjC/qfDxT7tjKXqBQEscVODaFicsUkjheOD4BfWEcVUqa+XdUEciwG/SgN yxBZepj41oVqFPSVE+Ni2tNrW/e16b8mgXNngHSnbsr6pAIXZH3qFW+4TKPMGZ2rZ6zITrMi p+12jgw4mGjy5y06JZvA02rZT2k9aa7i9dUUFggaanI09jNGbRA/ABEBAAHCwXwEGAEKACYC GwwWIQSb0H4ODFH41ZZ3t1Qbk0N9O0FimwUCaBdQXwUJFpZbKgAKCRAbk0N9O0Fim07TD/92 Vcmzn/jaEBcqyT48ODfDIQVvg2nIDW+qbHtJ8DOT0d/qVbBTU7oBuo0xuHo+MTBp0pSTWbTh LsSN1AuyP8wFKChC0JPcwOZZRS0dl3lFgg+c+rdZUHjsa247r+7fvm2zGG1/u+33lBJgnAIH 5lSCjhP4VXiGq5ngCxGRuBq+0jNCKyAOC/vq2cS/dgdXwmf2aL8G7QVREX7mSl0x+CjWyrpF c1D/9NV/zIWBG1NR1fFb+oeOVhRGubYfiS62htUQjGLK7qbTmrd715kH9Noww1U5HH7WQzeP t/SvC0RhQXNjXKBB+lwwM+XulFigmMF1KybRm7MNoLBrGDa3yGpAkHMkJ7NM4iSMdSxYAr60 RtThnhKc2kLIzd8GqyBh0nGPIL+1ZVMBDXw1Eu0/Du0rWt1zAKXQYVAfBLCTmkOnPU0fjR7q VT41xdJ6KqQMNGQeV+0o9X91X6VBeK6Na3zt5y4eWkve65DRlk1aoeBmhAteioLZlXkqu0pZ v+PKIVf+zFKuh0At/TN/618e/QVlZPbMeNSp3S3ieMP9Q6y4gw5CfgiDRJ2K9g99m6Rvlx1q wom6QbU06ltbvJE2K9oKd9nPp1NrBfBdEhX8oOwdCLJXEq83vdtOEqE42RxfYta4P3by0BHp cwzYbmi/Et7T2+47PN9NZAOyb771QoVr8A== In-Reply-To: <20260106101733.000059e9@huawei.com> Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 7bit X-Proofpoint-Spam-Details-Enc: AW1haW4tMjYwMTA5MDEyMSBTYWx0ZWRfX+gZvL0x5+pnw 5W8qL/ZMkoL740YVuzDUo539XVo7aOGiUqDTfGtHij2NqWzZyG8cuf5797BpHa5xIpF8Ks2HUKV gM5ISiNNMnr2/1iMzZoWN/YNePPZY6McG7dXTELMKGAlZW06C4oCwpBw/VRKcCzWF03IsizTk3r dhJryOS2b6CtPsu6FDVoCwxeKkmjHhUhDI4znIRHmSQDxBPweun+Pw0k2+1XAwsD1KtX9jKQPaS PymPHIRwSw1dI657PjapkPLuUjKQJ5+HowgM9dLaX0FxjMkKHU3M5apXpTEk/IW7VRQgdrHjMbz R7YjVUYza4eVbDtCp9x2o/ltzhdhOlViV8ghkqE8v46zMX06HB5PA8elVLgnFArwUFPru4ctQpq oGKmPFO5lXTdCwPemJDZJKNp3Rig/0SXuagqnMJy9nW1IDWD0LUwoQxK/Ex4JLyjBZJKoj4llH/ Z6439+DHPSVZorF8uhg== X-Proofpoint-ORIG-GUID: GH7-EouA4xHMfsWkBEdQLfqMi2x3zJO6 X-Proofpoint-GUID: GH7-EouA4xHMfsWkBEdQLfqMi2x3zJO6 X-Authority-Analysis: v=2.4 cv=QPFlhwLL c=1 sm=1 tr=0 ts=696128c3 cx=c_pps a=hnmNkyzTK/kJ09Xio7VxxA==:117 a=Eb9f15NH/cHKzfGOmZSO4Q==:17 a=IkcTkHD0fZMA:10 a=vUbySO9Y5rIA:10 a=s4-Qcg_JpJYA:10 a=VkNPw1HP01LnGYTKEx00:22 a=EUspDBNiAAAA:8 a=XFS3ILgPfShOvr1i8A8A:9 a=QEXdDO2ut3YA:10 a=PEH46H7Ffwr30OY-TuGO:22 X-Proofpoint-Virus-Version: vendor=baseguard engine=ICAP:2.0.293,Aquarius:18.0.1121,Hydra:6.1.9,FMLib:17.12.100.49 definitions=2026-01-09_04,2026-01-08_02,2025-10-01_01 X-Proofpoint-Spam-Details: rule=outbound_notspam policy=outbound score=0 clxscore=1015 adultscore=0 spamscore=0 bulkscore=0 lowpriorityscore=0 priorityscore=1501 malwarescore=0 impostorscore=0 suspectscore=0 phishscore=0 classifier=typeunknown authscore=0 authtc= authcc= route=outbound adjust=0 reason=mlx scancount=1 engine=8.22.0-2512120000 definitions=main-2601090121 On 06/01/2026 11:17, Jonathan Cameron wrote: > On Mon, 05 Jan 2026 14:33:44 +0100 > Krzysztof Kozlowski wrote: > >> Use scoped for-each loop when iterating over device nodes to make code a >> bit simpler. >> >> Signed-off-by: Krzysztof Kozlowski > I'd be tempted to make one more tweak in this one to bring > it inline with the suggestions around not combining scoped cleanups > with gotos (see the comments in cleanup.h) > > No bug here, just nice to have. >> >> --- >> >> Depends on the first patch. >> --- >> drivers/cdx/cdx.c | 4 +--- >> 1 file changed, 1 insertion(+), 3 deletions(-) >> >> diff --git a/drivers/cdx/cdx.c b/drivers/cdx/cdx.c >> index b39af2f1937f..bbde529aaa93 100644 >> --- a/drivers/cdx/cdx.c >> +++ b/drivers/cdx/cdx.c >> @@ -608,7 +608,6 @@ static ssize_t rescan_store(const struct bus_type *bus, >> { >> struct cdx_controller *cdx; >> struct platform_device *pd; >> - struct device_node *np; >> bool val; >> >> if (kstrtobool(buf, &val) < 0) >> @@ -623,10 +622,9 @@ static ssize_t rescan_store(const struct bus_type *bus, >> cdx_unregister_devices(&cdx_bus_type); >> >> /* Rescan all the devices */ >> - for_each_compatible_node(np, NULL, compat_node_name) { >> + for_each_compatible_node_scoped(np, NULL, compat_node_name) { >> pd = of_find_device_by_node(np); >> if (!pd) { >> - of_node_put(np); >> count = -EINVAL; >> goto unlock; > break instead. > Or better yet a follow up patch to use guard() for the mutex allowing a > direct return here. Oh yes and it allows to drop that -EINVAL assignment to size_t. Best regards, Krzysztof