From: Liu Ying <victor.liu@nxp.com>
To: Luca Ceresoli <luca.ceresoli@bootlin.com>,
Andrzej Hajda <andrzej.hajda@intel.com>,
Neil Armstrong <neil.armstrong@linaro.org>,
Robert Foss <rfoss@kernel.org>,
Laurent Pinchart <Laurent.pinchart@ideasonboard.com>,
Jonas Karlman <jonas@kwiboo.se>,
Jernej Skrabec <jernej.skrabec@gmail.com>,
Maarten Lankhorst <maarten.lankhorst@linux.intel.com>,
Maxime Ripard <mripard@kernel.org>,
Thomas Zimmermann <tzimmermann@suse.de>,
David Airlie <airlied@gmail.com>, Simona Vetter <simona@ffwll.ch>,
Shawn Guo <shawnguo@kernel.org>,
Sascha Hauer <s.hauer@pengutronix.de>,
Pengutronix Kernel Team <kernel@pengutronix.de>,
Fabio Estevam <festevam@gmail.com>
Cc: Hui Pu <Hui.Pu@gehealthcare.com>,
Thomas Petazzoni <thomas.petazzoni@bootlin.com>,
dri-devel@lists.freedesktop.org, imx@lists.linux.dev,
linux-arm-kernel@lists.infradead.org,
linux-kernel@vger.kernel.org
Subject: Re: [PATCH v4 1/4] drm/bridge: imx8qxp-pixel-link: simplify logic to find next bridge
Date: Mon, 26 Jan 2026 16:07:51 +0800 [thread overview]
Message-ID: <0c617344-2407-4564-9f87-73d71bae7047@nxp.com> (raw)
In-Reply-To: <20260107-drm-bridge-alloc-getput-drm_of_find_bridge-v4-1-a62b4399a6bf@bootlin.com>
On Wed, Jan 07, 2026 at 10:56:26AM +0100, Luca Ceresoli wrote:
> imx8qxp_pixel_link_find_next_bridge() uses a sophisticated logic to find
> the preferred next bridge, using an array with two supporting index
> variables. This is more sophisticated than required because we only ever
> need a pointer to the "current" bridge and to the "best so far" bridge.
>
> Additionally this logic is going to make the addition of proper refcounting
> quite complex.
>
> Rewrite the logic using two drm_bridge pointers, which is by itself
> slightly simpler and is a preparation step for introducing bridge
> refcounting in a later commit.
>
> Also reword a comment to make it clearer.
>
> Signed-off-by: Luca Ceresoli <luca.ceresoli@bootlin.com>
> ---
> drivers/gpu/drm/bridge/imx/imx8qxp-pixel-link.c | 23 +++++++++++------------
> 1 file changed, 11 insertions(+), 12 deletions(-)
Reviewed-by: Liu Ying <victor.liu@nxp.com>
next prev parent reply other threads:[~2026-01-26 8:07 UTC|newest]
Thread overview: 21+ messages / expand[flat|nested] mbox.gz Atom feed top
2026-01-07 9:56 [PATCH v4 0/4] drm/bridge: add of_drm_find_and_get_bridge() and a managed *next_bridge, deprecate of_drm_find_bridge() Luca Ceresoli
2026-01-07 9:56 ` [PATCH v4 1/4] drm/bridge: imx8qxp-pixel-link: simplify logic to find next bridge Luca Ceresoli
2026-01-26 8:07 ` Liu Ying [this message]
2026-01-07 9:56 ` [PATCH v4 2/4] drm/bridge: imx8qxp-pixel-link: simplify freeing of the remote device_node Luca Ceresoli
2026-01-26 8:09 ` Liu Ying
2026-01-07 9:56 ` [PATCH v4 3/4] drm/bridge: imx8qxp-pixel-link: imx8qxp_pixel_link_find_next_bridge: return int, not ERR_PTR Luca Ceresoli
2026-01-26 8:10 ` Liu Ying
2026-01-07 9:56 ` [PATCH v4 4/4] drm/bridge: imx8qxp-pixel-link: get/put the next bridge Luca Ceresoli
2026-01-26 8:06 ` Liu Ying
2026-01-26 18:18 ` Luca Ceresoli
2026-01-26 21:57 ` Luca Ceresoli
2026-01-27 3:54 ` Liu Ying
2026-01-28 15:58 ` Luca Ceresoli
2026-01-29 7:49 ` Liu Ying
2026-01-29 8:18 ` Liu Ying
2026-01-31 17:43 ` Luca Ceresoli
2026-01-26 8:14 ` Liu Ying
2026-01-26 21:42 ` Luca Ceresoli
2026-01-09 9:53 ` [PATCH v4 0/4] drm/bridge: add of_drm_find_and_get_bridge() and a managed *next_bridge, deprecate of_drm_find_bridge() Liu Ying
2026-01-09 10:43 ` Luca Ceresoli
2026-01-29 18:04 ` (subset) " Luca Ceresoli
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=0c617344-2407-4564-9f87-73d71bae7047@nxp.com \
--to=victor.liu@nxp.com \
--cc=Hui.Pu@gehealthcare.com \
--cc=Laurent.pinchart@ideasonboard.com \
--cc=airlied@gmail.com \
--cc=andrzej.hajda@intel.com \
--cc=dri-devel@lists.freedesktop.org \
--cc=festevam@gmail.com \
--cc=imx@lists.linux.dev \
--cc=jernej.skrabec@gmail.com \
--cc=jonas@kwiboo.se \
--cc=kernel@pengutronix.de \
--cc=linux-arm-kernel@lists.infradead.org \
--cc=linux-kernel@vger.kernel.org \
--cc=luca.ceresoli@bootlin.com \
--cc=maarten.lankhorst@linux.intel.com \
--cc=mripard@kernel.org \
--cc=neil.armstrong@linaro.org \
--cc=rfoss@kernel.org \
--cc=s.hauer@pengutronix.de \
--cc=shawnguo@kernel.org \
--cc=simona@ffwll.ch \
--cc=thomas.petazzoni@bootlin.com \
--cc=tzimmermann@suse.de \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox