From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from smtp.kernel.org (aws-us-west-2-korg-mail-1.web.codeaurora.org [10.30.226.201]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id 4AAC52B9B4; Fri, 14 Mar 2025 18:11:53 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=10.30.226.201 ARC-Seal:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1741975914; cv=none; b=uPAiCYXKlMQdH98R8n+2Cofj7jCVjDXjQvVzOOCjYqN7o6WPfVXNzoAmEA1XBNlBPnJ0UHVtCICe7WkPQ63Da7xxLX5eqSIkA4//Knijodzl/8oRz3A74PtcPbaRS1B6c+5rj7NQuW0j6as3yAnmTNNbahgG+386nmG1DPRGhSU= ARC-Message-Signature:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1741975914; c=relaxed/simple; bh=ngZOWsfXuCD39NLjndi5h6K1uhUdOH7LeujeO4Dg3GI=; h=Message-ID:Date:From:To:Subject:In-Reply-To:References:Cc; b=Dd0Cr9XIc9kEdynhy4Dcr5eUab8sbTrHuFREWzc/3VO9PABhcMevlGaNHYgymit9lQgULEl2xrjvt8XUlaaD0q9sLaEp+6USVDM33+0tNv1ZYHl217TjMOOiBKcuVp2EZqUWVMfkP/WwbNelZ8FP0gGITQQCiR57wMtEY5h1ekI= ARC-Authentication-Results:i=1; smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=kernel.org header.i=@kernel.org header.b=Mg4rrMcA; arc=none smtp.client-ip=10.30.226.201 Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=kernel.org header.i=@kernel.org header.b="Mg4rrMcA" Received: by smtp.kernel.org (Postfix) with ESMTPSA id 3BE89C4CEE3; Fri, 14 Mar 2025 18:11:53 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=kernel.org; s=k20201202; t=1741975913; bh=ngZOWsfXuCD39NLjndi5h6K1uhUdOH7LeujeO4Dg3GI=; h=Date:From:To:Subject:In-Reply-To:References:Cc:From; b=Mg4rrMcAry4vXwrRGRMZaODYR7HScvj0eqWPlp8rPomU+3SzPYILi9Z5o6PLq2I3n bDh51/9S1vJP+Wi3fJROLpEnMJw9KxIHdcqfK9Z4/0Jb+RyXwPwayqdbdns3x1gRuF LG8EuYiWD0cW0fjhbRb6EY3bJqzp3qojob5pkIkxdBbxSo3wkji4g5OyKULTG6m3wT kTu7WGyoqOy1MbLGQLTLA7q7jW0i1NiJKAjhgtuIjIFZ8XUC3NLN7lo4c9iTM0Mbgc ls7OuQ8SXtpy0fowNpKsOsz2NBG43Xb0m1Bf78/8orKP/BdPaztl5RERtuNxs/KQ81 isHcd+RUuaB9w== Message-ID: <0cc45a0aae50ab25262691c7145082e1@kernel.org> Date: Fri, 14 Mar 2025 18:11:51 +0000 From: "Maxime Ripard" To: "Luca Ceresoli" Subject: Re: [PATCH v7 07/11] drm/mxsfb: put the bridge returned by drm_bridge_chain_get_first_bridge() In-Reply-To: <20250314-drm-bridge-refcount-v7-7-152571f8c694@bootlin.com> References: <20250314-drm-bridge-refcount-v7-7-152571f8c694@bootlin.com> Cc: dri-devel@lists.freedesktop.org, imx@lists.linux.dev, linux-arm-kernel@lists.infradead.org, linux-kernel@vger.kernel.org, "Andrzej Hajda" , "Anusha Srivatsa" , "David Airlie" , "Dmitry Baryshkov" , "Fabio Estevam" , =?utf-8?b?SGVydsOpIENvZGluYQ==?= , "Hui Pu" , "Inki Dae" , "Jagan Teki" , "Jernej Skrabec" , "Jonas Karlman" , "Laurent Pinchart" , "Maarten Lankhorst" , "Marek Szyprowski" , "Marek Vasut" , "Maxime Ripard" , "Neil Armstrong" , "Paul Kocialkowski" , "Pengutronix Kernel Team" , "Robert Foss" , "Sascha Hauer" , "Shawn Guo" , "Simona Vetter" , "Stefan Agner" , "Thomas Petazzoni" , "Thomas Zimmermann" Content-Transfer-Encoding: 7bit Precedence: bulk X-Mailing-List: imx@lists.linux.dev List-Id: List-Subscribe: List-Unsubscribe: On Fri, 14 Mar 2025 11:31:20 +0100, Luca Ceresoli wrote: > The bridge returned by drm_bridge_chain_get_first_bridge() is > refcounted. Put it when done. Use a scope-based free action to catch all > the code paths. > > Signed-off-by: Luca Ceresoli > > [ ... ] Reviewed-by: Maxime Ripard Thanks! Maxime