From: Krzysztof Kozlowski <krzk@kernel.org>
To: Max Merchel <Max.Merchel@ew.tq-group.com>,
Rob Herring <robh@kernel.org>,
Krzysztof Kozlowski <krzk+dt@kernel.org>,
Conor Dooley <conor+dt@kernel.org>, Frank Li <Frank.Li@nxp.com>,
Sascha Hauer <s.hauer@pengutronix.de>,
Pengutronix Kernel Team <kernel@pengutronix.de>,
Fabio Estevam <festevam@gmail.com>
Cc: linux@ew.tq-group.com, devicetree@vger.kernel.org,
imx@lists.linux.dev, linux-arm-kernel@lists.infradead.org,
linux-kernel@vger.kernel.org
Subject: Re: [PATCH 1/4] ARM: dts: imx6qdl-tqma6: add missing labels
Date: Wed, 18 Feb 2026 20:42:43 +0100 [thread overview]
Message-ID: <0d6e728f-4677-4267-9dff-8d089d2dc187@kernel.org> (raw)
In-Reply-To: <20260218132228.32056-2-Max.Merchel@ew.tq-group.com>
On 18/02/2026 14:22, Max Merchel wrote:
> Add the missing labels for the temperature sensor and the EEPROM.
> In SoM variants A and B, the components are connected to different
> I2C buses. These labels are needed to reference them in subsequent
> device trees.
That's not a change on its own. It makes no impact, no effect and is
confusing because unused labels shall be removed.
So you apply this patch and immediately revert it because these labels
are unused.
No, squash it instead with the USER of the label.
Best regards,
Krzysztof
next prev parent reply other threads:[~2026-02-18 19:42 UTC|newest]
Thread overview: 7+ messages / expand[flat|nested] mbox.gz Atom feed top
2026-02-18 13:22 [PATCH 0/4] ARM: dts: TQMa6: modify for use in bootloaders Max Merchel
2026-02-18 13:22 ` [PATCH 1/4] ARM: dts: imx6qdl-tqma6: add missing labels Max Merchel
2026-02-18 19:42 ` Krzysztof Kozlowski [this message]
2026-02-18 13:22 ` [PATCH 2/4] ARM: dts: imx6qdl: add boot phase properties Max Merchel
2026-02-18 13:22 ` [PATCH 3/4] ARM: dts: imx6qdl-tqma6: " Max Merchel
2026-02-18 13:22 ` [PATCH 4/4] ARM: dts: imx6qdl-mba6: " Max Merchel
2026-02-18 17:05 ` [PATCH 0/4] ARM: dts: TQMa6: modify for use in bootloaders Frank Li
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=0d6e728f-4677-4267-9dff-8d089d2dc187@kernel.org \
--to=krzk@kernel.org \
--cc=Frank.Li@nxp.com \
--cc=Max.Merchel@ew.tq-group.com \
--cc=conor+dt@kernel.org \
--cc=devicetree@vger.kernel.org \
--cc=festevam@gmail.com \
--cc=imx@lists.linux.dev \
--cc=kernel@pengutronix.de \
--cc=krzk+dt@kernel.org \
--cc=linux-arm-kernel@lists.infradead.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux@ew.tq-group.com \
--cc=robh@kernel.org \
--cc=s.hauer@pengutronix.de \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox