From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from mgamail.intel.com (mgamail.intel.com [192.198.163.8]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id A1E43228C9D for ; Fri, 21 Mar 2025 16:09:46 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=192.198.163.8 ARC-Seal:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1742573388; cv=none; b=W4kNiMxObr7RDAD+f7qqXqeR/gpdo/cc6KsO59+BKwCLbm1LqhO3F0Ki7tqHTz0+vPq/I1tw4KSovrQiecaRhM1HbMN/wMYd5caw9VSpp/EH+r56W+2O74I4gOTFd5Bz0hWX5oOy6Yhr5s8HmKja4p9J3ycriE5O01Yi8d/uxz4= ARC-Message-Signature:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1742573388; c=relaxed/simple; bh=aDAlamYyZ4jkLWyWBaRa75vEGUzN9zvUrX/xuDuvQhE=; h=From:Date:To:cc:Subject:In-Reply-To:Message-ID:References: MIME-Version:Content-Type; b=mjKwpjAsjlsEZgPVPy7HlL84saVuSCJdYOIaRltwZD/Ty0ZRa0uJ+TowunJeUS7jpNcnis/1cfaArsHKgU/VEffN9papz58C2sdhEYWGqApNAxOxAbU5HJef+n3gVChpkhlFt2VWZCL08EktTBZTxhwkf+0cJbKvOePCjWaRTFI= ARC-Authentication-Results:i=1; smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=linux.intel.com; spf=none smtp.mailfrom=linux.intel.com; dkim=pass (2048-bit key) header.d=intel.com header.i=@intel.com header.b=C9kolSwM; arc=none smtp.client-ip=192.198.163.8 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=linux.intel.com Authentication-Results: smtp.subspace.kernel.org; spf=none smtp.mailfrom=linux.intel.com Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=intel.com header.i=@intel.com header.b="C9kolSwM" DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=intel.com; i=@intel.com; q=dns/txt; s=Intel; t=1742573387; x=1774109387; h=from:date:to:cc:subject:in-reply-to:message-id: references:mime-version; bh=aDAlamYyZ4jkLWyWBaRa75vEGUzN9zvUrX/xuDuvQhE=; b=C9kolSwMUG9WgTVg3fAWWMJmS0ddZM6UHkVDDW73WwQwLKp5r7GrKoqe IyfkaIcbKW5pJfwwgUgzqTg70CbaT9JhD6J7HZ5MsvDAFbAVRxs00iC3J 36A3woWEfadYWyVXRs1pB4xmD6KQ2lFDvPTb+gf5DvR+18bMXgYcb5lTd YP4NdyK4EeDr6lnHKMcAN5VhctwtxZQkIffxJDA9hBlJrlEtj5Mkrlqwg 9+ZePsTMbgfNN+C+w7uwxKuR0OCrQpCoHO1ZyXH5PI7GPYhPakdxy+Fiq jUlSkpHQwW6pd667BCwiS4xG/3DGgWiuAqbRO/R+ukPwKU3heQ4tdVtOP Q==; X-CSE-ConnectionGUID: 0eaMMSY1TfedPBptoh7YNA== X-CSE-MsgGUID: 713HfBqKR6691KPHRUJaxQ== X-IronPort-AV: E=McAfee;i="6700,10204,11380"; a="61366665" X-IronPort-AV: E=Sophos;i="6.14,264,1736841600"; d="scan'208";a="61366665" Received: from orviesa008.jf.intel.com ([10.64.159.148]) by fmvoesa102.fm.intel.com with ESMTP/TLS/ECDHE-RSA-AES256-GCM-SHA384; 21 Mar 2025 09:08:47 -0700 X-CSE-ConnectionGUID: s+SzOXF7TAiwIAcfG0mbgQ== X-CSE-MsgGUID: 6hxEBaxKRL6vcWoyAx4wig== X-ExtLoop1: 1 X-IronPort-AV: E=Sophos;i="6.14,264,1736841600"; d="scan'208";a="124388577" Received: from ijarvine-mobl1.ger.corp.intel.com (HELO localhost) ([10.245.245.112]) by orviesa008-auth.jf.intel.com with ESMTP/TLS/ECDHE-RSA-AES256-GCM-SHA384; 21 Mar 2025 09:08:30 -0700 From: =?UTF-8?q?Ilpo=20J=C3=A4rvinen?= Date: Fri, 21 Mar 2025 18:08:26 +0200 (EET) To: Easwar Hariharan , Andrew Morton cc: Yaron Avizrat , Oded Gabbay , Julia Lawall , Nicolas Palix , James Smart , Dick Kennedy , "James E.J. Bottomley" , "Martin K. Petersen" , Jaroslav Kysela , Takashi Iwai , Chris Mason , Josef Bacik , David Sterba , Ilya Dryomov , Dongsheng Yang , Jens Axboe , Xiubo Li , Damien Le Moal , Niklas Cassel , Carlos Maiolino , "Darrick J. Wong" , Sebastian Reichel , Keith Busch , Christoph Hellwig , Sagi Grimberg , Frank Li , Mark Brown , Shawn Guo , Sascha Hauer , Pengutronix Kernel Team , Fabio Estevam , Shyam Sundar S K , Hans de Goede , =?ISO-8859-15?Q?Ilpo_J=E4rvinen?= , Henrique de Moraes Holschuh , Selvin Xavier , Kalesh AP , Jason Gunthorpe , Leon Romanovsky , cocci@inria.fr, LKML , linux-scsi@vger.kernel.org, dri-devel@lists.freedesktop.org, linux-sound@vger.kernel.org, linux-btrfs@vger.kernel.org, ceph-devel@vger.kernel.org, linux-block@vger.kernel.org, linux-ide@vger.kernel.org, linux-xfs@vger.kernel.org, linux-pm@vger.kernel.org, linux-nvme@lists.infradead.org, linux-spi@vger.kernel.org, imx@lists.linux.dev, linux-arm-kernel@lists.infradead.org, platform-driver-x86@vger.kernel.org, ibm-acpi-devel@lists.sourceforge.net, linux-rdma@vger.kernel.org Subject: Re: [PATCH v3 14/16] platform/x86/amd/pmf: convert timeouts to secs_to_jiffies() In-Reply-To: <20250225-converge-secs-to-jiffies-part-two-v3-14-a43967e36c88@linux.microsoft.com> Message-ID: <1252f601-97fd-f199-c339-5bd4ea8060dc@linux.intel.com> References: <20250225-converge-secs-to-jiffies-part-two-v3-0-a43967e36c88@linux.microsoft.com> <20250225-converge-secs-to-jiffies-part-two-v3-14-a43967e36c88@linux.microsoft.com> Precedence: bulk X-Mailing-List: imx@lists.linux.dev List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 Content-Type: text/plain; charset=US-ASCII On Tue, 25 Feb 2025, Easwar Hariharan wrote: > Commit b35108a51cf7 ("jiffies: Define secs_to_jiffies()") introduced > secs_to_jiffies(). As the value here is a multiple of 1000, use > secs_to_jiffies() instead of msecs_to_jiffies() to avoid the multiplication > > This is converted using scripts/coccinelle/misc/secs_to_jiffies.cocci with > the following Coccinelle rules: > > @depends on patch@ > expression E; > @@ > > -msecs_to_jiffies > +secs_to_jiffies > (E > - * \( 1000 \| MSEC_PER_SEC \) > ) > > Signed-off-by: Easwar Hariharan Applied to the review-ilpo-next branch. > --- > drivers/platform/x86/amd/pmf/acpi.c | 2 +- > 1 file changed, 1 insertion(+), 1 deletion(-) > > diff --git a/drivers/platform/x86/amd/pmf/acpi.c b/drivers/platform/x86/amd/pmf/acpi.c > index dd5780a1d06e1dc979fcff5bafd6729bc4937eab..f75f7ecd8cd91c9d55abc38ce6e46eed7fe69fc0 100644 > --- a/drivers/platform/x86/amd/pmf/acpi.c > +++ b/drivers/platform/x86/amd/pmf/acpi.c > @@ -220,7 +220,7 @@ static void apmf_sbios_heartbeat_notify(struct work_struct *work) > if (!info) > return; > > - schedule_delayed_work(&dev->heart_beat, msecs_to_jiffies(dev->hb_interval * 1000)); > + schedule_delayed_work(&dev->heart_beat, secs_to_jiffies(dev->hb_interval)); > kfree(info); > } > > > -- i.