From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from mx1.tq-group.com (mx1.tq-group.com [93.104.207.81]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id 96CA121D594 for ; Tue, 10 Jun 2025 07:12:40 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=93.104.207.81 ARC-Seal:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1749539563; cv=none; b=NUaeN5IDkdGQThWeTWpI/KUzq1g0zTrN99JPdaIgNpzy0La2Ir01pINRmaW/bgWLYL8r281MwuorAHiQfvcdNuRtYS3lEK4Ap+UCAmNbqyyzxxSasNYTSLP2wz8/U9FeeWyyTI990CwIQJz1ujLffWVHTV6b3rI240pZxfB/Q0Y= ARC-Message-Signature:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1749539563; c=relaxed/simple; bh=DXw/aHoO9WgBP02VjUM0ndsg+Bzs/qIHJdOqcWLJZsc=; h=From:To:Cc:Subject:Date:Message-ID:In-Reply-To:References: MIME-Version:Content-Type; b=l23pa2eTlZYTlTKqO4jdEhA7Wkl9PfemtGOVUJ2snJMBb/rv3uDNjKMNfnbFxIv/9cCnKp98XzvIPs65n8pFzaLmStjAmjDFwTMpCgSgEHjcBk/YMXA1gKvNGXPnY7SW2R9XjcB/k40Uqi7lfyNzW1ahu9tsJlBij4Gqtpvmnas= ARC-Authentication-Results:i=1; smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=ew.tq-group.com; spf=pass smtp.mailfrom=ew.tq-group.com; dkim=pass (2048-bit key) header.d=tq-group.com header.i=@tq-group.com header.b=kzSTQtMJ; dkim=fail (0-bit key) header.d=ew.tq-group.com header.i=@ew.tq-group.com header.b=LMsECaz/ reason="key not found in DNS"; arc=none smtp.client-ip=93.104.207.81 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=ew.tq-group.com Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=ew.tq-group.com Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=tq-group.com header.i=@tq-group.com header.b="kzSTQtMJ"; dkim=fail reason="key not found in DNS" (0-bit key) header.d=ew.tq-group.com header.i=@ew.tq-group.com header.b="LMsECaz/" DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=tq-group.com; i=@tq-group.com; q=dns/txt; s=key1; t=1749539560; x=1781075560; h=from:to:cc:subject:date:message-id:in-reply-to: references:mime-version:content-transfer-encoding; bh=IA7dsIXLKv7cmvpo+Mybfca1vUSev2LFZHY5ABbB46A=; b=kzSTQtMJLxjT2xtm53rzhkGvilF3ple1IFiylaGbA8CL+cteRP9XUBiM C/IcdrP7qDZiGReqC+fBBhryRU0jtOtCalV0aiYa3bSQ9SeWJ8bUy4kK1 579fGEE8MZePOzFjFW56uUoPnO7E0wBd3tdP4xGr/XqPFNwcwBkOCH0m2 JxTqB8Dic2e0sEErWr3V0VkQF5G3Ybg+6utGkx9u2+Xb96wbvITPm0TSH n0YmsV1vZtNjNS0utNkOu1M+rAEiV8FmH368uUqb0LuLgBfxkcOdjDtvB H6fE3QJrEX/KxVvoDEEhoGbFa0RZrvDJuMD7iPQ73JfG3stKhmm4+uscU g==; X-CSE-ConnectionGUID: fA3TVHqiRBOxqf/Q+mGaRw== X-CSE-MsgGUID: rGinyqaER6WoZUKPcnwIwg== X-IronPort-AV: E=Sophos;i="6.16,224,1744063200"; d="scan'208";a="44535023" Received: from vmailcow01.tq-net.de ([10.150.86.48]) by mx1.tq-group.com with ESMTP; 10 Jun 2025 09:12:32 +0200 X-CheckPoint: {6847DAE0-18-476CAA88-C60F6DCB} X-MAIL-CPID: 1FD1400D779E047ACCE98C823177DC56_1 X-Control-Analysis: str=0001.0A00639C.6847DB01.000A,ss=1,re=0.000,recu=0.000,reip=0.000,cl=1,cld=1,fgs=0 Received: from [127.0.0.1] (localhost [127.0.0.1]) by localhost (Mailerdaemon) with ESMTPSA id 8EBD51644F0; Tue, 10 Jun 2025 09:12:26 +0200 (CEST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=ew.tq-group.com; s=dkim; t=1749539548; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:cc:mime-version:mime-version:content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references; bh=IA7dsIXLKv7cmvpo+Mybfca1vUSev2LFZHY5ABbB46A=; b=LMsECaz/6WqFjW9c9hSzKZqdCwCDa7iRyEGktjb4aXxAdE5PcO/HeMC4dPHYHX7JQPA1El vXGolpoMVPdD7IQJnJ6KwBqcC4k45BGMW7vwqyQ/YmC67Uv4eRwEXUiGINXBn+Uy+4NMn2 bPwnSoUdO8j+Xd/1/t2eGCBNBiEW1sCC8cA7ra3vAoRVQZlSZ0z20Zn7ebMuDCSEMhrxqD i9HSyP3CGV7a67V/4HtqEUdfrYbINCxTkuxz09QQBjiCqaVbClP/Sx6mWEIcLHEiNvzYyn Uju+GLjSwjvb33OwFT7TTbhiulKoA85W4XOkn3JVfHYfAqKi/CNvKCPPMEWLHA== From: Alexander Stein To: linux-media@vger.kernel.org, Laurent Pinchart Cc: Isaac Scott , Rui Miguel Silva , Martin Kepplinger , Purism Kernel Team , Mauro Carvalho Chehab , Rob Herring , Krzysztof Kozlowski , Conor Dooley , Shawn Guo , Sascha Hauer , Pengutronix Kernel Team , Fabio Estevam , devicetree@vger.kernel.org, imx@lists.linux.dev, linux-arm-kernel@lists.infradead.org Subject: Re: [PATCH 2/8] media: imx-mipi-csis: Fix field alignment in register dump Date: Tue, 10 Jun 2025 09:12:26 +0200 Message-ID: <12685072.O9o76ZdvQC@steina-w> Organization: TQ-Systems GmbH In-Reply-To: <20250608235840.23871-3-laurent.pinchart@ideasonboard.com> References: <20250608235840.23871-1-laurent.pinchart@ideasonboard.com> <20250608235840.23871-3-laurent.pinchart@ideasonboard.com> Precedence: bulk X-Mailing-List: imx@lists.linux.dev List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 Content-Transfer-Encoding: quoted-printable Content-Type: text/plain; charset="iso-8859-1" X-Last-TLS-Session-Version: TLSv1.3 Hi Laurent, thanks for the patch. Am Montag, 9. Juni 2025, 01:58:34 CEST schrieb Laurent Pinchart: > Commit 95a1379004cb ("media: staging: media: imx: imx7-mipi-csis: Dump > MIPI_CSIS_FRAME_COUNTER_CH0 register") forgot to increase the maximum > register name length, resulting in misalignment of names printed in the > kernel log. Fix it. Does this warrant a Fixes tag? Anyway Reviewed-by: Alexander Stein >=20 > Signed-off-by: Laurent Pinchart > --- > drivers/media/platform/nxp/imx-mipi-csis.c | 2 +- > 1 file changed, 1 insertion(+), 1 deletion(-) >=20 > diff --git a/drivers/media/platform/nxp/imx-mipi-csis.c b/drivers/media/p= latform/nxp/imx-mipi-csis.c > index d59666ef7545..b652d59851c2 100644 > --- a/drivers/media/platform/nxp/imx-mipi-csis.c > +++ b/drivers/media/platform/nxp/imx-mipi-csis.c > @@ -895,7 +895,7 @@ static int mipi_csis_dump_regs(struct mipi_csis_devic= e *csis) > =20 > for (i =3D 0; i < ARRAY_SIZE(registers); i++) { > cfg =3D mipi_csis_read(csis, registers[i].offset); > - dev_info(csis->dev, "%14s: 0x%08x\n", registers[i].name, cfg); > + dev_info(csis->dev, "%17s: 0x%08x\n", registers[i].name, cfg); > } > =20 > pm_runtime_put(csis->dev); >=20 =2D-=20 TQ-Systems GmbH | M=FChlstra=DFe 2, Gut Delling | 82229 Seefeld, Germany Amtsgericht M=FCnchen, HRB 105018 Gesch=E4ftsf=FChrer: Detlef Schneider, R=FCdiger Stahl, Stefan Schneider http://www.tq-group.com/