Re: [PATCH 2/3] arm64: dts: freescale: add initial device tree for TQMa93xx/MBa93xxLA-MINI

Alexander Stein
2026-03-17T12:14:04Z

Hi,

Am Dienstag, 17. März 2026, 13:10:06 CET schrieb Krzysztof Kozlowski:
> On 17/03/2026 12:17, Alexander Stein wrote:
> > From: Martin Schmiedel <Martin.Schmiedel@tq-group.com>
> >
> > This adds support for TQMa93xx module attached to MBa93xxLA-MINI board.
>
>
> Please do not use "This commit/patch/change", but imperative mood. See
> longer explanation here:
> https://elixir.bootlin.com/linux/v6.16/source/Documentation/process/submitting-patches.rst#L94

Sure, will do in v2. Thanks.

> > TQMa93xx is a SOM series using i.MX93 SOC.
> > The MBa93xxLA-MINI has a small form factor and is designed with
> > WLAN, Bluetooth and WWAN applications in mind.
> >
> > Signed-off-by: Martin Schmiedel <Martin.Schmiedel@tq-group.com>
> > Signed-off-by: Alexander Stein <alexander.stein@ew.tq-group.com>
> > ---
> > arch/arm64/boot/dts/freescale/Makefile | 1 +
> > .../imx93-tqma9352-mba93xxla-mini.dts | 637 ++++++++++++++++++
> > 2 files changed, 638 insertions(+)
> > create mode 100644 arch/arm64/boot/dts/freescale/imx93-tqma9352-mba93xxla-mini.dts
> >
> > diff --git a/arch/arm64/boot/dts/freescale/Makefile b/arch/arm64/boot/dts/freescale/Makefile
> > index 31bc80586c682..db536522600ac 100644
> > --- a/arch/arm64/boot/dts/freescale/Makefile
> > +++ b/arch/arm64/boot/dts/freescale/Makefile
> > @@ -461,6 +461,7 @@ dtb-$(CONFIG_ARCH_MXC) += imx93-phycore-rpmsg.dtb
> > dtb-$(CONFIG_ARCH_MXC) += imx93-tqma9352-mba91xxca.dtb
> > dtb-$(CONFIG_ARCH_MXC) += imx93-tqma9352-mba93xxca.dtb
> > dtb-$(CONFIG_ARCH_MXC) += imx93-tqma9352-mba93xxla.dtb
> > +dtb-$(CONFIG_ARCH_MXC) += imx93-tqma9352-mba93xxla-mini.dtb
> >
> > imx93-tqma9352-mba91xxca-lvds-tm070jvhg33-dtbs := imx93-tqma9352-mba91xxca.dtb imx93-tqma9352-mba91xxca-lvds-tm070jvhg33.dtbo
> > imx93-tqma9352-mba91xxca-rgb-cdtech-dc44-dtbs := imx93-tqma9352-mba91xxca.dtb imx93-tqma9352-mba91xxca-rgb-cdtech-dc44.dtbo
> > diff --git a/arch/arm64/boot/dts/freescale/imx93-tqma9352-mba93xxla-mini.dts b/arch/arm64/boot/dts/freescale/imx93-tqma9352-mba93xxla-mini.dts
> > new file mode 100644
> > index 0000000000000..97693aa5e904d
> > --- /dev/null
> > +++ b/arch/arm64/boot/dts/freescale/imx93-tqma9352-mba93xxla-mini.dts
> > @@ -0,0 +1,637 @@
> > +// SPDX-License-Identifier: (GPL-2.0-or-later OR MIT)
> > +/*
> > + * Copyright (c) 2025-2026 TQ-Systems GmbH <linux@ew.tq-group.com>,
> > + * D-82229 Seefeld, Germany.
> > + * Author: Martin Schmiedel
> > + */
> > +/dts-v1/;
> > +
> > +#include <dt-bindings/input/input.h>
> > +#include <dt-bindings/leds/common.h>
> > +#include <dt-bindings/net/ti-dp83867.h>
> > +#include <dt-bindings/pwm/pwm.h>
> > +#include <dt-bindings/usb/pd.h>
> > +#include "imx93-tqma9352.dtsi"
> > +
> > +/{
> > + model = "TQ-Systems i.MX93 TQMa93xxLA on MBa93xxLA-MINI SBC";
> > + compatible = "tq,imx93-tqma9352-mba93xxla-mini",
> > + "tq,imx93-tqma9352", "fsl,imx93";
> > + chassis-type = "embedded";
> > +
> > + chosen {
> > + stdout-path = &lpuart1;
> > + };
> > +
> > + aliases {
> > + eeprom0 = &eeprom0;
> > + ethernet0 = &eqos;
> > + ethernet1 = &fec;
> > + gpio0 = &gpio1;
> > + gpio1 = &gpio2;
> > + gpio2 = &gpio3;
> > + gpio3 = &gpio4;
> > + i2c0 = &lpi2c1;
> > + i2c1 = &lpi2c2;
> > + i2c2 = &lpi2c3;
> > + i2c3 = &lpi2c4;
> > + i2c4 = &lpi2c5;
> > + mmc0 = &usdhc1;
> > + mmc1 = &usdhc2;
> > + mmc2 = &usdhc3;
> > + rtc0 = &pcf85063;
> > + rtc1 = &bbnsm_rtc;
> > + serial0 = &lpuart1;
> > + serial1 = &lpuart2;
> > + serial2 = &lpuart3;
> > + serial3 = &lpuart4;
> > + serial4 = &lpuart5;
> > + serial5 = &lpuart6;
> > + serial6 = &lpuart7;
> > + serial7 = &lpuart8;
> > + spi0 = &lpspi1;
> > + spi1 = &lpspi2;
> > + spi2 = &lpspi3;
> > + spi3 = &lpspi4;
> > + spi4 = &lpspi5;
> > + spi5 = &lpspi6;
> > + };
> > +
> > + backlight_lvds: backlight {
> > + compatible = "pwm-backlight";
> > + pwms = <&tpm5 0 5000000 0>;
> > + pinctrl-names = "default";
> > + pinctrl-0 = <&pinctrl_backlight>;
> > + brightness-levels = <0 4 8 16 32 64 128 255>;
> > + default-brightness-level = <7>;
> > + power-supply = <&reg_12v0>;
> > + enable-gpios = <&gpio2 5 GPIO_ACTIVE_HIGH>;
> > + status = "disabled";
>
> Why do you add disabled nodes? If the display is not on the board, then
> the node should not be here.
>
> There is no user of that in patch 3/3, either.

Well, LVDS (via LDB) on i.MX93 is not yet in mainline, patches are pending.
So there is no user yet. But the wiring for the backlight and panel is fixed
already on the mainboard, e.g. LVDS channels, PWM channels, GPIOs etc.

So this node will be enabled on a later display overlay. Right now
everything is setup already.

Thanks and best regards,
Alexander
--
TQ-Systems GmbH | Mühlstraße 2, Gut Delling | 82229 Seefeld, Germany
Amtsgericht München, HRB 105018
Geschäftsführer: Detlef Schneider, Rüdiger Stahl, Stefan Schneider