Linux kernel and device drivers for NXP i.MX platforms
 help / color / mirror / Atom feed
From: Vinod Koul <vkoul@kernel.org>
To: Peng Ma <peng.ma@nxp.com>, Jiaheng Fan <jiaheng.fan@nxp.com>,
	 Wen He <wen.he_1@nxp.com>,
	dmaengine@vger.kernel.org,  linux-kernel@vger.kernel.org,
	Frank Li <Frank.Li@nxp.com>
Cc: imx@lists.linux.dev
Subject: Re: [PATCH 1/1] dmaengine: fsl-qdma: init irq after reg initialization
Date: Wed, 07 Feb 2024 09:49:19 +0100	[thread overview]
Message-ID: <170729575955.88665.8594869298127799288.b4-ty@kernel.org> (raw)
In-Reply-To: <20240201220406.440145-1-Frank.Li@nxp.com>


On Thu, 01 Feb 2024 17:04:06 -0500, Frank Li wrote:
> Initialize the qDMA irqs after the registers are configured so that
> interrupts that may have been pending from a primary kernel don't get
> processed by the irq handler before it is ready to and cause panic with
> the following trace:
> 
>   Call trace:
>    fsl_qdma_queue_handler+0xf8/0x3e8
>    __handle_irq_event_percpu+0x78/0x2b0
>    handle_irq_event_percpu+0x1c/0x68
>    handle_irq_event+0x44/0x78
>    handle_fasteoi_irq+0xc8/0x178
>    generic_handle_irq+0x24/0x38
>    __handle_domain_irq+0x90/0x100
>    gic_handle_irq+0x5c/0xb8
>    el1_irq+0xb8/0x180
>    _raw_spin_unlock_irqrestore+0x14/0x40
>    __setup_irq+0x4bc/0x798
>    request_threaded_irq+0xd8/0x190
>    devm_request_threaded_irq+0x74/0xe8
>    fsl_qdma_probe+0x4d4/0xca8
>    platform_drv_probe+0x50/0xa0
>    really_probe+0xe0/0x3f8
>    driver_probe_device+0x64/0x130
>    device_driver_attach+0x6c/0x78
>    __driver_attach+0xbc/0x158
>    bus_for_each_dev+0x5c/0x98
>    driver_attach+0x20/0x28
>    bus_add_driver+0x158/0x220
>    driver_register+0x60/0x110
>    __platform_driver_register+0x44/0x50
>    fsl_qdma_driver_init+0x18/0x20
>    do_one_initcall+0x48/0x258
>    kernel_init_freeable+0x1a4/0x23c
>    kernel_init+0x10/0xf8
>    ret_from_fork+0x10/0x18
> 
> [...]

Applied, thanks!

[1/1] dmaengine: fsl-qdma: init irq after reg initialization
      commit: 87a39071e0b639f45e05d296cc0538eef44ec0bd

Best regards,
-- 
~Vinod



      reply	other threads:[~2024-02-07  8:49 UTC|newest]

Thread overview: 2+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2024-02-01 22:04 [PATCH 1/1] dmaengine: fsl-qdma: init irq after reg initialization Frank Li
2024-02-07  8:49 ` Vinod Koul [this message]

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=170729575955.88665.8594869298127799288.b4-ty@kernel.org \
    --to=vkoul@kernel.org \
    --cc=Frank.Li@nxp.com \
    --cc=dmaengine@vger.kernel.org \
    --cc=imx@lists.linux.dev \
    --cc=jiaheng.fan@nxp.com \
    --cc=linux-kernel@vger.kernel.org \
    --cc=peng.ma@nxp.com \
    --cc=wen.he_1@nxp.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox