From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from perceval.ideasonboard.com (perceval.ideasonboard.com [213.167.242.64]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id F020E60EF9 for ; Mon, 15 Apr 2024 15:08:18 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=213.167.242.64 ARC-Seal:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1713193701; cv=none; b=i8jDkkKxmX3TXYREWBrH+uXSr6qP99vFRGELmyhcZsEzeI1loOxe//FRXGnFmjtuuF+MlRXlGo+WUl8J2pLeS4uB1garjjqYYp8E+r6j+wkCfi2wfyyALVbgh1KS2yEBW7Dz4TW9OnKHMqb5XCa0Peq8FIbNQFsOBElGo1eiXyE= ARC-Message-Signature:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1713193701; c=relaxed/simple; bh=hWHk3OAeDSHeXmmwsMo6Ie1UzYURq55JZzQuZwoHz+s=; h=Content-Type:MIME-Version:In-Reply-To:References:Subject:From:Cc: To:Date:Message-ID; b=NtoTBFtqKCiL/pTtS6y+pJc90cIhLbiynFgxMroLqJwX2f6uh/eoJf0IYxhguf6th5E4iaXlEaMcHyTphRjtOZfvG4kmLwTXrTxaZOPsRO4quQR4t0AdoaVYUtHBHVTjEBxGqdmWeS0jtI1MTB9Y+dM0Bolv5fDFFNegT1K/Ygg= ARC-Authentication-Results:i=1; smtp.subspace.kernel.org; dmarc=none (p=none dis=none) header.from=ideasonboard.com; spf=pass smtp.mailfrom=ideasonboard.com; dkim=pass (1024-bit key) header.d=ideasonboard.com header.i=@ideasonboard.com header.b=JufAHYJR; arc=none smtp.client-ip=213.167.242.64 Authentication-Results: smtp.subspace.kernel.org; dmarc=none (p=none dis=none) header.from=ideasonboard.com Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=ideasonboard.com Authentication-Results: smtp.subspace.kernel.org; dkim=pass (1024-bit key) header.d=ideasonboard.com header.i=@ideasonboard.com header.b="JufAHYJR" Received: from pendragon.ideasonboard.com (cpc89244-aztw30-2-0-cust6594.18-1.cable.virginm.net [86.31.185.195]) by perceval.ideasonboard.com (Postfix) with ESMTPSA id EC61B236; Mon, 15 Apr 2024 17:07:27 +0200 (CEST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=ideasonboard.com; s=mail; t=1713193648; bh=hWHk3OAeDSHeXmmwsMo6Ie1UzYURq55JZzQuZwoHz+s=; h=In-Reply-To:References:Subject:From:Cc:To:Date:From; b=JufAHYJRV5XwyCZiGltge2oCI08BK+ysqi+YSMdQnzRgNLHulH5BbqXcuni2QkdnR PrSf7TFQaGxzbY4p8yPYQDdD++K83lG6IkfxZ1Rppnz+ResPyrf2vrvxYZE7oOwjOo gJa5u1GSWEpAvoWHJp04t2AxpcQ+GNe9UKG/bJCU= Content-Type: text/plain; charset="utf-8" Precedence: bulk X-Mailing-List: imx@lists.linux.dev List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 Content-Transfer-Encoding: quoted-printable In-Reply-To: <20240415114135.25473-2-chris.obbard@collabora.com> References: <20240415114135.25473-1-chris.obbard@collabora.com> <20240415114135.25473-2-chris.obbard@collabora.com> Subject: Re: [PATCH v1 1/1] arm64: dts: imx8mp-debix-model-a: Add HDMI output support From: Kieran Bingham Cc: Daniel Scally , Laurent Pinchart , kernel@collabora.com, Christopher Obbard , Conor Dooley , Fabio Estevam , Krzysztof Kozlowski , Pengutronix Kernel Team , Rob Herring , Sascha Hauer , Shawn Guo , devicetree@vger.kernel.org, imx@lists.linux.dev, linux-arm-kernel@lists.infradead.org To: Christopher Obbard , linux-kernel@vger.kernel.org Date: Mon, 15 Apr 2024 16:08:10 +0100 Message-ID: <171319369093.2333277.9109576229211275635@ping.linuxembedded.co.uk> User-Agent: alot/0.10 Hi Chris, Quoting Christopher Obbard (2024-04-15 12:41:27) > Enable the HDMI output on the Debix Model A SBC, using the HDMI encoder > present in the i.MX8MP SoC. Aha, you beat me to it. I have a commit locally (Dated 2022-09-06) but not sent because I didn't realise the HDMI support finally got upstream \o/ > Signed-off-by: Christopher Obbard > --- >=20 > .../dts/freescale/imx8mp-debix-model-a.dts | 47 +++++++++++++++++++ > 1 file changed, 47 insertions(+) >=20 > diff --git a/arch/arm64/boot/dts/freescale/imx8mp-debix-model-a.dts b/arc= h/arm64/boot/dts/freescale/imx8mp-debix-model-a.dts > index 2c19766ebf09..29529c2ecac9 100644 > --- a/arch/arm64/boot/dts/freescale/imx8mp-debix-model-a.dts > +++ b/arch/arm64/boot/dts/freescale/imx8mp-debix-model-a.dts > @@ -20,6 +20,18 @@ chosen { > stdout-path =3D &uart2; > }; > =20 > + hdmi-connector { > + compatible =3D "hdmi-connector"; > + label =3D "hdmi"; > + type =3D "a"; > + > + port { > + hdmi_connector_in: endpoint { > + remote-endpoint =3D <&hdmi_tx_out>; > + }; > + }; > + }; > + Interesting. My patch missed this. But it looks correct. > leds { > compatible =3D "gpio-leds"; > pinctrl-names =3D "default"; > @@ -94,6 +106,28 @@ ethphy0: ethernet-phy@0 { /* RTL8211E */ > }; > }; > =20 > +&hdmi_pvi { > + status =3D "okay"; > +}; > + > +&hdmi_tx { > + pinctrl-names =3D "default"; > + pinctrl-0 =3D <&pinctrl_hdmi>; > + status =3D "okay"; > + > + ports { > + port@1 { > + hdmi_tx_out: endpoint { > + remote-endpoint =3D <&hdmi_connector_in>; > + }; > + }; > + }; > +}; > + > +&hdmi_tx_phy { > + status =3D "okay"; > +}; > + > &i2c1 { > clock-frequency =3D <400000>; > pinctrl-names =3D "default"; > @@ -241,6 +275,10 @@ &i2c6 { > status =3D "okay"; > }; > =20 > +&lcdif3 { > + status =3D "okay"; > +}; > + Except for the addition of the connector, the above matches my patch to here. > &snvs_pwrkey { > status =3D "okay"; > }; But in my patch I have the following hunk here: (I haven't checked to see if this still applies on mainline, so take with a pinch of salt if it's not there!) &iomuxc { pinctrl-names =3D "default"; - pinctrl-0 =3D <&pinctrl_hog>; - - pinctrl_hog: hoggrp { - fsl,pins =3D < - MX8MP_IOMUXC_HDMI_DDC_SCL__HDMIMIX_HDMI_SCL 0x400001c3 - MX8MP_IOMUXC_HDMI_DDC_SDA__HDMIMIX_HDMI_SDA 0x400001c3 - MX8MP_IOMUXC_HDMI_HPD__HDMIMIX_HDMI_HPD 0x40000019 - MX8MP_IOMUXC_HDMI_CEC__HDMIMIX_HDMI_CEC 0x40000019 - >; - }; pinctrl_eqos: eqosgrp { fsl,pins =3D < MX8MP_IOMUXC_ENET_MDC__ENET_QOS_MDC 0x3 MX8MP_IOMUXC_ENET_MDIO__ENET_QOS_MDIO 0x3 > @@ -358,6 +396,15 @@ MX8MP_IOMUXC_NAND_READY_B__GPIO3_IO16 = 0x19 > >; > }; > =20 > + pinctrl_hdmi: hdmigrp { > + fsl,pins =3D < > + MX8MP_IOMUXC_HDMI_DDC_SCL__HDMIMIX_HDMI_SCL = 0x400001c3 > + MX8MP_IOMUXC_HDMI_DDC_SDA__HDMIMIX_HDMI_SDA = 0x400001c3 > + MX8MP_IOMUXC_HDMI_HPD__HDMIMIX_HDMI_HPD = 0x40000019 > + MX8MP_IOMUXC_HDMI_CEC__HDMIMIX_HDMI_CEC = 0x40000019 > + >; > + }; > + And my addition here is : + pinctrl_hdmi: hdmigrp { + fsl,pins =3D < + MX8MP_IOMUXC_HDMI_DDC_SCL__HDMIMIX_HDMI_SCL 0x1c3 + MX8MP_IOMUXC_HDMI_DDC_SDA__HDMIMIX_HDMI_SDA 0x1c3 + MX8MP_IOMUXC_HDMI_HPD__HDMIMIX_HDMI_HPD 0x19 + MX8MP_IOMUXC_HDMI_CEC__HDMIMIX_HDMI_CEC 0x19 + >; + }; + I haven't looked into what the 0x40000000 does yet, but just highlighting the difference from the version I've been using to make use of HDMI so far. Does anyone else know the impact here? Otherwise I'll try to find time to check this later. (For some undefined term of later...) -- Kieran > pinctrl_i2c1: i2c1grp { > fsl,pins =3D < > MX8MP_IOMUXC_I2C1_SCL__I2C1_SCL = 0x400001c2 > --=20 > 2.43.0 >