From: ALOK TIWARI <alok.a.tiwari@oracle.com>
To: Haibo Chen <haibo.chen@nxp.com>, Han Xu <han.xu@nxp.com>,
Yogesh Gaur <yogeshgaur.83@gmail.com>,
Mark Brown <broonie@kernel.org>
Cc: linux-spi@vger.kernel.org, imx@lists.linux.dev,
linux-kernel@vger.kernel.org
Subject: Re: [PATCH v3 2/5] spi: spi-nxp-fspi: enable runtime pm for fspi
Date: Thu, 1 May 2025 01:00:30 +0530 [thread overview]
Message-ID: <17183bc3-0f15-4789-89b8-b4bfbdac5872@oracle.com> (raw)
In-Reply-To: <20250428-flexspipatch-v3-2-61d5e8f591bc@nxp.com>
On 28-04-2025 15:36, Haibo Chen wrote:
> @@ -1249,29 +1272,70 @@ static void nxp_fspi_remove(struct platform_device *pdev)
> {
> struct nxp_fspi *f = platform_get_drvdata(pdev);
>
> + /* enable clock first since there is reigster access */
typo reigster -> register
> + pm_runtime_get_sync(f->dev);
> +
> /* disable the hardware */
> fspi_writel(f, FSPI_MCR0_MDIS, f->iobase + FSPI_MCR0);
Thanks,
Alok
next prev parent reply other threads:[~2025-04-30 19:30 UTC|newest]
Thread overview: 10+ messages / expand[flat|nested] mbox.gz Atom feed top
2025-04-28 10:06 [PATCH v3 0/5] This patch set did some clean up and add runtime pm support for flexspi driver Haibo Chen
2025-04-28 10:06 ` [PATCH v3 1/5] spi: spi-nxp-fspi: remove the goto in probe Haibo Chen
2025-04-28 10:06 ` [PATCH v3 2/5] spi: spi-nxp-fspi: enable runtime pm for fspi Haibo Chen
2025-04-30 19:30 ` ALOK TIWARI [this message]
2025-05-01 20:47 ` Mark Brown
2025-05-06 6:19 ` Bough Chen
2025-04-28 10:06 ` [PATCH v3 3/5] spi: spi-nxp-fspi: use guard(mutex) to simplify the code Haibo Chen
2025-04-28 10:06 ` [PATCH v3 4/5] spi: spi-nxp-fspi: remove the unchecked return value for nxp_fspi_clk_disable_unprep Haibo Chen
2025-04-28 10:06 ` [PATCH v3 5/5] spi: nxp-fspi: use devm instead of remove for driver detach Haibo Chen
2025-05-07 2:57 ` [PATCH v3 0/5] This patch set did some clean up and add runtime pm support for flexspi driver Mark Brown
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=17183bc3-0f15-4789-89b8-b4bfbdac5872@oracle.com \
--to=alok.a.tiwari@oracle.com \
--cc=broonie@kernel.org \
--cc=haibo.chen@nxp.com \
--cc=han.xu@nxp.com \
--cc=imx@lists.linux.dev \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-spi@vger.kernel.org \
--cc=yogeshgaur.83@gmail.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox