From: "Rob Herring (Arm)" <robh@kernel.org>
To: Wei Fang <wei.fang@nxp.com>
Cc: andrew@lunn.ch, devicetree@vger.kernel.org, davem@davemloft.net,
conor+dt@kernel.org, netdev@vger.kernel.org,
linux-kernel@vger.kernel.org, imx@lists.linux.dev,
pabeni@redhat.com, hkallweit1@gmail.com, f.fainelli@gmail.com,
krzk+dt@kernel.org
Subject: Re: [PATCH v2 net] dt-bindings: net: tja11xx: fix the broken binding
Date: Mon, 9 Sep 2024 11:04:00 -0500 [thread overview]
Message-ID: <172589770898.219234.12343458471539869016.robh@kernel.org> (raw)
In-Reply-To: <20240909012152.431647-1-wei.fang@nxp.com>
On Mon, 09 Sep 2024 09:21:52 +0800, Wei Fang wrote:
> As Rob pointed in another mail thread [1], the binding of tja11xx PHY
> is completely broken, the schema cannot catch the error in the DTS. A
> compatiable string must be needed if we want to add a custom propety.
> So extract known PHY IDs from the tja11xx PHY drivers and convert them
> into supported compatible string list to fix the broken binding issue.
>
> [1]: https://lore.kernel.org/netdev/31058f49-bac5-49a9-a422-c43b121bf049@kernel.org/T/
>
> Fixes: 52b2fe4535ad ("dt-bindings: net: tja11xx: add nxp,refclk_in property")
> Signed-off-by: Wei Fang <wei.fang@nxp.com>
> ---
> V2 changes:
> 1. Add more compatible strings based on TJA11xx data sheets.
> V1 link: https://lore.kernel.org/imx/20240904145720.GA2552590-robh@kernel.org/T/
> ---
> .../devicetree/bindings/net/nxp,tja11xx.yaml | 62 ++++++++++++++-----
> 1 file changed, 46 insertions(+), 16 deletions(-)
>
Reviewed-by: Rob Herring (Arm) <robh@kernel.org>
next prev parent reply other threads:[~2024-09-09 16:04 UTC|newest]
Thread overview: 3+ messages / expand[flat|nested] mbox.gz Atom feed top
2024-09-09 1:21 [PATCH v2 net] dt-bindings: net: tja11xx: fix the broken binding Wei Fang
2024-09-09 16:04 ` Rob Herring (Arm) [this message]
2024-09-11 0:31 ` patchwork-bot+netdevbpf
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=172589770898.219234.12343458471539869016.robh@kernel.org \
--to=robh@kernel.org \
--cc=andrew@lunn.ch \
--cc=conor+dt@kernel.org \
--cc=davem@davemloft.net \
--cc=devicetree@vger.kernel.org \
--cc=f.fainelli@gmail.com \
--cc=hkallweit1@gmail.com \
--cc=imx@lists.linux.dev \
--cc=krzk+dt@kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=netdev@vger.kernel.org \
--cc=pabeni@redhat.com \
--cc=wei.fang@nxp.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox