Linux kernel and device drivers for NXP i.MX platforms
 help / color / mirror / Atom feed
From: "Rob Herring (Arm)" <robh@kernel.org>
To: Laurentiu Mihalcea <laurentiumihalcea111@gmail.com>
Cc: Conor Dooley <conor+dt@kernel.org>,
	 Krzysztof Kozlowski <krzk+dt@kernel.org>,
	 Daniel Baluta <daniel.baluta@nxp.com>,
	 Shengjiu Wang <shengjiu.wang@nxp.com>,
	 Iuliana Prodan <iuliana.prodan@nxp.com>,
	linux-kernel@vger.kernel.org,
	 Sascha Hauer <s.hauer@pengutronix.de>,
	linux-arm-kernel@lists.infradead.org,  imx@lists.linux.dev,
	Shawn Guo <shawnguo@kernel.org>,
	 devicetree@vger.kernel.org
Subject: Re: [PATCH 1/5] dt-bindings: dsp: fix power domain count
Date: Wed, 18 Sep 2024 14:36:53 -0500	[thread overview]
Message-ID: <172668821340.2009095.10209806970812964896.robh@kernel.org> (raw)
In-Reply-To: <20240918182117.86221-2-laurentiumihalcea111@gmail.com>


On Wed, 18 Sep 2024 14:21:13 -0400, Laurentiu Mihalcea wrote:
> From: Laurentiu Mihalcea <laurentiu.mihalcea@nxp.com>
> 
> Per the current binding, QM/QXP DSPs are supposed
> to have 4 power domains, while the rest just 1.
> For QM/QXP, the 4 power domains are: DSP, DSP_RAM,
> MU13A, MU13B.
> 
> First off, drop MU13A from the count. This is attached
> to the platform device of lsio_mu13. This decreases the
> count to 3.
> 
> Secondly, drop DSP and DSP_RAM from the count for QXP.
> These are attached to the platform devices of the lpcgs
> (used as clock providers for the DSP).
> 
> With this in mind, the number of required power domains for
> QXP is 1 (MU13B), while for QM it's 3 (MU13B, DSP, DSP_RAM).
> 
> Additionally, two extra power domains may be required in the
> case of QM/QXP DSPs. These are IRQSTR_DSP and MU2A. For the nodes
> using the "-hifi4" compatibles these PDs are optional, while for
> nodes using the "-dsp" compatibles these are mandatory.
> 
> These changes reflect all of this information.
> 
> Signed-off-by: Laurentiu Mihalcea <laurentiu.mihalcea@nxp.com>
> ---
>  .../devicetree/bindings/dsp/fsl,dsp.yaml      | 62 +++++++++++++++----
>  1 file changed, 49 insertions(+), 13 deletions(-)
> 

My bot found errors running 'make dt_binding_check' on your patch:

yamllint warnings/errors:

dtschema/dtc warnings/errors:
/builds/robherring/dt-review-ci/linux/Documentation/devicetree/bindings/mailbox/arm,mhuv2.example.dtb: dsp@596e8000: power-domains: [[4294967295, 0], [4294967295, 1], [4294967295, 2], [4294967295, 3]] is too long
	from schema $id: http://devicetree.org/schemas/dsp/fsl,dsp.yaml#

doc reference errors (make refcheckdocs):

See https://patchwork.ozlabs.org/project/devicetree-bindings/patch/20240918182117.86221-2-laurentiumihalcea111@gmail.com

The base for the series is generally the latest rc1. A different dependency
should be noted in *this* patch.

If you already ran 'make dt_binding_check' and didn't see the above
error(s), then make sure 'yamllint' is installed and dt-schema is up to
date:

pip3 install dtschema --upgrade

Please check and re-submit after running the above command yourself. Note
that DT_SCHEMA_FILES can be set to your schema file to speed up checking
your schema. However, it must be unset to test all examples with your schema.


  parent reply	other threads:[~2024-09-18 19:36 UTC|newest]

Thread overview: 17+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2024-09-18 18:21 [PATCH 0/5] configure imx8 dsp DT node for rproc usage Laurentiu Mihalcea
2024-09-18 18:21 ` [PATCH 1/5] dt-bindings: dsp: fix power domain count Laurentiu Mihalcea
2024-09-18 18:49   ` Frank Li
2024-09-22 23:03     ` Laurentiu Mihalcea
2024-09-18 19:36   ` Rob Herring (Arm) [this message]
2024-09-18 20:37   ` Rob Herring
2024-09-18 18:21 ` [PATCH 2/5] arm64: dts: imx8qxp: configure dsp node for rproc usage Laurentiu Mihalcea
2024-09-18 19:02   ` Frank Li
2024-09-24 11:01     ` Daniel Baluta
2024-09-18 18:21 ` [PATCH 3/5] arm64: dts: imx8qm: drop dsp node from audio_subsys bus Laurentiu Mihalcea
2024-09-18 18:54   ` Frank Li
2024-09-18 18:21 ` [PATCH 4/5] arm64: dts: imx8qm: add node for VPU dsp Laurentiu Mihalcea
2024-09-18 18:57   ` Frank Li
2024-09-22 23:19     ` Laurentiu Mihalcea
2024-09-18 18:21 ` [PATCH 5/5] arm64: dts: imx8qm: enable dsp node for rproc usage Laurentiu Mihalcea
2024-09-18 19:00   ` Frank Li
2024-09-22 23:15     ` Laurentiu Mihalcea

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=172668821340.2009095.10209806970812964896.robh@kernel.org \
    --to=robh@kernel.org \
    --cc=conor+dt@kernel.org \
    --cc=daniel.baluta@nxp.com \
    --cc=devicetree@vger.kernel.org \
    --cc=imx@lists.linux.dev \
    --cc=iuliana.prodan@nxp.com \
    --cc=krzk+dt@kernel.org \
    --cc=laurentiumihalcea111@gmail.com \
    --cc=linux-arm-kernel@lists.infradead.org \
    --cc=linux-kernel@vger.kernel.org \
    --cc=s.hauer@pengutronix.de \
    --cc=shawnguo@kernel.org \
    --cc=shengjiu.wang@nxp.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox