From: "Rob Herring (Arm)" <robh@kernel.org>
To: carlos.song@nxp.com
Cc: krzk+dt@kernel.org, s.hauer@pengutronix.de, festevam@gmail.com,
linux-kernel@vger.kernel.org, Frank.Li@nxp.com,
alexandre.belloni@bootlin.com, linux-i3c@lists.infradead.org,
miquel.raynal@bootlin.com, devicetree@vger.kernel.org,
conor.culhane@silvaco.com, linux-arm-kernel@lists.infradead.org,
shawnguo@kernel.org, kernel@pengutronix.de, imx@lists.linux.dev,
conor+dt@kernel.org
Subject: Re: [PATCH 1/3] dt-bindings: i3c: silvaco,i3c-master: add i.MX94 and i.MX95 I3C
Date: Mon, 21 Apr 2025 02:29:16 -0500 [thread overview]
Message-ID: <174522055654.901015.12807309511179699830.robh@kernel.org> (raw)
In-Reply-To: <20250421061544.2471379-2-carlos.song@nxp.com>
On Mon, 21 Apr 2025 14:15:42 +0800, carlos.song@nxp.com wrote:
> From: Carlos Song <carlos.song@nxp.com>
>
> Add compatible string "nxp,imx94-i3c" and "nxp,imx95-i3c" for the i.MX94
> chip and i.MX95 chip. Backward is compatible with "silvaco,i3c-master-v1".
>
> Also i.MX94 and i.MX95 I3C only need two clocks and Legacy I3C needs
> three clocks. So add restrictions for clock and clock-names properties
> for different Socs.
>
> Signed-off-by: Carlos Song <carlos.song@nxp.com>
> ---
> .../bindings/i3c/silvaco,i3c-master.yaml | 45 ++++++++++++++++---
> 1 file changed, 39 insertions(+), 6 deletions(-)
>
My bot found errors running 'make dt_binding_check' on your patch:
yamllint warnings/errors:
./Documentation/devicetree/bindings/i3c/silvaco,i3c-master.yaml:16:9: [warning] wrong indentation: expected 10 but found 8 (indentation)
./Documentation/devicetree/bindings/i3c/silvaco,i3c-master.yaml:19:9: [warning] wrong indentation: expected 10 but found 8 (indentation)
dtschema/dtc warnings/errors:
doc reference errors (make refcheckdocs):
See https://patchwork.ozlabs.org/project/devicetree-bindings/patch/20250421061544.2471379-2-carlos.song@nxp.com
The base for the series is generally the latest rc1. A different dependency
should be noted in *this* patch.
If you already ran 'make dt_binding_check' and didn't see the above
error(s), then make sure 'yamllint' is installed and dt-schema is up to
date:
pip3 install dtschema --upgrade
Please check and re-submit after running the above command yourself. Note
that DT_SCHEMA_FILES can be set to your schema file to speed up checking
your schema. However, it must be unset to test all examples with your schema.
next prev parent reply other threads:[~2025-04-21 7:29 UTC|newest]
Thread overview: 8+ messages / expand[flat|nested] mbox.gz Atom feed top
2025-04-21 6:15 [PATCH 0/3] support different numbers of clocks for svc i3c controller carlos.song
2025-04-21 6:15 ` [PATCH 1/3] dt-bindings: i3c: silvaco,i3c-master: add i.MX94 and i.MX95 I3C carlos.song
2025-04-21 7:22 ` Alexandre Belloni
2025-04-21 10:38 ` Carlos Song
2025-04-21 7:29 ` Rob Herring (Arm) [this message]
2025-04-21 6:15 ` [PATCH 2/3] i3c: master: svc: switch to bulk clk API for flexible clock support carlos.song
2025-04-21 8:20 ` kernel test robot
2025-04-21 6:15 ` [PATCH 3/3] arm64: dts: imx95: correct i3c node in imx95 carlos.song
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=174522055654.901015.12807309511179699830.robh@kernel.org \
--to=robh@kernel.org \
--cc=Frank.Li@nxp.com \
--cc=alexandre.belloni@bootlin.com \
--cc=carlos.song@nxp.com \
--cc=conor+dt@kernel.org \
--cc=conor.culhane@silvaco.com \
--cc=devicetree@vger.kernel.org \
--cc=festevam@gmail.com \
--cc=imx@lists.linux.dev \
--cc=kernel@pengutronix.de \
--cc=krzk+dt@kernel.org \
--cc=linux-arm-kernel@lists.infradead.org \
--cc=linux-i3c@lists.infradead.org \
--cc=linux-kernel@vger.kernel.org \
--cc=miquel.raynal@bootlin.com \
--cc=s.hauer@pengutronix.de \
--cc=shawnguo@kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox