From: "Rob Herring (Arm)" <robh@kernel.org>
To: Wei Fang <wei.fang@nxp.com>
Cc: krzk+dt@kernel.org, davem@davemloft.net,
richardcochran@gmail.com, Frank.Li@nxp.com,
vladimir.oltean@nxp.com, andrew+netdev@lunn.ch, kuba@kernel.org,
linux-kernel@vger.kernel.org, devicetree@vger.kernel.org,
imx@lists.linux.dev, claudiu.manoil@nxp.com, pabeni@redhat.com,
edumazet@google.com, xiaoning.wang@nxp.com,
netdev@vger.kernel.org, conor+dt@kernel.org
Subject: Re: [PATCH net-next 0/8] net: enetc: Add i.MX94 ENETC support
Date: Thu, 16 Oct 2025 07:11:51 -0500 [thread overview]
Message-ID: <176061621269.2563112.3282967985432898709.robh@kernel.org> (raw)
In-Reply-To: <20251016102020.3218579-1-wei.fang@nxp.com>
On Thu, 16 Oct 2025 18:20:11 +0800, Wei Fang wrote:
> i.MX94 NETC has two kinds of ENETCs, one is the same as i.MX95, which
> can be used as a standalone network port. The other one is an internal
> ENETC, it connects to the CPU port of NETC switch through the pseudo
> MAC. Also, i.MX94 have multiple PTP Timers, which is different from
> i.MX95. Any PTP Timer can be bound to a specified standalone ENETC by
> the IERB ETBCR registers. Currently, this patch only add ENETC support
> and Timer support for i.MX94. The switch will be added by a separate
> patch set.
>
> ---
> Note that the DTS patch (patch 8/8) is just for referenece, it will be
> removed from this patch set when the dt-bindings patches have been
> reviewed. It will be sent for review by another thread in the future.
> ---
>
> Clark Wang (1):
> net: enetc: add ptp timer binding support for i.MX94
>
> Wei Fang (7):
> dt-bindings: net: netc-blk-ctrl: add compatible string for i.MX94
> platforms
> dt-bindings: net: enetc: add compatible string for ENETC with pseduo
> MAC
> dt-bindings: net: ethernet-controller: remove the enum values of speed
> net: enetc: add preliminary i.MX94 NETC blocks control support
> net: enetc: add basic support for the ENETC with pseudo MAC for i.MX94
> net: enetc: add standalone ENETC support for i.MX94
> arm64: dts: imx94: add basic NETC nodes and properties
>
> .../bindings/net/ethernet-controller.yaml | 1 -
> .../devicetree/bindings/net/fsl,enetc.yaml | 1 +
> .../bindings/net/nxp,netc-blk-ctrl.yaml | 1 +
> arch/arm64/boot/dts/freescale/imx94.dtsi | 118 ++++++++++
> arch/arm64/boot/dts/freescale/imx943-evk.dts | 100 +++++++++
> drivers/net/ethernet/freescale/enetc/enetc.c | 28 ++-
> drivers/net/ethernet/freescale/enetc/enetc.h | 8 +
> .../net/ethernet/freescale/enetc/enetc4_hw.h | 32 ++-
> .../net/ethernet/freescale/enetc/enetc4_pf.c | 37 ++--
> .../ethernet/freescale/enetc/enetc_ethtool.c | 64 ++++++
> .../net/ethernet/freescale/enetc/enetc_hw.h | 1 +
> .../freescale/enetc/enetc_pf_common.c | 5 +-
> .../ethernet/freescale/enetc/netc_blk_ctrl.c | 202 ++++++++++++++++++
> 13 files changed, 574 insertions(+), 24 deletions(-)
>
> --
> 2.34.1
>
>
>
My bot found new DTB warnings on the .dts files added or changed in this
series.
Some warnings may be from an existing SoC .dtsi. Or perhaps the warnings
are fixed by another series. Ultimately, it is up to the platform
maintainer whether these warnings are acceptable or not. No need to reply
unless the platform maintainer has comments.
If you already ran DT checks and didn't see these error(s), then
make sure dt-schema is up to date:
pip3 install dtschema --upgrade
This patch series was applied (using b4) to base:
Base: attempting to guess base-commit...
Base: tags/next-20251015 (exact match)
Base: tags/next-20251015 (use --merge-base to override)
If this is not the correct base, please add 'base-commit' tag
(or use b4 which does this automatically)
New warnings running 'make CHECK_DTBS=y for arch/arm64/boot/dts/freescale/' for 20251016102020.3218579-1-wei.fang@nxp.com:
arch/arm64/boot/dts/freescale/imx943-evk.dtb: system-controller@4ceb0000 (nxp,imx94-netc-blk-ctrl): 'anyOf' conditional failed, one must be fixed:
'clocks' is a required property
'#clock-cells' is a required property
from schema $id: http://devicetree.org/schemas/clock/clock.yaml#
next prev parent reply other threads:[~2025-10-16 12:11 UTC|newest]
Thread overview: 18+ messages / expand[flat|nested] mbox.gz Atom feed top
2025-10-16 10:20 [PATCH net-next 0/8] net: enetc: Add i.MX94 ENETC support Wei Fang
2025-10-16 10:20 ` [PATCH net-next 1/8] dt-bindings: net: netc-blk-ctrl: add compatible string for i.MX94 platforms Wei Fang
2025-10-21 20:38 ` Rob Herring (Arm)
2025-10-16 10:20 ` [PATCH net-next 2/8] dt-bindings: net: enetc: add compatible string for ENETC with pseduo MAC Wei Fang
2025-10-21 20:38 ` Rob Herring (Arm)
2025-10-16 10:20 ` [PATCH net-next 3/8] dt-bindings: net: ethernet-controller: remove the enum values of speed Wei Fang
2025-10-21 20:50 ` Rob Herring
2025-10-22 1:51 ` Wei Fang
2025-10-16 10:20 ` [PATCH net-next 4/8] net: enetc: add preliminary i.MX94 NETC blocks control support Wei Fang
2025-10-16 10:20 ` [PATCH net-next 5/8] net: enetc: add ptp timer binding support for i.MX94 Wei Fang
2025-10-21 7:21 ` Paolo Abeni
2025-10-16 10:20 ` [PATCH net-next 6/8] net: enetc: add basic support for the ENETC with pseudo MAC " Wei Fang
2025-10-21 7:26 ` Paolo Abeni
2025-10-22 1:44 ` Wei Fang
2025-10-16 10:20 ` [PATCH net-next 7/8] net: enetc: add standalone ENETC support " Wei Fang
2025-10-16 10:20 ` [PATCH 8/8] arm64: dts: imx94: add basic NETC nodes and properties Wei Fang
2025-10-16 12:11 ` Rob Herring (Arm) [this message]
2025-10-21 7:14 ` [PATCH net-next 0/8] net: enetc: Add i.MX94 ENETC support Paolo Abeni
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=176061621269.2563112.3282967985432898709.robh@kernel.org \
--to=robh@kernel.org \
--cc=Frank.Li@nxp.com \
--cc=andrew+netdev@lunn.ch \
--cc=claudiu.manoil@nxp.com \
--cc=conor+dt@kernel.org \
--cc=davem@davemloft.net \
--cc=devicetree@vger.kernel.org \
--cc=edumazet@google.com \
--cc=imx@lists.linux.dev \
--cc=krzk+dt@kernel.org \
--cc=kuba@kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=netdev@vger.kernel.org \
--cc=pabeni@redhat.com \
--cc=richardcochran@gmail.com \
--cc=vladimir.oltean@nxp.com \
--cc=wei.fang@nxp.com \
--cc=xiaoning.wang@nxp.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox