From: Mark Brown <broonie@kernel.org>
To: Frank.Li@nxp.com, rongqianfeng@vivo.com, carlos.song@nxp.com
Cc: linux-spi@vger.kernel.org, imx@lists.linux.dev,
linux-kernel@vger.kernel.org
Subject: Re: [PATCH] spi: spi-fsl-lpspi: fix watermark truncation caused by type cast
Date: Fri, 21 Nov 2025 16:24:59 +0000 [thread overview]
Message-ID: <176374229925.52495.4055621963901778213.b4-ty@kernel.org> (raw)
In-Reply-To: <20251117030355.1359081-1-carlos.song@nxp.com>
On Mon, 17 Nov 2025 11:03:55 +0800, carlos.song@nxp.com wrote:
> 't->len' is an unsigned integer, while 'watermark' and 'txfifosize' are
> u8. Using min_t with typeof(watermark) forces both values to be cast to
> u8, which truncates len when it exceeds 255. For example, len = 4096
> becomes 0 after casting, resulting in an incorrect watermark value.
>
> Use a wider type in min_t to avoid truncation and ensure the correct
> minimum value is applied.
>
> [...]
Applied to
https://git.kernel.org/pub/scm/linux/kernel/git/broonie/spi.git for-next
Thanks!
[1/1] spi: spi-fsl-lpspi: fix watermark truncation caused by type cast
commit: 9f0c21bac5a8089e74b21d007e26fb4594b10d73
All being well this means that it will be integrated into the linux-next
tree (usually sometime in the next 24 hours) and sent to Linus during
the next merge window (or sooner if it is a bug fix), however if
problems are discovered then the patch may be dropped or reverted.
You may get further e-mails resulting from automated or manual testing
and review of the tree, please engage with people reporting problems and
send followup patches addressing any issues that are reported if needed.
If any updates are required or you are submitting further changes they
should be sent as incremental updates against current git, existing
patches will not be replaced.
Please add any relevant lists and maintainers to the CCs when replying
to this mail.
Thanks,
Mark
next prev parent reply other threads:[~2025-11-21 16:25 UTC|newest]
Thread overview: 13+ messages / expand[flat|nested] mbox.gz Atom feed top
2025-11-17 3:03 [PATCH] spi: spi-fsl-lpspi: fix watermark truncation caused by type cast carlos.song
2025-11-21 8:18 ` Carlos Song
2025-11-21 14:23 ` Mark Brown
2025-11-21 9:30 ` Daniel Baluta
2025-11-21 15:54 ` Frank Li
2025-11-21 16:19 ` Frank Li
2025-11-22 10:57 ` david laight
2025-11-25 15:11 ` Andy Shevchenko
2025-11-26 2:10 ` Carlos Song
2025-11-26 6:43 ` Andy Shevchenko
2025-11-26 10:02 ` Carlos Song
2025-11-21 16:24 ` Mark Brown [this message]
2025-11-22 10:48 ` david laight
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=176374229925.52495.4055621963901778213.b4-ty@kernel.org \
--to=broonie@kernel.org \
--cc=Frank.Li@nxp.com \
--cc=carlos.song@nxp.com \
--cc=imx@lists.linux.dev \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-spi@vger.kernel.org \
--cc=rongqianfeng@vivo.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox