From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from smtp.kernel.org (aws-us-west-2-korg-mail-1.web.codeaurora.org [10.30.226.201]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id 284EE1EBFE0; Sat, 14 Mar 2026 00:38:59 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=10.30.226.201 ARC-Seal:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1773448740; cv=none; b=OKs8KZZ7bujmW22K+Ch172Y8mtURimJXGxgQJHjIaBnPdIeH//FO3LY0csFVxTNbpmcjbo4tFgVVkUrIp3iU1Veik3+qS3u4WmmfRuXGLZ55rCwshm4kd+UtUkT6J/Bkt5s/UZWr0yL6Aknx3/9h9FaL0XdweIPljWuI95GJPtg= ARC-Message-Signature:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1773448740; c=relaxed/simple; bh=mkaGOENEa1gmtvrXYu8nQ+hbKTdiqqEtszypw75YmEo=; h=Date:From:To:Cc:Subject:Message-ID:References:MIME-Version: Content-Type:Content-Disposition:In-Reply-To; b=nS0kG9cVGyi1m+jM5VHL92tVmuVSPX8V+9NOopIuf6wRtfWNKzpaGxmA5cWERGjeWW9PG2EvXuboW12DjVIQX+aGMYiy3ql1oepBTYz7J0nnSeYXwAOedVBGz2u5T1+7+Qe4sGAKaO+Z+aiyBWv1Em/OYT1x8zRrQRPnYRW41kA= ARC-Authentication-Results:i=1; smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=kernel.org header.i=@kernel.org header.b=CSMMdnS8; arc=none smtp.client-ip=10.30.226.201 Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=kernel.org header.i=@kernel.org header.b="CSMMdnS8" Received: by smtp.kernel.org (Postfix) with ESMTPSA id 76799C19421; Sat, 14 Mar 2026 00:38:59 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=kernel.org; s=k20201202; t=1773448739; bh=mkaGOENEa1gmtvrXYu8nQ+hbKTdiqqEtszypw75YmEo=; h=Date:From:To:Cc:Subject:References:In-Reply-To:From; b=CSMMdnS8V1wzMZQMhbCKNINtDMD9y6wXAU3MpkSL9L3U85rIfZE+OW8OFJ3DcdRBM YdlMha2l9YYahxR4kj2FjM9EIsGgGKsjGe240rTgY0FgMVJZ5AYHRLTwGvMLccLVNR sFz2WQNbn3o50gctD0mN1NXAuSglgXdq7HVcmkXMxw5GjT9mcelaYqR8Xsd8RMb8hK owYs8LuW6U1eIxAPP2q7x9okaM4PPhYfZCdM2ZMaZLIFY9zjOyBOMEgHdIwdOD2yZb nCB9x1UHtacCUygnKE9ucVaWoGCNHzYvZqhCViVk/gWDi/9RQutmV0b0MY/ZniJrZD 73jOsFDGNuOXw== Date: Fri, 13 Mar 2026 19:38:58 -0500 From: "Rob Herring (Arm)" To: Krzysztof Kozlowski Cc: Lucas Stach , Pengutronix Kernel Team , devicetree@vger.kernel.org, Sascha Hauer , linux-pci@vger.kernel.org, linux-arm-kernel@lists.infradead.org, Lorenzo Pieralisi , linux-kernel@vger.kernel.org, Gustavo Pimentel , Fabio Estevam , Krzysztof =?utf-8?Q?Wilczy=C5=84ski?= , Manivannan Sadhasivam , Sherry Sun , Jingoo Han , Frank Li , Conor Dooley , Richard Zhu , Bjorn Helgaas , Krzysztof Kozlowski , imx@lists.linux.dev Subject: Re: [PATCH v2 1/2] dt-bindings: PCI: fsl,imx6q-pcie: Explicitly deprecate reset-gpio Message-ID: <177344873783.3740802.16889031626294728182.robh@kernel.org> References: <20260312184344.42337-3-krzysztof.kozlowski@oss.qualcomm.com> Precedence: bulk X-Mailing-List: imx@lists.linux.dev List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <20260312184344.42337-3-krzysztof.kozlowski@oss.qualcomm.com> On Thu, 12 Mar 2026 19:43:45 +0100, Krzysztof Kozlowski wrote: > The binding references snps,dw-pcie-common.yaml which already deprecates > "reset-gpio", however mentioning this property here lacks this mark thus > code is confusing and suggests property is not deprecated. > > OTOH, the property cannot be removed from this schema, because it is an > ABI implemented by Linux kernel in gpiolib-of.c in backwards-compatible > map between compatibles, "reset-gpio" and "reset-gpio-active-high" > properties. > > This creates code and binding which is not obvious to follow, so rewrite > it and be more explicit about: > 1. Deprecation of "reset-gpio", > 2. Relation that "reset-gpio-active-high" is used only for that property > and not proper "reset-gpios". > > Signed-off-by: Krzysztof Kozlowski > > --- > > Cc: Sherry Sun > > Changes in v2: > 1. Rewrite the commit completely after Sherry Sun comments - keep the > property, but add "not" clause to forbid usavge of > "reset-gpio-active-high" and "reset-gpios". > 2. Because of above not adding Richard's ack. > > v1: > https://lore.kernel.org/r/20260311154955.145120-3-krzysztof.kozlowski@oss.qualcomm.com > --- > Documentation/devicetree/bindings/pci/fsl,imx6q-pcie.yaml | 8 ++++++++ > 1 file changed, 8 insertions(+) > Acked-by: Rob Herring (Arm)