From: Ciprian Marian Costea <ciprianmarian.costea@oss.nxp.com>
To: Krzysztof Kozlowski <krzk@kernel.org>,
Greg Kroah-Hartman <gregkh@linuxfoundation.org>,
Jiri Slaby <jirislaby@kernel.org>, Rob Herring <robh@kernel.org>,
Krzysztof Kozlowski <krzk+dt@kernel.org>,
Conor Dooley <conor+dt@kernel.org>,
Chester Lin <chester62515@gmail.com>
Cc: linux-kernel@vger.kernel.org, linux-serial@vger.kernel.org,
devicetree@vger.kernel.org, NXP S32 Linux Team <s32@nxp.com>,
imx@lists.linux.dev, Christophe Lizzi <clizzi@redhat.com>,
Alberto Ruiz <aruizrui@redhat.com>,
Enric Balletbo <eballetb@redhat.com>
Subject: Re: [PATCH v3 1/2] dt-bindings: linflexuart: add clock definitions
Date: Thu, 7 Nov 2024 14:05:06 +0200 [thread overview]
Message-ID: <18aebb8b-954d-4451-9610-0cfd2a5a040c@oss.nxp.com> (raw)
In-Reply-To: <7437a82f-be1d-45d0-9151-886564fabb4b@kernel.org>
On 11/7/2024 1:53 PM, Krzysztof Kozlowski wrote:
> On 07/11/2024 12:46, Ciprian Costea wrote:
>>
>> + clocks:
>> + items:
>> + - description:
>> + ipg clock drives the access to the LINFlexD
>> + iomapped registers
>> + - description: lin is the frequency of the baud clock
>> +
>> + clock-names:
>> + items:
>> + - const: ipg
>> + - const: lin
>> +
>> required:
>> - compatible
>> - reg
>> - interrupts
>> + - clocks
>> + - clock-names
>
> Ah, and that's an ABI break. That's a NAK unless explained in commit msg
> (including impact on users).
>
> Best regards,
> Krzysztof
>
Thanks for your review. I will try to add context for these changes in
bindings in V4.
Best Regards,
Ciprian
next prev parent reply other threads:[~2024-11-07 12:05 UTC|newest]
Thread overview: 9+ messages / expand[flat|nested] mbox.gz Atom feed top
2024-11-07 11:46 [PATCH v3 0/2] add NXP LINFlexD UART clock support for S32G2/S32G3 Ciprian Costea
2024-11-07 11:46 ` [PATCH v3 1/2] dt-bindings: linflexuart: add clock definitions Ciprian Costea
2024-11-07 11:53 ` Krzysztof Kozlowski
2024-11-07 12:00 ` Ciprian Marian Costea
2024-11-07 11:53 ` Krzysztof Kozlowski
2024-11-07 12:05 ` Ciprian Marian Costea [this message]
2024-11-07 11:46 ` [PATCH v3 2/2] serial: fsl_linflexuart: add clock support Ciprian Costea
2024-11-07 15:19 ` Frank Li
2024-11-07 15:39 ` Ciprian Marian Costea
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=18aebb8b-954d-4451-9610-0cfd2a5a040c@oss.nxp.com \
--to=ciprianmarian.costea@oss.nxp.com \
--cc=aruizrui@redhat.com \
--cc=chester62515@gmail.com \
--cc=clizzi@redhat.com \
--cc=conor+dt@kernel.org \
--cc=devicetree@vger.kernel.org \
--cc=eballetb@redhat.com \
--cc=gregkh@linuxfoundation.org \
--cc=imx@lists.linux.dev \
--cc=jirislaby@kernel.org \
--cc=krzk+dt@kernel.org \
--cc=krzk@kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-serial@vger.kernel.org \
--cc=robh@kernel.org \
--cc=s32@nxp.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox