From: Krzysztof Kozlowski <krzk@kernel.org>
To: Joy Zou <joy.zou@nxp.com>
Cc: Liam Girdwood <lgirdwood@gmail.com>,
Mark Brown <broonie@kernel.org>, Rob Herring <robh@kernel.org>,
Krzysztof Kozlowski <krzk+dt@kernel.org>,
Conor Dooley <conor+dt@kernel.org>,
linux-kernel@vger.kernel.org, devicetree@vger.kernel.org,
imx@lists.linux.dev, Frank Li <Frank.Li@nxp.com>,
Ye Li <ye.li@nxp.com>, Jacky Bai <ping.bai@nxp.com>,
Dong Aisheng <aisheng.dong@nxp.com>
Subject: Re: [PATCH v2 1/2] dt-bindings: regulator: add PF0900 regulator yaml
Date: Thu, 24 Jul 2025 20:58:23 +0200 [thread overview]
Message-ID: <1a8bdd00-aaa3-49bb-954e-52c84dad63a3@kernel.org> (raw)
In-Reply-To: <20250724105115.GA1748604@shlinux88>
On 24/07/2025 12:51, Joy Zou wrote:
>>> + type: object
>>> + $ref: regulator.yaml#
>>> + unevaluatedProperties: false
>>> +
>>> + patternProperties:
>>> + "^LDO[1-3]$":
>>> + type: object
>>> + $ref: regulator.yaml#
>>> + unevaluatedProperties: false
>>> +
>>> + "^SW[1-5]$":
>>> + type: object
>>> + $ref: regulator.yaml#
>>> + unevaluatedProperties: false
>>> +
>>> + properties:
>>> + nxp,dvs-run-microvolt:
>>> + minimum: 300000
>>> + maximum: 1350000
>>> + description:
>>> + PMIC default "RUN" state voltage in uV.
>>
>> Why existing properties are not suitable?
> Have not found the property that can set run state voltage in regulator.yaml.
> Can we add a property for run state such as regulator-suspend-microvolt?
>>
>>> +
>>> + nxp,dvs-standby-microvolt:
>>
>> Why existing standby state bindings are not suitable?
> Have found regulator-suspend-microvolt property that can set standby state voltage.
> But the regulator-suspend-microvolt property is now deprecated. Can we use it?
You have regulator-min/max properties for that. Please check with
bindings and other existing code how this looks like. I feel like you
did not try enough to solve it with existing code.
Best regards,
Krzysztof
next prev parent reply other threads:[~2025-07-24 18:58 UTC|newest]
Thread overview: 10+ messages / expand[flat|nested] mbox.gz Atom feed top
2025-07-21 7:11 [PATCH v2 0/2] regulator: add new PMIC PF0900 support Joy Zou
2025-07-21 7:11 ` [PATCH v2 1/2] dt-bindings: regulator: add PF0900 regulator yaml Joy Zou
2025-07-21 7:28 ` Krzysztof Kozlowski
2025-07-21 12:00 ` Mark Brown
2025-07-24 10:51 ` Joy Zou
2025-07-24 18:58 ` Krzysztof Kozlowski [this message]
2025-07-21 7:11 ` [PATCH v2 2/2] regulator: pf0900: Add PMIC PF0900 support Joy Zou
2025-07-21 7:30 ` Krzysztof Kozlowski
2025-07-21 12:26 ` Mark Brown
2025-07-22 10:19 ` kernel test robot
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=1a8bdd00-aaa3-49bb-954e-52c84dad63a3@kernel.org \
--to=krzk@kernel.org \
--cc=Frank.Li@nxp.com \
--cc=aisheng.dong@nxp.com \
--cc=broonie@kernel.org \
--cc=conor+dt@kernel.org \
--cc=devicetree@vger.kernel.org \
--cc=imx@lists.linux.dev \
--cc=joy.zou@nxp.com \
--cc=krzk+dt@kernel.org \
--cc=lgirdwood@gmail.com \
--cc=linux-kernel@vger.kernel.org \
--cc=ping.bai@nxp.com \
--cc=robh@kernel.org \
--cc=ye.li@nxp.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).