Re: [EXT] Re: [PATCH 1/1] net: fec: add initial XDP support

Andrew Lunn
2022-09-29T13:24:22Z

> > > +struct fec_enet_xdp_stats {
> > > + u64 xdp_pass;
> > > + u64 xdp_drop;
> > > + u64 xdp_xmit;
> > > + u64 xdp_redirect;
> > > + u64 xdp_xmit_err;
> > > + u64 xdp_tx;
> > > + u64 xdp_tx_err;
> > > +};
> > > +
> > > + switch (act) {
> > > + case XDP_PASS:
> > > + rxq->stats.xdp_pass++;
> >
> > Since the stats are u64, and most machines using the FEC are 32 bit, you cannot
> > just do an increment. Took a look at u64_stats_sync.h.
> >
>

> As this increment is only executed under the NAPI kthread context,
> is the protection still required?

Are the statistics values read by ethtool under NAPI kthread context?

Andrew