From: Jakub Kicinski <kuba@kernel.org>
To: Shenwei Wang <shenwei.wang@nxp.com>
Cc: Wei Fang <wei.fang@nxp.com>,
"David S. Miller" <davem@davemloft.net>,
Eric Dumazet <edumazet@google.com>,
Paolo Abeni <pabeni@redhat.com>, Simon Horman <horms@kernel.org>,
Horatiu Vultur <horatiu.vultur@microchip.com>,
Heiner Kallweit <hkallweit1@gmail.com>,
Clark Wang <xiaoning.wang@nxp.com>,
NXP Linux Team <linux-imx@nxp.com>,
netdev@vger.kernel.org, imx@lists.linux.dev
Subject: Re: [PATCH v3 net] net: fec: add dma_wmb to ensure correct descriptor values
Date: Fri, 19 May 2023 21:51:26 -0700 [thread overview]
Message-ID: <20230519215126.4ecc695b@kernel.org> (raw)
In-Reply-To: <20230518150202.1920375-1-shenwei.wang@nxp.com>
On Thu, 18 May 2023 10:02:02 -0500 Shenwei Wang wrote:
> Two dma_wmb() are added in the XDP TX path to ensure proper ordering of
> descriptor and buffer updates:
> 1. A dma_wmb() is added after updating the last BD to make sure
> the updates to rest of the descriptor are visible before
> transferring ownership to FEC.
> 2. A dma_wmb() is also added after updating the bdp to ensure these
> updates are visible before updating txq->bd.cur.
> 3. Start the xmit of the frame immediately right after configuring the
> tx descriptor.
>
> Fixes: 6d6b39f180b8 ("net: fec: add initial XDP support")
> Signed-off-by: Shenwei Wang <shenwei.wang@nxp.com>
Applied, thanks (commit 9025944fddfed).
prev parent reply other threads:[~2023-05-20 4:51 UTC|newest]
Thread overview: 3+ messages / expand[flat|nested] mbox.gz Atom feed top
2023-05-18 15:02 [PATCH v3 net] net: fec: add dma_wmb to ensure correct descriptor values Shenwei Wang
2023-05-19 1:33 ` Wei Fang
2023-05-20 4:51 ` Jakub Kicinski [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20230519215126.4ecc695b@kernel.org \
--to=kuba@kernel.org \
--cc=davem@davemloft.net \
--cc=edumazet@google.com \
--cc=hkallweit1@gmail.com \
--cc=horatiu.vultur@microchip.com \
--cc=horms@kernel.org \
--cc=imx@lists.linux.dev \
--cc=linux-imx@nxp.com \
--cc=netdev@vger.kernel.org \
--cc=pabeni@redhat.com \
--cc=shenwei.wang@nxp.com \
--cc=wei.fang@nxp.com \
--cc=xiaoning.wang@nxp.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).