From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from perceval.ideasonboard.com (perceval.ideasonboard.com [213.167.242.64]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id 731831CD1F for ; Sun, 17 Mar 2024 16:56:51 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=213.167.242.64 ARC-Seal:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1710694613; cv=none; b=qB1I6VziU17wvGruTsMvBg9mGpSd8fzVqdDZAXSfhsg5LjJmVfGDyJCl2m0hyM2G6wvarWmHjBdq0VZz03BypAN6olTy84DpZuQWq1xfGs0UbJ3iBLV4njA9vC2qK96rBkOLfOC1dcUQ1IEQNjP75oE1xrlp3aosmjwcGecXcMk= ARC-Message-Signature:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1710694613; c=relaxed/simple; bh=7wcnfopi7RvWNLXHr0SkPa+Jk1zcNIz/buYtoR4Mzp0=; h=Date:From:To:Cc:Subject:Message-ID:References:MIME-Version: Content-Type:Content-Disposition:In-Reply-To; b=Kvc3fqf7t3y2V5aXkDZhoft53GiqEZ/xBNfLdhlv18EOMA4mGYF0HZJMYdFFlu5NuuLz0+0MrovT01TMHmJJcQqGdcoTz48h//pHyymLvDmWHYWlSOUwFK+f3NJPWeT1G9pgcA3JML0M5fSzLXkEz3LfrzqV3aKCtRCsE1kUyhM= ARC-Authentication-Results:i=1; smtp.subspace.kernel.org; dmarc=none (p=none dis=none) header.from=ideasonboard.com; spf=pass smtp.mailfrom=ideasonboard.com; dkim=pass (1024-bit key) header.d=ideasonboard.com header.i=@ideasonboard.com header.b=UpZUG1oA; arc=none smtp.client-ip=213.167.242.64 Authentication-Results: smtp.subspace.kernel.org; dmarc=none (p=none dis=none) header.from=ideasonboard.com Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=ideasonboard.com Authentication-Results: smtp.subspace.kernel.org; dkim=pass (1024-bit key) header.d=ideasonboard.com header.i=@ideasonboard.com header.b="UpZUG1oA" Received: from pendragon.ideasonboard.com (81-175-209-231.bb.dnainternet.fi [81.175.209.231]) by perceval.ideasonboard.com (Postfix) with ESMTPSA id 5EFF363C; Sun, 17 Mar 2024 17:56:24 +0100 (CET) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=ideasonboard.com; s=mail; t=1710694584; bh=7wcnfopi7RvWNLXHr0SkPa+Jk1zcNIz/buYtoR4Mzp0=; h=Date:From:To:Cc:Subject:References:In-Reply-To:From; b=UpZUG1oACv1iliFn2hU1faJ0f94dBkP/KdVXHvv48dVctmz8NiUvUor8StN5RbgKr PpJyOYDFe1lxi952ADG/d3vACvQsCtchowuO6xE3tfU+NNovR9K2Qt8eO1ZeWmzyOF VvRXUSvl0J4GqFXhdBJxZU8CHxxgLdd4sgvlkKzo= Date: Sun, 17 Mar 2024 18:56:47 +0200 From: Laurent Pinchart To: linux-arm-kernel@lists.infradead.org Cc: Shawn Guo , Sascha Hauer , Pengutronix Kernel Team , Fabio Estevam , imx@lists.linux.dev, Rob Herring , Krzysztof Kozlowski , Conor Dooley , devicetree@vger.kernel.org Subject: Re: [PATCH v2 5/5] arm64: dts: freescale: imx8mp-sb-ucm: Add DSI panel overlay Message-ID: <20240317165647.GA646@pendragon.ideasonboard.com> References: <20240317164850.32708-1-laurent.pinchart@ideasonboard.com> <20240317164850.32708-6-laurent.pinchart@ideasonboard.com> Precedence: bulk X-Mailing-List: imx@lists.linux.dev List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Disposition: inline In-Reply-To: <20240317164850.32708-6-laurent.pinchart@ideasonboard.com> On Sun, Mar 17, 2024 at 06:48:50PM +0200, Laurent Pinchart wrote: > The SB-UCM-iMX8MPLUS kit is shipped with an external DSI panel. Add a > corresponding DT overlay. > > Signed-off-by: Laurent Pinchart > --- > arch/arm64/boot/dts/freescale/Makefile | 4 + > .../imx8mp-sb-ucm-panel-kd050hdfia020.dtso | 81 +++++++++++++++++++ > 2 files changed, 85 insertions(+) > create mode 100644 arch/arm64/boot/dts/freescale/imx8mp-sb-ucm-panel-kd050hdfia020.dtso > > diff --git a/arch/arm64/boot/dts/freescale/Makefile b/arch/arm64/boot/dts/freescale/Makefile > index 02efa97fc464..d7432ce6a7bb 100644 > --- a/arch/arm64/boot/dts/freescale/Makefile > +++ b/arch/arm64/boot/dts/freescale/Makefile > @@ -165,6 +165,10 @@ dtb-$(CONFIG_ARCH_MXC) += imx8mp-icore-mx8mp-edimm2.2.dtb > dtb-$(CONFIG_ARCH_MXC) += imx8mp-msc-sm2s-ep1.dtb > dtb-$(CONFIG_ARCH_MXC) += imx8mp-phyboard-pollux-rdk.dtb > dtb-$(CONFIG_ARCH_MXC) += imx8mp-sb-ucm.dtb > + > +imx8mp-sb-ucm-panel-kd050hdfia020-dtbs := imx8mp-sb-ucm.dtb imx8mp-sb-ucm-panel-kd050hdfia020-dtbo > +dtb-$(CONFIG_ARCH_MXC) += imx8mp-sb-ucm-panel-kd050hdfia020-dtb On a side note, is there a way to selectively compile this dtb ? Running $ make dtbs will compile them all, but $ make freescale/imx8mp-sb-ucm-panel-kd050hdfia020-dtb complains with make[4]: *** No rule to make target 'arch/arm64/boot/dts/freescale/imx8mp-sb-ucm-panel-kd050hdfia020.dtb'. Stop. make[3]: *** [/home/laurent/src/iob/toradex/linux/scripts/Makefile.build:481: arch/arm64/boot/dts/freescale] Error 2 make[2]: *** [/home/laurent/src/iob/toradex/linux/Makefile:1389: freescale/imx8mp-sb-ucm-panel-kd050hdfia020.dtb] Error 2 I would like to compile it selectively, as running $ make dtbs CHECK_DTBS=1 makes it much more time consuming to run the dtb checks. > + > dtb-$(CONFIG_ARCH_MXC) += imx8mp-skov-revb-hdmi.dtb > dtb-$(CONFIG_ARCH_MXC) += imx8mp-skov-revb-lt6.dtb > dtb-$(CONFIG_ARCH_MXC) += imx8mp-skov-revb-mi1010ait-1cp1.dtb > diff --git a/arch/arm64/boot/dts/freescale/imx8mp-sb-ucm-panel-kd050hdfia020.dtso b/arch/arm64/boot/dts/freescale/imx8mp-sb-ucm-panel-kd050hdfia020.dtso > new file mode 100644 > index 000000000000..fdad943c1554 > --- /dev/null > +++ b/arch/arm64/boot/dts/freescale/imx8mp-sb-ucm-panel-kd050hdfia020.dtso > @@ -0,0 +1,81 @@ > +// SPDX-License-Identifier: (GPL-2.0+ OR MIT) > +/* > + * Copyright 2021 CompuLab > + * > + * Device tree overlay for KD050HDFIA020-C020A panel connector to Compulab > + * SB-UCM-iMX8PLUS. > + */ > + > +/dts-v1/; > +/plugin/; > + > +#include > +#include > + > +&dsi_backlight { > + status = "okay"; > +}; > + > +&i2c5 { > + status = "okay"; > + > + touch@5d { > + compatible = "goodix,gt911"; > + reg = <0x5d>; > + > + pinctrl-names = "default"; > + pinctrl-0 = <&pinctrl_dsi_touch>; > + > + interrupt-parent = <&gpio4>; > + interrupts = <12 IRQ_TYPE_LEVEL_HIGH>; > + > + irq-gpios = <&gpio4 12 GPIO_ACTIVE_HIGH>; > + reset-gpios = <&pca9555 5 GPIO_ACTIVE_HIGH>; > + }; > +}; > + > +&lcdif1 { > + status = "okay"; > +}; > + > +&mipi_dsi { > + #address-cells = <1>; > + #size-cells = <0>; > + samsung,esc-clock-frequency = <20000000>; > + status = "okay"; > + > + panel@0 { > + compatible = "startek,kd050hdfia020", "ilitek,ili9881c"; > + reg = <0>; > + pinctrl-names = "default"; > + pinctrl-0 = <&pinctrl_dsi_panel>; > + > + reset-gpio = <&pca9555 4 GPIO_ACTIVE_LOW>; > + power-supply = <®_3v3_per>; > + > + backlight = <&dsi_backlight>; > + > + port { > + panel_in: endpoint { > + remote-endpoint = <&mipi_dsi_out>; > + data-lanes = <1 2 3 4>; > + }; > + }; > + }; > + > + ports { > + port@1 { > + reg = <1>; > + > + mipi_dsi_out: endpoint { > + remote-endpoint = <&panel_in>; > + data-lanes = <1 2 3 4>; > + lane-polarities = <0 0 0 0 0>; > + }; > + }; > + }; > +}; > + > +&pwm1 { > + status = "okay"; > +}; -- Regards, Laurent Pinchart