From: Laurent Pinchart <laurent.pinchart@ideasonboard.com>
To: Francesco Dolcini <francesco@dolcini.it>
Cc: Shawn Guo <shawnguo2@yeah.net>,
devicetree@vger.kernel.org, imx@lists.linux.dev,
linux-arm-kernel@lists.infradead.org,
Trevor Zaharichuk <trevor@au-zone.com>,
Greg Lytle <greg@au-zone.com>, Shawn Guo <shawnguo@kernel.org>,
Sascha Hauer <s.hauer@pengutronix.de>,
Pengutronix Kernel Team <kernel@pengutronix.de>,
Fabio Estevam <festevam@gmail.com>, Rob Herring <robh@kernel.org>,
Krzysztof Kozlowski <krzysztof.kozlowski+dt@linaro.org>,
Conor Dooley <conor+dt@kernel.org>
Subject: Re: [PATCH 5/5] arm64: dts: Add device tree source for the Au-Zone Maivin Starter Kit
Date: Wed, 3 Apr 2024 10:35:24 +0300 [thread overview]
Message-ID: <20240403073524.GK16740@pendragon.ideasonboard.com> (raw)
In-Reply-To: <20240403070651.GB5070@francesco-nb>
On Wed, Apr 03, 2024 at 09:06:51AM +0200, Francesco Dolcini wrote:
> Hello Laurent,
>
> On Wed, Apr 03, 2024 at 08:30:11AM +0800, Shawn Guo wrote:
> > On Mon, Mar 25, 2024 at 10:32:45PM +0200, Laurent Pinchart wrote:
> > > diff --git a/arch/arm64/boot/dts/freescale/imx8mp-maivin.dts b/arch/arm64/boot/dts/freescale/imx8mp-maivin.dts
> > > new file mode 100644
> > > index 000000000000..2d1c8e782465
> > > --- /dev/null
> > > +++ b/arch/arm64/boot/dts/freescale/imx8mp-maivin.dts
> > > @@ -0,0 +1,236 @@
>
> [...]
>
> > > +/* Verdin I2C_2_DSI */
> > > +&i2c2 {
> > > + status = "okay";
> > > +
> > > + clock-frequency = <400000>;
> > > + scl-gpios = <&gpio5 16 (GPIO_ACTIVE_HIGH | GPIO_OPEN_DRAIN)>;
> > > + sda-gpios = <&gpio5 17 (GPIO_ACTIVE_HIGH | GPIO_OPEN_DRAIN)>;
> >
> > We usually end property list with 'status'.
>
> This is now a written and explicit guideline, no longer tribal knowledge,
> see https://docs.kernel.org/devicetree/bindings/dts-coding-style.html#order-of-properties-in-device-node
Thanks.
Any chance to teach checkpatch.pl (and/or the DT checker) about that ? :-)
--
Regards,
Laurent Pinchart
prev parent reply other threads:[~2024-04-03 7:35 UTC|newest]
Thread overview: 26+ messages / expand[flat|nested] mbox.gz Atom feed top
2024-03-25 20:32 [PATCH 0/5] arm64: dts: Add device tree source for the Au-Zone Maivin AI Vision Starter Kit Laurent Pinchart
2024-03-25 20:32 ` [PATCH 1/5] dt-bindings: iio: dac: ti,dac5571: Add DAC081C081 support Laurent Pinchart
2024-03-25 20:48 ` Jonathan Cameron
2024-03-25 20:56 ` Laurent Pinchart
2024-03-25 22:23 ` Laurent Pinchart
2024-03-25 22:32 ` Jonathan Cameron
2024-03-26 15:29 ` Jonathan Cameron
2024-03-26 16:50 ` Laurent Pinchart
2024-03-26 17:13 ` Jonathan Cameron
2024-03-26 18:21 ` Jonathan Cameron
2024-03-26 9:00 ` Sean Nyekjaer
2024-03-25 20:32 ` [PATCH 2/5] iio: dac: ti-dac5571: " Laurent Pinchart
2024-03-26 9:00 ` Sean Nyekjaer
2024-03-25 20:32 ` [PATCH 3/5] dt-bindings: vendor-prefix: Add prefix for Au-Zone Technologies Laurent Pinchart
2024-03-26 7:10 ` Krzysztof Kozlowski
2024-03-25 20:32 ` [PATCH 4/5] dt-bindings: arm: Add Au-Zone Maivin AI Vision Starter Kit Laurent Pinchart
2024-03-26 7:11 ` Krzysztof Kozlowski
2024-03-27 1:01 ` Laurent Pinchart
2024-03-27 5:00 ` Krzysztof Kozlowski
2024-03-25 20:32 ` [PATCH 5/5] arm64: dts: Add device tree source for the Au-Zone Maivin " Laurent Pinchart
2024-03-26 7:12 ` Krzysztof Kozlowski
2024-03-26 9:11 ` Laurent Pinchart
2024-03-26 12:01 ` Krzysztof Kozlowski
2024-04-03 0:30 ` Shawn Guo
2024-04-03 7:06 ` Francesco Dolcini
2024-04-03 7:35 ` Laurent Pinchart [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20240403073524.GK16740@pendragon.ideasonboard.com \
--to=laurent.pinchart@ideasonboard.com \
--cc=conor+dt@kernel.org \
--cc=devicetree@vger.kernel.org \
--cc=festevam@gmail.com \
--cc=francesco@dolcini.it \
--cc=greg@au-zone.com \
--cc=imx@lists.linux.dev \
--cc=kernel@pengutronix.de \
--cc=krzysztof.kozlowski+dt@linaro.org \
--cc=linux-arm-kernel@lists.infradead.org \
--cc=robh@kernel.org \
--cc=s.hauer@pengutronix.de \
--cc=shawnguo2@yeah.net \
--cc=shawnguo@kernel.org \
--cc=trevor@au-zone.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox