Re: [PATCH v2 4/5] pinctrl: qcom: sm7150: fix module autoloading

Bjorn Andersson
2024-04-11T15:44:54Z

On Thu, Apr 11, 2024 at 08:46:13AM +0200, Krzysztof Kozlowski wrote:
> Add MODULE_DEVICE_TABLE(), so the module could be properly autoloaded
> based on the alias from of_device_id table. Pin controllers are
> considered core components, so usually they are built-in, however these
> can be built and used as modules on some generic kernel.
>
> Reviewed-by: Konrad Dybcio <konrad.dybcio@linaro.org>
> Signed-off-by: Krzysztof Kozlowski <krzk@kernel.org>
>

Reviewed-by: Bjorn Andersson <quic_bjorande@quicinc.com>

Regards,
Bjorn

> ---
>
> Changes in v2:
> 1. Add ack
> ---
> drivers/pinctrl/qcom/pinctrl-sm7150.c | 1 +
> 1 file changed, 1 insertion(+)
>
> diff --git a/drivers/pinctrl/qcom/pinctrl-sm7150.c b/drivers/pinctrl/qcom/pinctrl-sm7150.c
> index c25357ca1963..c542f9bc6bcd 100644
> --- a/drivers/pinctrl/qcom/pinctrl-sm7150.c
> +++ b/drivers/pinctrl/qcom/pinctrl-sm7150.c
> @@ -1246,6 +1246,7 @@ static const struct of_device_id sm7150_tlmm_of_match[] = {
> { .compatible = "qcom,sm7150-tlmm", },
> { },
> };
> +MODULE_DEVICE_TABLE(of, sm7150_tlmm_of_match);
>
> static struct platform_driver sm7150_tlmm_driver = {
> .driver = {
> --
> 2.34.1
>