From: Jonathan Cameron <jic23@kernel.org>
To: David Lechner <dlechner@baylibre.com>
Cc: Lars-Peter Clausen <lars@metafoo.de>,
Michael Hennerich <Michael.Hennerich@analog.com>,
Shawn Guo <shawnguo@kernel.org>,
Sascha Hauer <s.hauer@pengutronix.de>,
Pengutronix Kernel Team <kernel@pengutronix.de>,
Fabio Estevam <festevam@gmail.com>,
linux-iio@vger.kernel.org, linux-kernel@vger.kernel.org,
imx@lists.linux.dev, linux-arm-kernel@lists.infradead.org
Subject: Re: [PATCH 0/3] iio: cleanup masklength usage
Date: Sun, 28 Apr 2024 14:27:19 +0100 [thread overview]
Message-ID: <20240428142719.08363889@jic23-huawei> (raw)
In-Reply-To: <20240425-b4-iio-masklength-cleanup-v1-0-d3d16318274d@baylibre.com>
On Thu, 25 Apr 2024 10:03:26 -0500
David Lechner <dlechner@baylibre.com> wrote:
> While working on other patches I noticed that a few drivers are setting
> the masklength field of struct iio_dev even though it is marked as
> [INTERN]. It looks like maybe this was not always the case, but we can
> safely clean it up now without breaking anything.
>
> ---
> David Lechner (3):
> iio: adc: ad7266: don't set masklength
> iio: adc: mxs-lradc-adc: don't set masklength
> iio: buffer: initialize masklength accumulator to 0
>
> drivers/iio/adc/ad7266.c | 1 -
> drivers/iio/adc/mxs-lradc-adc.c | 1 -
> drivers/iio/industrialio-buffer.c | 2 +-
> 3 files changed, 1 insertion(+), 3 deletions(-)
Applied to the togreg branch of iio.git and pushed out as testing for 0-day
to poke at it.
I can't remember that ever being set by drivers so this is rather weird.
Mind you our docs used to be less clear on what drivers should set so
maybe that was the issue.
Jonathan
> ---
> base-commit: b80ad8e3cd2712b78b98804d1f59199680d8ed91
> change-id: 20240425-b4-iio-masklength-cleanup-86b632b19901
>
prev parent reply other threads:[~2024-04-28 13:27 UTC|newest]
Thread overview: 9+ messages / expand[flat|nested] mbox.gz Atom feed top
2024-04-25 15:03 [PATCH 0/3] iio: cleanup masklength usage David Lechner
2024-04-25 15:03 ` [PATCH 1/3] iio: adc: ad7266: don't set masklength David Lechner
2024-04-25 15:03 ` [PATCH 2/3] iio: adc: mxs-lradc-adc: " David Lechner
2024-04-25 15:03 ` [PATCH 3/3] iio: buffer: initialize masklength accumulator to 0 David Lechner
2024-04-26 7:13 ` [PATCH 0/3] iio: cleanup masklength usage Nuno Sá
2024-04-26 15:26 ` David Lechner
2024-04-28 13:23 ` Jonathan Cameron
2024-04-29 7:17 ` Nuno Sá
2024-04-28 13:27 ` Jonathan Cameron [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20240428142719.08363889@jic23-huawei \
--to=jic23@kernel.org \
--cc=Michael.Hennerich@analog.com \
--cc=dlechner@baylibre.com \
--cc=festevam@gmail.com \
--cc=imx@lists.linux.dev \
--cc=kernel@pengutronix.de \
--cc=lars@metafoo.de \
--cc=linux-arm-kernel@lists.infradead.org \
--cc=linux-iio@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=s.hauer@pengutronix.de \
--cc=shawnguo@kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox