From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from perceval.ideasonboard.com (perceval.ideasonboard.com [213.167.242.64]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id 70BF85A79B for ; Sat, 12 Oct 2024 17:24:48 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=213.167.242.64 ARC-Seal:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1728753890; cv=none; b=IIEfKq9Cz/RXBfpwDyY/nqGgWyb6MMgIXvJ72oz7wvqvHgx/7smEWs1sY3y17pUQ2qfe5Fafy7J1G1MiPCL4TJcS8flTU/9tR4XkI75pFb3xzg1dNQm1xpcoeZx7RbWG/TswD699qPcslGphP5WjlqdnqRI2ak449ym7i3Rz70w= ARC-Message-Signature:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1728753890; c=relaxed/simple; bh=/0qUtB/X1QeFYuMXBYgTtniMi+l9quvLBDXPRdvLo8s=; h=Date:From:To:Cc:Subject:Message-ID:References:MIME-Version: Content-Type:Content-Disposition:In-Reply-To; b=B2CjpWUZyisb2PN1FIr6CLPs10XGGTDOobkEJ/Q41x8l/czyTfIQi68VS+Ed4gTGnlS6rDvN7pvsre5F0kOIHx//z9KUgZbBk6rlRkAQx5BDNaL79vFReHL30ho0Mon2Mcl6998oKEsfvZ37IeKqO+38WJLzWn0WSMP1q0JgM1M= ARC-Authentication-Results:i=1; smtp.subspace.kernel.org; dmarc=none (p=none dis=none) header.from=ideasonboard.com; spf=pass smtp.mailfrom=ideasonboard.com; dkim=pass (1024-bit key) header.d=ideasonboard.com header.i=@ideasonboard.com header.b=e/mY8B9Y; arc=none smtp.client-ip=213.167.242.64 Authentication-Results: smtp.subspace.kernel.org; dmarc=none (p=none dis=none) header.from=ideasonboard.com Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=ideasonboard.com Authentication-Results: smtp.subspace.kernel.org; dkim=pass (1024-bit key) header.d=ideasonboard.com header.i=@ideasonboard.com header.b="e/mY8B9Y" Received: from pendragon.ideasonboard.com (unknown [23.233.251.139]) by perceval.ideasonboard.com (Postfix) with ESMTPSA id EBFE38BF; Sat, 12 Oct 2024 19:22:57 +0200 (CEST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=ideasonboard.com; s=mail; t=1728753780; bh=/0qUtB/X1QeFYuMXBYgTtniMi+l9quvLBDXPRdvLo8s=; h=Date:From:To:Cc:Subject:References:In-Reply-To:From; b=e/mY8B9YqA2rNzW0k7uaRA0rgy5a/ao/5VmANTe2HctXOtwADmOGNGoJE71xiNCxf WKq6yuWeuYKPLNNJySyVPW8W/2n+rxb52z3iSoC3zsHtAtzb6qkFenruvZsSo71UIk pbJZtjICQn9yV3r7WLH86xEgXJyIJotLXk7CxEM8= Date: Sat, 12 Oct 2024 20:24:30 +0300 From: Laurent Pinchart To: Bryan O'Donoghue Cc: Mauro Carvalho Chehab , Rob Herring , Krzysztof Kozlowski , Conor Dooley , Dave Stevenson , Sakari Ailus , Shawn Guo , Sascha Hauer , Pengutronix Kernel Team , Fabio Estevam , Martin Kepplinger , Paul Kocialkowski , "Paul J. Murphy" , Daniele Alessandrelli , Tommaso Merciai , Martin Hecht , Zhi Mao , Alain Volmat , Mikhail Rudenko , Ricardo Ribalda , Kieran Bingham , Umang Jain , Manivannan Sadhasivam , Vladimir Zapolskiy , Dongchun Zhu , Quentin Schulz , Todor Tomov , Krzysztof Kozlowski , linux-media@vger.kernel.org, devicetree@vger.kernel.org, linux-kernel@vger.kernel.org, imx@lists.linux.dev, linux-arm-kernel@lists.infradead.org Subject: Re: [PATCH 1/2] media: dt-bindings: Remove assigned-clock-* from various schema Message-ID: <20241012172430.GB5212@pendragon.ideasonboard.com> References: <20241012-b4-linux-next-202041004-i2c-media-yaml-fixes-v1-0-a2bb12a1796d@linaro.org> <20241012-b4-linux-next-202041004-i2c-media-yaml-fixes-v1-1-a2bb12a1796d@linaro.org> Precedence: bulk X-Mailing-List: imx@lists.linux.dev List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Disposition: inline In-Reply-To: <20241012-b4-linux-next-202041004-i2c-media-yaml-fixes-v1-1-a2bb12a1796d@linaro.org> Hi Bryan, Thank you for the patch. On Sat, Oct 12, 2024 at 04:02:50PM +0100, Bryan O'Donoghue wrote: > Remove extraneous assigned-clock* from media/i2c/* schemas, retain in the > relevant examples. You may want to explain in the commit message *why* you're doing this. The reason may not be straightforward for everybody. With that, Reviewed-by: Laurent Pinchart > > Link: https://lore.kernel.org/linux-media/j7kgz2lyxnler5qwd7yiazdq6fmsv77kyozdrxf33h54ydakjz@uqjhwhoyv6re > Signed-off-by: Bryan O'Donoghue > --- > Documentation/devicetree/bindings/media/i2c/hynix,hi846.yaml | 8 -------- > Documentation/devicetree/bindings/media/i2c/ovti,ov5648.yaml | 8 -------- > Documentation/devicetree/bindings/media/i2c/ovti,ov8865.yaml | 8 -------- > Documentation/devicetree/bindings/media/i2c/ovti,ov9282.yaml | 4 ---- > Documentation/devicetree/bindings/media/i2c/sony,imx258.yaml | 4 ---- > Documentation/devicetree/bindings/media/i2c/sony,imx334.yaml | 4 ---- > Documentation/devicetree/bindings/media/i2c/sony,imx335.yaml | 4 ---- > Documentation/devicetree/bindings/media/i2c/sony,imx412.yaml | 4 ---- > 8 files changed, 44 deletions(-) > > diff --git a/Documentation/devicetree/bindings/media/i2c/hynix,hi846.yaml b/Documentation/devicetree/bindings/media/i2c/hynix,hi846.yaml > index 60f19e1152b33128cf3baa15b8c70a874ca6d52e..d18ead8f7fc43bfacc291aed85b5ca9166c46edb 100644 > --- a/Documentation/devicetree/bindings/media/i2c/hynix,hi846.yaml > +++ b/Documentation/devicetree/bindings/media/i2c/hynix,hi846.yaml > @@ -28,12 +28,6 @@ properties: > items: > - description: Reference to the mclk clock. > > - assigned-clocks: > - maxItems: 1 > - > - assigned-clock-rates: > - maxItems: 1 > - > reset-gpios: > description: Reference to the GPIO connected to the RESETB pin. Active low. > maxItems: 1 > @@ -82,8 +76,6 @@ required: > - compatible > - reg > - clocks > - - assigned-clocks > - - assigned-clock-rates > - vddio-supply > - vdda-supply > - vddd-supply > diff --git a/Documentation/devicetree/bindings/media/i2c/ovti,ov5648.yaml b/Documentation/devicetree/bindings/media/i2c/ovti,ov5648.yaml > index 1f497679168c8395a94b3867beb49b251ef621fc..622243cae03caa5d14aa312df40ef5907e190d2c 100644 > --- a/Documentation/devicetree/bindings/media/i2c/ovti,ov5648.yaml > +++ b/Documentation/devicetree/bindings/media/i2c/ovti,ov5648.yaml > @@ -20,12 +20,6 @@ properties: > items: > - description: XVCLK Clock > > - assigned-clocks: > - maxItems: 1 > - > - assigned-clock-rates: > - maxItems: 1 > - > dvdd-supply: > description: Digital Domain Power Supply > > @@ -68,8 +62,6 @@ required: > - compatible > - reg > - clocks > - - assigned-clocks > - - assigned-clock-rates > - dvdd-supply > - dovdd-supply > - port > diff --git a/Documentation/devicetree/bindings/media/i2c/ovti,ov8865.yaml b/Documentation/devicetree/bindings/media/i2c/ovti,ov8865.yaml > index 8a70e23ba6abed67d8b61c33bd7a261089bddda2..382d7de7a89bcea11be384a2a3800512994f9346 100644 > --- a/Documentation/devicetree/bindings/media/i2c/ovti,ov8865.yaml > +++ b/Documentation/devicetree/bindings/media/i2c/ovti,ov8865.yaml > @@ -20,12 +20,6 @@ properties: > items: > - description: EXTCLK Clock > > - assigned-clocks: > - maxItems: 1 > - > - assigned-clock-rates: > - maxItems: 1 > - > dvdd-supply: > description: Digital Domain Power Supply > > @@ -68,8 +62,6 @@ required: > - compatible > - reg > - clocks > - - assigned-clocks > - - assigned-clock-rates > - dvdd-supply > - avdd-supply > - dovdd-supply > diff --git a/Documentation/devicetree/bindings/media/i2c/ovti,ov9282.yaml b/Documentation/devicetree/bindings/media/i2c/ovti,ov9282.yaml > index 79a7658f6d0547e4d6fb2267e5757eedf49fd416..38325cf318f7bd2cd60a4c7bbb6a65b54b855e26 100644 > --- a/Documentation/devicetree/bindings/media/i2c/ovti,ov9282.yaml > +++ b/Documentation/devicetree/bindings/media/i2c/ovti,ov9282.yaml > @@ -27,10 +27,6 @@ properties: > description: I2C address > maxItems: 1 > > - assigned-clocks: true > - assigned-clock-parents: true > - assigned-clock-rates: true > - > clocks: > description: Clock frequency from 6 to 27MHz > maxItems: 1 > diff --git a/Documentation/devicetree/bindings/media/i2c/sony,imx258.yaml b/Documentation/devicetree/bindings/media/i2c/sony,imx258.yaml > index c978abc0cdb35cfe2b85069946cf1be435a58cb8..f0f9726a2add89492b8c56e17ed607841baa3a0d 100644 > --- a/Documentation/devicetree/bindings/media/i2c/sony,imx258.yaml > +++ b/Documentation/devicetree/bindings/media/i2c/sony,imx258.yaml > @@ -24,10 +24,6 @@ properties: > - sony,imx258 > - sony,imx258-pdaf > > - assigned-clocks: true > - assigned-clock-parents: true > - assigned-clock-rates: true > - > clocks: > description: > Clock frequency from 6 to 27 MHz. > diff --git a/Documentation/devicetree/bindings/media/i2c/sony,imx334.yaml b/Documentation/devicetree/bindings/media/i2c/sony,imx334.yaml > index bce57b22f7b63bd73f08d8831d9bb04858ef03e0..872b8288948b2bba743f2365a55165181df156ae 100644 > --- a/Documentation/devicetree/bindings/media/i2c/sony,imx334.yaml > +++ b/Documentation/devicetree/bindings/media/i2c/sony,imx334.yaml > @@ -24,10 +24,6 @@ properties: > description: I2C address > maxItems: 1 > > - assigned-clocks: true > - assigned-clock-parents: true > - assigned-clock-rates: true > - > clocks: > description: Clock frequency from 6 to 27 MHz, 37.125MHz, 74.25MHz > maxItems: 1 > diff --git a/Documentation/devicetree/bindings/media/i2c/sony,imx335.yaml b/Documentation/devicetree/bindings/media/i2c/sony,imx335.yaml > index 77bf3a4ee89db3b5d16149470c0380ef8f1aeac1..38bd1c7304a59bb5fea90954c1e4e626a7c86f2f 100644 > --- a/Documentation/devicetree/bindings/media/i2c/sony,imx335.yaml > +++ b/Documentation/devicetree/bindings/media/i2c/sony,imx335.yaml > @@ -24,10 +24,6 @@ properties: > description: I2C address > maxItems: 1 > > - assigned-clocks: true > - assigned-clock-parents: true > - assigned-clock-rates: true > - > clocks: > description: Clock frequency from 6 to 27 MHz, 37.125MHz, 74.25MHz > maxItems: 1 > diff --git a/Documentation/devicetree/bindings/media/i2c/sony,imx412.yaml b/Documentation/devicetree/bindings/media/i2c/sony,imx412.yaml > index d9b7815650fdb890418fc96c828acc9147dfb6e8..ece1e17fe34553671e61c965eb1833c5eb08131b 100644 > --- a/Documentation/devicetree/bindings/media/i2c/sony,imx412.yaml > +++ b/Documentation/devicetree/bindings/media/i2c/sony,imx412.yaml > @@ -26,10 +26,6 @@ properties: > description: I2C address > maxItems: 1 > > - assigned-clocks: true > - assigned-clock-parents: true > - assigned-clock-rates: true > - > clocks: > description: Clock frequency 6MHz, 12MHz, 18MHz, 24MHz or 27MHz > maxItems: 1 -- Regards, Laurent Pinchart