From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from perceval.ideasonboard.com (perceval.ideasonboard.com [213.167.242.64]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id 328F5174ED0 for ; Tue, 15 Oct 2024 11:28:12 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=213.167.242.64 ARC-Seal:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1728991694; cv=none; b=rhcCULvJE0bYMn3Xp77SW+rS3yFyq3Bhs85Z7e0nQtnoIMFwe9zw2m1aK1hQQ91T7ZP4Llh6CKU1vcWPQiCgZ1ckkQ7o1nisLMqR1BtYeHGA/O58eKhPY0qpsFXhr3uF4YAUhqh7xSc2eF1/msKa6DVEutMeI2Amo7f3T2MRtBM= ARC-Message-Signature:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1728991694; c=relaxed/simple; bh=aIC2OZAqGqTtztYEmIEZTJyF+HXvL+8ZWYwY26kDDTI=; h=Date:From:To:Cc:Subject:Message-ID:References:MIME-Version: Content-Type:Content-Disposition:In-Reply-To; b=R5yysNgOY05zkaMRLbT+7N/xSVtBV50375RdDIZ/qWoXj7YDdMsYmmgBm2pHTTSmPWwhQhUrm4gUTXuuo2QVmO/QN8SqaccCsR7gQLywxQ9xNjoi03dJ1+YAKr1oa3xf78rkpZq4kzsP7WEpa3TPj5PUaKy7ODY454g9shnKAJo= ARC-Authentication-Results:i=1; smtp.subspace.kernel.org; dmarc=none (p=none dis=none) header.from=ideasonboard.com; spf=pass smtp.mailfrom=ideasonboard.com; dkim=pass (1024-bit key) header.d=ideasonboard.com header.i=@ideasonboard.com header.b=DGOYS45k; arc=none smtp.client-ip=213.167.242.64 Authentication-Results: smtp.subspace.kernel.org; dmarc=none (p=none dis=none) header.from=ideasonboard.com Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=ideasonboard.com Authentication-Results: smtp.subspace.kernel.org; dkim=pass (1024-bit key) header.d=ideasonboard.com header.i=@ideasonboard.com header.b="DGOYS45k" Received: from pendragon.ideasonboard.com (unknown [185.143.39.11]) by perceval.ideasonboard.com (Postfix) with ESMTPSA id 529A2A27; Tue, 15 Oct 2024 13:26:28 +0200 (CEST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=ideasonboard.com; s=mail; t=1728991588; bh=aIC2OZAqGqTtztYEmIEZTJyF+HXvL+8ZWYwY26kDDTI=; h=Date:From:To:Cc:Subject:References:In-Reply-To:From; b=DGOYS45kKK3n53Yc6QU3isEk5utLwRuC0YbgFeVZmJMDwp1PraScd/R1hkyqWzFfS C8n55NTag2v1CQwKnJm5TPu9Sq4CXsD0Roh+cKk6KxsEqBGMV0L88AG1UtRPKbk8sZ 8pAKsNcI14R9O+LAluaY8m/KAI9sItpxlv9WC02E= Date: Tue, 15 Oct 2024 14:28:06 +0300 From: Laurent Pinchart To: Krzysztof Kozlowski Cc: Bryan O'Donoghue , Mauro Carvalho Chehab , Rob Herring , Krzysztof Kozlowski , Conor Dooley , Dave Stevenson , Sakari Ailus , Shawn Guo , Sascha Hauer , Pengutronix Kernel Team , Fabio Estevam , Martin Kepplinger , Paul Kocialkowski , "Paul J. Murphy" , Daniele Alessandrelli , Tommaso Merciai , Martin Hecht , Zhi Mao , Alain Volmat , Mikhail Rudenko , Ricardo Ribalda , Kieran Bingham , Umang Jain , Manivannan Sadhasivam , Vladimir Zapolskiy , Dongchun Zhu , Quentin Schulz , Todor Tomov , linux-media@vger.kernel.org, devicetree@vger.kernel.org, linux-kernel@vger.kernel.org, imx@lists.linux.dev, linux-arm-kernel@lists.infradead.org Subject: Re: [PATCH 2/2] media: dt-bindings: Use additionalProperties: false for endpoint: properties: Message-ID: <20241015112806.GA2712@pendragon.ideasonboard.com> References: <20241012-b4-linux-next-202041004-i2c-media-yaml-fixes-v1-0-a2bb12a1796d@linaro.org> <20241012-b4-linux-next-202041004-i2c-media-yaml-fixes-v1-2-a2bb12a1796d@linaro.org> <7ecxjoa7aije46cxmkyfd6ihxnqw4wleqkioddomxbwlu7qtrc@4dkfitppeksu> <6f461cb3-3a41-4a3d-b9b2-71b1c6be77f7@linaro.org> <9510b546-28fa-4fb4-b06e-0af5f9fd3bbb@kernel.org> <20241014202920.GE5522@pendragon.ideasonboard.com> Precedence: bulk X-Mailing-List: imx@lists.linux.dev List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Disposition: inline In-Reply-To: Hi Krzysztof, On Tue, Oct 15, 2024 at 08:11:18AM +0200, Krzysztof Kozlowski wrote: > On 14/10/2024 22:29, Laurent Pinchart wrote: > > On Mon, Oct 14, 2024 at 10:47:31AM +0200, Krzysztof Kozlowski wrote: > >> On 14/10/2024 10:31, Bryan O'Donoghue wrote: > >>> On 14/10/2024 08:45, Krzysztof Kozlowski wrote: > >>>> I do not understand the reasoning behind this change at all. I don't > >>>> think DT maintainers ever suggested it (in fact, rather opposite: > >>>> suggested using unevaluatedProps) and I think is not a consensus of any > >>>> talks. > >>> > >>> No there is not but then, how do you give consistent feedback except > >>> proposing something to be a baseline. > >>> > >>> On the one hand you have upstream additionalProperties: false and > >>> unevaluatedProperites: false - it'd be better to have a consistent > >>> message on which is to be used. > >> > >> Well, I am afraid that push towards additionalProps will lead to grow > >> common schema (video-interface-devices or video-interfaces) into huge > >> one-fit-all binding. And that's not good. > >> > >> If a common binding for a group of devices encourages you to list its > >> subset, then it is not that common. > >> > >> Solution is to fix that, e.g. split it per classes of devices. > > > > I think splitting large schemas per class is a good idea, but the > > problem will still exist. For instance, if we were to move the > > CSI-2-specific properties to a separate schema, that schema would define > > clock-lanes, data-lanes and clock-noncontinuous. The clock-lanes and > > clock-noncontinuous properties do not apply to every device, how would > > we then handle that ? I see three options: > > Why is this a problem? Why is this a problem here, but not in other > subsystems having exactly the same case? I won't talk for other subsystems, but I can say I see value in explicitly expressing what properties are valid for a device in DT bindings both to inform DT authors and to perform validation on DT sources. That's the whole point of YAML schemas, and I can't see a good reason not to use the tooling we have developed when it has an easy way to do the job. -- Regards, Laurent Pinchart