From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from relay7-d.mail.gandi.net (relay7-d.mail.gandi.net [217.70.183.200]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id E775139FE5 for ; Thu, 17 Oct 2024 07:41:05 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=217.70.183.200 ARC-Seal:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1729150869; cv=none; b=GIfYf8FzaSzsoj08EKxTrg2VhiP3h9hWPHfL6U7uOIjOKw5Y+OvrmWAeC/gbtxy5qmAUIGe2uPAxSqdML0nl9MjleU52upw3c5ipIRPb78RVQUFCBRvfkZXZfSsB0jJKLyKaadP7aTJ1FESBjVyFOGFPlbTilImS4gk3ONGmF8A= ARC-Message-Signature:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1729150869; c=relaxed/simple; bh=lxbhKpjIWxwh6qu8TuuaTXt/ctrJ8zonrWfRF9sT0NA=; h=Date:From:To:Cc:Subject:Message-ID:In-Reply-To:References: MIME-Version:Content-Type; b=SL9sJsJa2R3gFhf5OOnZ/oNYAFKqgXgPV22TGAeEgpybKTxdbgmssfAay4f0Uq5Q4qDWcwpvipvbFvuPLzaSff8akFXfvDQIMPDZttH1SosgUC3lkvDM0guzD0//knM4cqcB5T+KaUEqhVQ1u5daTnxlMTeq8ljEsnUghk4f8xo= ARC-Authentication-Results:i=1; smtp.subspace.kernel.org; dmarc=pass (p=reject dis=none) header.from=bootlin.com; spf=pass smtp.mailfrom=bootlin.com; dkim=pass (2048-bit key) header.d=bootlin.com header.i=@bootlin.com header.b=NR7QYgU3; arc=none smtp.client-ip=217.70.183.200 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=reject dis=none) header.from=bootlin.com Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=bootlin.com Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=bootlin.com header.i=@bootlin.com header.b="NR7QYgU3" Received: by mail.gandi.net (Postfix) with ESMTPSA id BCF9C20004; Thu, 17 Oct 2024 07:41:01 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=bootlin.com; s=gm1; t=1729150864; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:cc:mime-version:mime-version:content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references; bh=f5XJitMQNSPDDFsYL9nvyuekdXE449S3Jl1KSVsNvJU=; b=NR7QYgU36NuU0PcIfex/TStyG0H14UWJIdJ8/bARkJ53gVAZ7r7l2nt/M9/7bOBkW+N3Ah CSqgBjw3lJ8YmTf+sbbKHsaOH6h8HEClBch/7KieOLmoTl/gAxhqej6BiiJLmurdSE/UFV UXcnPzUy3RM7m0wZUOSd7OzoQXgpCgBYdLUOwqYk7/XC4JS6dMf5hL4yA+RVUC4heHVoJy URi+mo60N49Uaoo8iAogijQxg7gDDoGVwV2g+CfhjJkc/m8hyAk+ep//IuSe7H2QRZ+xM5 hJRkz5B7uIeP6e3/PuiUqRR9D6yD0bTEGBBOHlg1D1E/fflupnZTI2HPxTTnFQ== Date: Thu, 17 Oct 2024 09:40:59 +0200 From: Miquel Raynal To: Frank Li Cc: Alexandre Belloni , linux-i3c@lists.infradead.org, linux-kernel@vger.kernel.org, arnd@arndb.de, bbrezillon@kernel.org, boris.brezillon@collabora.com, conor.culhane@silvaco.com, gregkh@linuxfoundation.org, imx@lists.linux.dev, pthombar@cadence.com, ravindra.yashvant.shinde@nxp.com Subject: Re: [PATCH v7 2/3] i3c: master: Extend address status bit to 4 and add I3C_ADDR_SLOT_EXT_DESIRED Message-ID: <20241017094059.4e4ed56d@xps-13> In-Reply-To: References: <20241008-i3c_dts_assign-v7-0-96ec93d1f34c@nxp.com> <20241008-i3c_dts_assign-v7-2-96ec93d1f34c@nxp.com> Organization: Bootlin X-Mailer: Claws Mail 4.2.0 (GTK 3.24.41; x86_64-pc-linux-gnu) Precedence: bulk X-Mailing-List: imx@lists.linux.dev List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: quoted-printable X-GND-Sasl: miquel.raynal@bootlin.com Hi Frank, Frank.li@nxp.com wrote on Wed, 16 Oct 2024 12:09:03 -0400: > On Tue, Oct 08, 2024 at 11:18:25AM -0400, Frank Li wrote: > > Extend the address status bit to 4 and introduce the > > I3C_ADDR_SLOT_EXT_DESIRED macro to indicate that a device prefers a > > specific address. This is generally set by the 'assigned-address' in the > > device tree source (dts) file. > > > > =E2=94=8C=E2=94=80=E2=94=80=E2=94=80=E2=94=80=E2=94=AC=E2=94=80=E2=94= =80=E2=94=80=E2=94=80=E2=94=80=E2=94=80=E2=94=80=E2=94=80=E2=94=80=E2=94=80= =E2=94=80=E2=94=80=E2=94=80=E2=94=AC=E2=94=80=E2=94=80=E2=94=80=E2=94=AC=E2= =94=80=E2=94=80=E2=94=80=E2=94=80=E2=94=80=E2=94=80=E2=94=80=E2=94=80=E2=94= =80=E2=94=AC=E2=94=80=E2=94=80=E2=94=80=E2=94=90 > > =E2=94=82S/Sr=E2=94=82 7'h7E RnW=3D0 =E2=94=82ACK=E2=94=82 ENTDAA =E2= =94=82 T =E2=94=9C=E2=94=80=E2=94=80=E2=94=80=E2=94=80=E2=94=90 > > =E2=94=94=E2=94=80=E2=94=80=E2=94=80=E2=94=80=E2=94=B4=E2=94=80=E2=94= =80=E2=94=80=E2=94=80=E2=94=80=E2=94=80=E2=94=80=E2=94=80=E2=94=80=E2=94=80= =E2=94=80=E2=94=80=E2=94=80=E2=94=B4=E2=94=80=E2=94=80=E2=94=80=E2=94=B4=E2= =94=80=E2=94=80=E2=94=80=E2=94=80=E2=94=80=E2=94=80=E2=94=80=E2=94=80=E2=94= =80=E2=94=B4=E2=94=80=E2=94=80=E2=94=80=E2=94=98 =E2=94=82 > > =E2=94=8C=E2=94=80=E2=94=80=E2=94=80=E2=94=80=E2=94=80=E2=94=80=E2=94= =80=E2=94=80=E2=94=80=E2=94=80=E2=94=80=E2=94=80=E2=94=80=E2=94=80=E2=94=80= =E2=94=80=E2=94=80=E2=94=80=E2=94=80=E2=94=80=E2=94=80=E2=94=80=E2=94=80=E2= =94=80=E2=94=80=E2=94=80=E2=94=80=E2=94=80=E2=94=80=E2=94=80=E2=94=80=E2=94= =80=E2=94=80=E2=94=80=E2=94=80=E2=94=80=E2=94=80=E2=94=80=E2=94=80=E2=94=80= =E2=94=80=E2=94=98 > > =E2=94=82 =E2=94=8C=E2=94=80=E2=94=80=E2=94=AC=E2=94=80=E2=94=80=E2= =94=80=E2=94=80=E2=94=80=E2=94=80=E2=94=80=E2=94=80=E2=94=80=E2=94=80=E2=94= =80=E2=94=80=E2=94=80=E2=94=AC=E2=94=80=E2=94=80=E2=94=80=E2=94=AC=E2=94=80= =E2=94=80=E2=94=80=E2=94=80=E2=94=80=E2=94=80=E2=94=80=E2=94=80=E2=94=80=E2= =94=80=E2=94=80=E2=94=80=E2=94=80=E2=94=80=E2=94=80=E2=94=80=E2=94=80=E2=94= =AC=E2=94=80=E2=94=80=E2=94=80=E2=94=80=E2=94=80=E2=94=80=E2=94=80=E2=94=80= =E2=94=80=E2=94=80=E2=94=80=E2=94=80=E2=94=80=E2=94=80=E2=94=80=E2=94=80=E2= =94=AC=E2=94=80=E2=94=80=E2=94=80=E2=94=AC=E2=94=80=E2=94=80=E2=94=80=E2=94= =80=E2=94=80=E2=94=80=E2=94=80=E2=94=80=E2=94=80=E2=94=90 > > =E2=94=94=E2=94=80=E2=96=BA=E2=94=82Sr=E2=94=827'h7E RnW=3D1 =E2=94= =82ACK=E2=94=8248bit UID BCR DCR=E2=94=82Assign 7bit Addr=E2=94=82PAR=E2=94= =82 ACK/NACK=E2=94=82 > > =E2=94=94=E2=94=80=E2=94=80=E2=94=B4=E2=94=80=E2=94=80=E2=94=80=E2= =94=80=E2=94=80=E2=94=80=E2=94=80=E2=94=80=E2=94=80=E2=94=80=E2=94=80=E2=94= =80=E2=94=80=E2=94=B4=E2=94=80=E2=94=80=E2=94=80=E2=94=B4=E2=94=80=E2=94=80= =E2=94=80=E2=94=80=E2=94=80=E2=94=80=E2=94=80=E2=94=80=E2=94=80=E2=94=80=E2= =94=80=E2=94=80=E2=94=80=E2=94=80=E2=94=80=E2=94=80=E2=94=80=E2=94=B4=E2=94= =80=E2=94=80=E2=94=80=E2=94=80=E2=94=80=E2=94=80=E2=94=80=E2=94=80=E2=94=80= =E2=94=80=E2=94=80=E2=94=80=E2=94=80=E2=94=80=E2=94=80=E2=94=80=E2=94=B4=E2= =94=80=E2=94=80=E2=94=80=E2=94=B4=E2=94=80=E2=94=80=E2=94=80=E2=94=80=E2=94= =80=E2=94=80=E2=94=80=E2=94=80=E2=94=80=E2=94=98 > > > > Some master controllers (such as HCI) need to prepare the entire above > > transaction before sending it out to the I3C bus. This means that a 7-b= it > > dynamic address needs to be allocated before knowing the target device's > > UID information. > > > > However, some I3C targets may request specific addresses (called as > > "init_dyn_addr"), which is typically specified by the DT-'s > > assigned-address property. Lower addresses having higher IBI priority. = If > > it is available, i3c_bus_get_free_addr() preferably return a free addre= ss > > that is not in the list of desired addresses (called as "init_dyn_addr"= ). > > This allows the device with the "init_dyn_addr" to switch to its > > "init_dyn_addr" when it hot-joins the I3C bus. Otherwise, if the > > "init_dyn_addr" is already in use by another I3C device, the target dev= ice > > will not be able to switch to its desired address. > > > > If the previous step fails, fallback returning one of the remaining > > unassigned address, regardless of its state in the desired list. > > > > Signed-off-by: Frank Li > > --- =20 >=20 > Miquel: >=20 > Do you have a chance to check this patch again? No worries, it's in my todo list ;) Thanks, Miqu=C3=A8l