From: ming.qian@oss.nxp.com
To: mchehab@kernel.org, hverkuil-cisco@xs4all.nl
Cc: yunkec@google.com, nicolas@ndufresne.ca, s.hauer@pengutronix.de,
kernel@pengutronix.de, festevam@gmail.com, linux-imx@nxp.com,
xiahong.bao@nxp.com, ming.zhou@nxp.com, eagle.zhou@nxp.com,
tao.jiang_2@nxp.com, ming.qian@nxp.com, imx@lists.linux.dev,
linux-media@vger.kernel.org, linux-kernel@vger.kernel.org,
linux-arm-kernel@lists.infradead.org
Subject: [PATCH v5 0/4] Add video encoder ROI ctrls
Date: Wed, 6 Nov 2024 15:07:48 +0900 [thread overview]
Message-ID: <20241106060752.205074-1-ming.qian@oss.nxp.com> (raw)
From: Ming Qian <ming.qian@oss.nxp.com>
Hi,
This patch set implements region of interest (ROI) ctrls for video
encoder.
One video encoder IP may support the following two ROI configurations or
one of them:
1. configure ROI as a rectangular region, and set a delta QP parameter.
2. configure ROI as a rectangular region, and set a priority parameter.
3. configure ROI as a QP map as an array. Each value represents the delta QP
of a block in raster scan order. The block size is determined by
the specific IP.
4. configure ROI as a QP map as an array. Each value represents the absolute QP
of a block in raster scan order. The block size is determined by
the specific IP.
To achieve this, I made the following change:
1. I reuse the type V4L2_CTRL_TYPE_RECT that is defined in the UVC ROI patchset
2. Define a ctrl V4L2_CID_MPEG_VIDEO_ROI_MODE to choose ROI configuration
3. Define some ctrl to configure ROI
4. Define a ctrl V4L2_CID_MPEG_VIDEO_ROI_BLOCK_SIZE to query block size
I referred the patchset "Implement UVC v1.5 ROI" (https://lwn.net/Articles/953532/)
and pick some patches from it.
changelog:
v5
- Improve description in documentation as Hans's comments
- Improve the rect ctrl logging notation as (x,y)/WxH
v4
- Improve description in documentation as Hans's comments
v3
- Drop the type V4L2_CTRL_TYPE_REGION
- Split the compound control into 2 ctrls
- Define 4 ROI mode
v2
- export symbol of v4l2_ctrl_type_op_minimum
- export symbol of v4l2_ctrl_type_op_maximum
Hans Verkuil (1):
media: v4l2-ctrls: add support for V4L2_CTRL_WHICH_MIN/MAX_VAL
Ming Qian (1):
media: v4l2-ctrls: Add video encoder ROI ctrls
Yunke Cao (2):
media: v4l2_ctrl: Add V4L2_CTRL_TYPE_RECT
media: vivid: Add an rectangle control
.../media/v4l/ext-ctrls-codec.rst | 136 ++++++++++++++
.../media/v4l/vidioc-g-ext-ctrls.rst | 26 ++-
.../media/v4l/vidioc-queryctrl.rst | 14 ++
.../media/videodev2.h.rst.exceptions | 4 +
drivers/media/i2c/imx214.c | 4 +-
.../media/platform/qcom/venus/venc_ctrls.c | 9 +-
.../media/test-drivers/vivid/vivid-ctrls.c | 34 ++++
drivers/media/v4l2-core/v4l2-ctrls-api.c | 54 ++++--
drivers/media/v4l2-core/v4l2-ctrls-core.c | 168 +++++++++++++++---
drivers/media/v4l2-core/v4l2-ctrls-defs.c | 46 +++++
drivers/media/v4l2-core/v4l2-ioctl.c | 4 +-
include/media/v4l2-ctrls.h | 62 ++++++-
include/uapi/linux/v4l2-controls.h | 16 ++
include/uapi/linux/videodev2.h | 5 +
14 files changed, 533 insertions(+), 49 deletions(-)
--
2.43.0-rc1
next reply other threads:[~2024-11-06 6:08 UTC|newest]
Thread overview: 5+ messages / expand[flat|nested] mbox.gz Atom feed top
2024-11-06 6:07 ming.qian [this message]
2024-11-06 6:07 ` [PATCH v5 1/4] media: v4l2_ctrl: Add V4L2_CTRL_TYPE_RECT ming.qian
2024-11-06 6:07 ` [PATCH v5 2/4] media: v4l2-ctrls: add support for V4L2_CTRL_WHICH_MIN/MAX_VAL ming.qian
2024-11-06 6:07 ` [PATCH v5 3/4] media: vivid: Add an rectangle control ming.qian
2024-11-06 6:07 ` [PATCH v5 4/4] media: v4l2-ctrls: Add video encoder ROI ctrls ming.qian
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20241106060752.205074-1-ming.qian@oss.nxp.com \
--to=ming.qian@oss.nxp.com \
--cc=eagle.zhou@nxp.com \
--cc=festevam@gmail.com \
--cc=hverkuil-cisco@xs4all.nl \
--cc=imx@lists.linux.dev \
--cc=kernel@pengutronix.de \
--cc=linux-arm-kernel@lists.infradead.org \
--cc=linux-imx@nxp.com \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-media@vger.kernel.org \
--cc=mchehab@kernel.org \
--cc=ming.qian@nxp.com \
--cc=ming.zhou@nxp.com \
--cc=nicolas@ndufresne.ca \
--cc=s.hauer@pengutronix.de \
--cc=tao.jiang_2@nxp.com \
--cc=xiahong.bao@nxp.com \
--cc=yunkec@google.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox