From: Thomas Zimmermann <tzimmermann@suse.de>
To: maarten.lankhorst@linux.intel.com, mripard@kernel.org,
airlied@gmail.com, simona@ffwll.ch, p.zabel@pengutronix.de
Cc: dri-devel@lists.freedesktop.org, imx@lists.linux.dev,
Thomas Zimmermann <tzimmermann@suse.de>
Subject: [PATCH 5/5] drm/gem-vram: Use default pitch and size for dumb buffers
Date: Mon, 11 Nov 2024 15:23:07 +0100 [thread overview]
Message-ID: <20241111143114.631690-6-tzimmermann@suse.de> (raw)
In-Reply-To: <20241111143114.631690-1-tzimmermann@suse.de>
Use the pitch and size values stored in the args parameter for
allocating a dumb buffer in drm_gem_vram_dumb_create(). Inline
the relevant code from drm_gem_vram_fill_create_dumb(), but
without the size computation. This value comes from
drm_mode_create_dumb(). Align the pitch to a multiple of 8.
Only hibmc and vboxvideo use gem-vram. Hibmc invokes the call to
drm_gem_vram_fill_create_dumb() directly and is therefore not affected.
Signed-off-by: Thomas Zimmermann <tzimmermann@suse.de>
---
drivers/gpu/drm/drm_gem_vram_helper.c | 24 +++++++++++++++++++++++-
1 file changed, 23 insertions(+), 1 deletion(-)
diff --git a/drivers/gpu/drm/drm_gem_vram_helper.c b/drivers/gpu/drm/drm_gem_vram_helper.c
index 22b1fe9c03b8..0d1a9cce47e7 100644
--- a/drivers/gpu/drm/drm_gem_vram_helper.c
+++ b/drivers/gpu/drm/drm_gem_vram_helper.c
@@ -6,6 +6,7 @@
#include <drm/drm_debugfs.h>
#include <drm/drm_device.h>
#include <drm/drm_drv.h>
+#include <drm/drm_dumb_buffers.h>
#include <drm/drm_file.h>
#include <drm/drm_framebuffer.h>
#include <drm/drm_gem_atomic_helper.h>
@@ -582,10 +583,31 @@ int drm_gem_vram_driver_dumb_create(struct drm_file *file,
struct drm_device *dev,
struct drm_mode_create_dumb *args)
{
+ struct drm_gem_vram_object *gbo;
+ int ret;
+
if (WARN_ONCE(!dev->vram_mm, "VRAM MM not initialized"))
return -EINVAL;
- return drm_gem_vram_fill_create_dumb(file, dev, 0, 0, args);
+ ret = drm_mode_align_dumb(args, 8, 0);
+ if (ret)
+ return ret;
+
+ gbo = drm_gem_vram_create(dev, args->size, 0);
+ if (IS_ERR(gbo))
+ return PTR_ERR(gbo);
+
+ ret = drm_gem_handle_create(file, &gbo->bo.base, &args->handle);
+ if (ret)
+ goto err_drm_gem_object_put;
+
+ drm_gem_object_put(&gbo->bo.base);
+
+ return 0;
+
+err_drm_gem_object_put:
+ drm_gem_object_put(&gbo->bo.base);
+ return ret;
}
EXPORT_SYMBOL(drm_gem_vram_driver_dumb_create);
--
2.47.0
prev parent reply other threads:[~2024-11-11 14:31 UTC|newest]
Thread overview: 6+ messages / expand[flat|nested] mbox.gz Atom feed top
2024-11-11 14:23 [PATCH 0/5] drm/dumb-buffers: Fix and improve buffer-size calculation Thomas Zimmermann
2024-11-11 14:23 ` [PATCH 1/5] drm/dumb-buffers: Sanitize output on errors Thomas Zimmermann
2024-11-11 14:23 ` [PATCH 2/5] drm/dumb-buffers: Fix size calculations and set default pitch and size Thomas Zimmermann
2024-11-11 14:23 ` [PATCH 3/5] drm/gem-dma: Use aligned default pitch and size for dumb buffers Thomas Zimmermann
2024-11-11 14:23 ` [PATCH 4/5] drm/gem-shmem: " Thomas Zimmermann
2024-11-11 14:23 ` Thomas Zimmermann [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20241111143114.631690-6-tzimmermann@suse.de \
--to=tzimmermann@suse.de \
--cc=airlied@gmail.com \
--cc=dri-devel@lists.freedesktop.org \
--cc=imx@lists.linux.dev \
--cc=maarten.lankhorst@linux.intel.com \
--cc=mripard@kernel.org \
--cc=p.zabel@pengutronix.de \
--cc=simona@ffwll.ch \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox