From: Fabio Estevam <festevam@gmail.com>
To: shawnguo@kernel.org
Cc: linux@armlinux.org.uk, s.hauer@pengutronix.de,
linus.walleij@linaro.org, esben@geanix.com,
linux-arm-kernel@lists.infradead.org, imx@lists.linux.dev,
linux@roeck-us.net, arnd@arndb.de,
Fabio Estevam <festevam@denx.de>
Subject: [PATCH v2] ARM: imx: Re-introduce the PINCTRL selection
Date: Wed, 27 Nov 2024 16:06:05 -0300 [thread overview]
Message-ID: <20241127190605.1367157-1-festevam@gmail.com> (raw)
From: Fabio Estevam <festevam@denx.de>
Since commit 17d210018914 ("ARM: imx: Allow user to disable pinctrl"),
the CONFIG_PINCTRL option is no longer implicitly selected, causing
several i.MX SoC pinctrl drivers no longer getting selected by default.
This causes boot regressions on the ARMv4, ARMv5, ARMv6 and ARMv7
i.MX SoCs.
Fix it by selecting CONFIG_PINCTRL as before.
This defeats the purpose of 7d210018914 ("ARM: imx: Allow user to disable
pinctrl"), but it is the less invasive fix for the boot regressions.
The attempt to build Layerscape without pinctrl can still be explored
later as suggested by Arnd:
"Overall, my best advice here is still to not change the way
i.MX pinctrl works at all, but just fix Layerscape to not depend
on i.MX. The reason for the 'select' here is clearly that the
i.MX machines would fail to boot without pinctrl, and changing
that because of Layerscape seems backwards."
Fixes: 17d210018914 ("ARM: imx: Allow user to disable pinctrl")
Reported-by: Guenter Roeck <linux@roeck-us.net>
Closes: https://lore.kernel.org/linux-arm-kernel/49ff070a-ce67-42d7-84ec-8b54fd7e9742@roeck-us.net/
Signed-off-by: Fabio Estevam <festevam@denx.de>
---
Changes since v1:
- Reintroduce "select PINCTRL" as a minimal fix for 6.13-rc.
arch/arm/mach-imx/Kconfig | 1 +
1 file changed, 1 insertion(+)
diff --git a/arch/arm/mach-imx/Kconfig b/arch/arm/mach-imx/Kconfig
index e4fe059cd861..dc47b2312127 100644
--- a/arch/arm/mach-imx/Kconfig
+++ b/arch/arm/mach-imx/Kconfig
@@ -6,6 +6,7 @@ menuconfig ARCH_MXC
select CLKSRC_IMX_GPT
select GENERIC_IRQ_CHIP
select GPIOLIB
+ select PINCTRL
select PM_OPP if PM
select SOC_BUS
select SRAM
--
2.34.1
next reply other threads:[~2024-11-27 19:06 UTC|newest]
Thread overview: 8+ messages / expand[flat|nested] mbox.gz Atom feed top
2024-11-27 19:06 Fabio Estevam [this message]
2024-11-27 19:31 ` [PATCH v2] ARM: imx: Re-introduce the PINCTRL selection Arnd Bergmann
2024-11-27 21:05 ` Esben Haabendal
2024-11-27 21:38 ` Linus Walleij
2024-11-27 23:13 ` Guenter Roeck
2024-11-29 10:15 ` Linus Walleij
2024-11-29 11:18 ` Fabio Estevam
2024-11-29 22:53 ` Linus Walleij
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20241127190605.1367157-1-festevam@gmail.com \
--to=festevam@gmail.com \
--cc=arnd@arndb.de \
--cc=esben@geanix.com \
--cc=festevam@denx.de \
--cc=imx@lists.linux.dev \
--cc=linus.walleij@linaro.org \
--cc=linux-arm-kernel@lists.infradead.org \
--cc=linux@armlinux.org.uk \
--cc=linux@roeck-us.net \
--cc=s.hauer@pengutronix.de \
--cc=shawnguo@kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox