From: Jonathan Cameron <jic23@kernel.org>
To: Fabio Estevam <festevam@gmail.com>
Cc: Frank Li <Frank.Li@nxp.com>,
haibo.chen@nxp.com, imx@lists.linux.dev, lars@metafoo.de,
linux-iio@vger.kernel.org, linux-kernel@vger.kernel.org
Subject: Re: [PATCH v5 2/2] iio: adc: vf610_adc: limit i.MX6SX's channel number to 4
Date: Sat, 30 Nov 2024 20:21:53 +0000 [thread overview]
Message-ID: <20241130202153.7909f86a@jic23-huawei> (raw)
In-Reply-To: <CAOMZO5AVyubQUpEhm-oRb8bmAH=5w2TxTnuuvoY_+HLhpnBaTw@mail.gmail.com>
On Tue, 26 Nov 2024 16:56:23 -0300
Fabio Estevam <festevam@gmail.com> wrote:
> On Tue, Nov 26, 2024 at 4:53 PM Frank Li <Frank.Li@nxp.com> wrote:
>
> > + chip_info = device_get_match_data(dev);
> > + if (!chip_info)
>
> This NULL check is not needed.
>
> If the code entered probe(), a compatible was matched.
Whilst I don't feel strongly either way on this check, I've dropped it
and applied the patches to the testing branch of iio.git.
Thanks,
Jonathan
prev parent reply other threads:[~2024-11-30 20:22 UTC|newest]
Thread overview: 4+ messages / expand[flat|nested] mbox.gz Atom feed top
2024-11-26 19:52 [PATCH v5 1/2] iio: adc: vf610_adc: use devm_* and dev_err_probe() to simple code Frank Li
2024-11-26 19:52 ` [PATCH v5 2/2] iio: adc: vf610_adc: limit i.MX6SX's channel number to 4 Frank Li
2024-11-26 19:56 ` Fabio Estevam
2024-11-30 20:21 ` Jonathan Cameron [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20241130202153.7909f86a@jic23-huawei \
--to=jic23@kernel.org \
--cc=Frank.Li@nxp.com \
--cc=festevam@gmail.com \
--cc=haibo.chen@nxp.com \
--cc=imx@lists.linux.dev \
--cc=lars@metafoo.de \
--cc=linux-iio@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox