Linux kernel and device drivers for NXP i.MX platforms
 help / color / mirror / Atom feed
From: "Peng Fan (OSS)" <peng.fan@oss.nxp.com>
To: Sudeep Holla <sudeep.holla@arm.com>,
	 Cristian Marussi <cristian.marussi@arm.com>,
	 Greg Kroah-Hartman <gregkh@linuxfoundation.org>,
	 Saravana Kannan <saravanak@google.com>,
	 Linus Walleij <linus.walleij@linaro.org>,
	 Dong Aisheng <aisheng.dong@nxp.com>,
	Fabio Estevam <festevam@gmail.com>,
	 Shawn Guo <shawnguo@kernel.org>, Jacky Bai <ping.bai@nxp.com>,
	 Pengutronix Kernel Team <kernel@pengutronix.de>,
	 Sascha Hauer <s.hauer@pengutronix.de>
Cc: arm-scmi@vger.kernel.org, linux-arm-kernel@lists.infradead.org,
	 linux-kernel@vger.kernel.org, linux-gpio@vger.kernel.org,
	 imx@lists.linux.dev, Peng Fan <peng.fan@nxp.com>
Subject: [PATCH 2/4] firmware: arm_scmi: bus: Bypass setting fwnode for pinctrl
Date: Wed, 25 Dec 2024 16:20:45 +0800	[thread overview]
Message-ID: <20241225-scmi-fwdevlink-v1-2-e9a3a5341362@nxp.com> (raw)
In-Reply-To: <20241225-scmi-fwdevlink-v1-0-e9a3a5341362@nxp.com>

From: Peng Fan <peng.fan@nxp.com>

pinctrl-scmi.c and pinctrl-imx-scmi.c, both use SCMI_PROTOCOL_PINCTRL.
If both drivers are built in, and the scmi device with name "pinctrl-imx"
is created earlier, and the fwnode device points to the scmi device,
non-i.MX platforms will never have the pinctrl supplier ready.

So bypass setting fwnode for scmi pinctrl devices that non
compatible with socs.

Signed-off-by: Peng Fan <peng.fan@nxp.com>
---
 drivers/firmware/arm_scmi/bus.c | 14 ++++++++++++++
 1 file changed, 14 insertions(+)

diff --git a/drivers/firmware/arm_scmi/bus.c b/drivers/firmware/arm_scmi/bus.c
index 12190d4dabb65484543044b4424fbe3b67245466..87665b09c8ff492953c8300f80ed73eab6cce4fd 100644
--- a/drivers/firmware/arm_scmi/bus.c
+++ b/drivers/firmware/arm_scmi/bus.c
@@ -345,6 +345,11 @@ static void __scmi_device_destroy(struct scmi_device *scmi_dev)
 	device_unregister(&scmi_dev->dev);
 }
 
+static const char * const scmi_pinctrl_imx_lists[] = {
+	"fsl,imx95",
+	NULL
+};
+
 static int
 __scmi_device_set_node(struct scmi_device *scmi_dev, struct device_node *np,
 		       int protocol, const char *name)
@@ -353,6 +358,15 @@ __scmi_device_set_node(struct scmi_device *scmi_dev, struct device_node *np,
 	if ((protocol == SCMI_PROTOCOL_PERF) && !strcmp(name, "cpufreq"))
 		return 0;
 
+	if (protocol == SCMI_PROTOCOL_PINCTRL) {
+		if (!strcmp(name, "pinctrl") &&
+		    of_machine_compatible_match(scmi_pinctrl_imx_lists))
+			return 0;
+		if (!strcmp(name, "pinctrl-imx") &&
+		    !of_machine_compatible_match(scmi_pinctrl_imx_lists))
+			return 0;
+	}
+
 	device_set_node(&scmi_dev->dev, of_fwnode_handle(np));
 
 	return 0;

-- 
2.37.1


  parent reply	other threads:[~2024-12-25  8:21 UTC|newest]

Thread overview: 50+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2024-12-25  8:20 [PATCH 0/4] scmi: Bypass set fwnode to address devlink issue Peng Fan (OSS)
2024-12-25  8:20 ` [PATCH 1/4] firmware: arm_scmi: bus: Bypass setting fwnode for scmi cpufreq Peng Fan (OSS)
2024-12-27 15:13   ` Sudeep Holla
2024-12-30  2:05     ` Peng Fan
2024-12-31 18:07     ` Cristian Marussi
2025-01-02  7:38       ` Peng Fan
2025-01-02 17:06         ` Cristian Marussi
2025-01-06  4:37           ` Peng Fan
2025-02-11 17:13   ` Sudeep Holla
2025-02-12  7:01     ` Peng Fan
2025-02-12 10:48       ` Sudeep Holla
2025-02-13  8:03         ` Saravana Kannan
2025-02-13 20:23           ` Cristian Marussi
2025-02-18  1:09             ` Peng Fan
2025-02-18 10:24               ` Sudeep Holla
2025-02-18 13:36                 ` Peng Fan
2025-02-19 10:17                   ` Sudeep Holla
2025-02-20  0:59                     ` Peng Fan
2025-03-10  9:29                       ` Sudeep Holla
2025-03-10 10:45                         ` Peng Fan
2025-03-10 11:59                           ` Sudeep Holla
2025-03-10 13:41                             ` Sudeep Holla
2025-03-11  8:36                               ` Peng Fan
2025-03-11 11:12                                 ` Peng Fan
2025-03-11 11:23                                   ` Sudeep Holla
2025-03-12 10:52                                     ` Sudeep Holla
2025-03-12 11:28                                       ` Sudeep Holla
2025-03-13  5:23                                         ` Peng Fan
2025-04-09  3:50                                           ` Peng Fan
2025-04-09 11:14                                             ` Sudeep Holla
2025-04-17 14:26                                               ` Sudeep Holla
2025-04-20 14:09                                                 ` Peng Fan
2025-04-22 10:16                                                   ` Sudeep Holla
2025-06-20  3:58                                                     ` Peng Fan
2024-12-25  8:20 ` Peng Fan (OSS) [this message]
2024-12-27 15:28   ` [PATCH 2/4] firmware: arm_scmi: bus: Bypass setting fwnode for pinctrl Sudeep Holla
2024-12-30  2:08     ` Peng Fan
2024-12-31 18:16     ` Cristian Marussi
2025-01-06  4:41       ` Peng Fan
2025-01-14  8:31         ` Peng Fan
2025-01-14 10:07           ` Cristian Marussi
2025-01-15  7:22             ` Peng Fan
2024-12-31 18:13   ` Cristian Marussi
2024-12-25  8:20 ` [PATCH 3/4] pinctrl: scmi: Check fwnode instead of machine compatible Peng Fan (OSS)
2024-12-27 15:30   ` Sudeep Holla
2024-12-31 18:18     ` Cristian Marussi
2025-01-02  7:11       ` Peng Fan
2024-12-25  8:20 ` [PATCH 4/4] pinctrl: freescale: " Peng Fan (OSS)
2024-12-27 17:06 ` [PATCH 0/4] scmi: Bypass set fwnode to address devlink issue Linus Walleij
2024-12-30  2:12   ` Peng Fan

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20241225-scmi-fwdevlink-v1-2-e9a3a5341362@nxp.com \
    --to=peng.fan@oss.nxp.com \
    --cc=aisheng.dong@nxp.com \
    --cc=arm-scmi@vger.kernel.org \
    --cc=cristian.marussi@arm.com \
    --cc=festevam@gmail.com \
    --cc=gregkh@linuxfoundation.org \
    --cc=imx@lists.linux.dev \
    --cc=kernel@pengutronix.de \
    --cc=linus.walleij@linaro.org \
    --cc=linux-arm-kernel@lists.infradead.org \
    --cc=linux-gpio@vger.kernel.org \
    --cc=linux-kernel@vger.kernel.org \
    --cc=peng.fan@nxp.com \
    --cc=ping.bai@nxp.com \
    --cc=s.hauer@pengutronix.de \
    --cc=saravanak@google.com \
    --cc=shawnguo@kernel.org \
    --cc=sudeep.holla@arm.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox