From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from foss.arm.com (foss.arm.com [217.140.110.172]) by smtp.subspace.kernel.org (Postfix) with ESMTP id 4E451320B for ; Fri, 27 Dec 2024 15:30:42 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=217.140.110.172 ARC-Seal:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1735313443; cv=none; b=Kgaz7UMINO5Mhu31Zd7btEwpmJQTyr8m7c5JsyqQWx6jZxXFG1JlRX1nFg57u9AmY4gp1GBVzUWKup0f/T9ZgKa/C/WM6HWDBuhymAUeiZjlT/MOrnkbInXewcjm1WyaZrYYFCaUiOJdD/LdB5PCd3p8EiiFW4OezM0tjYTVLkI= ARC-Message-Signature:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1735313443; c=relaxed/simple; bh=/8hBdE55DZD3vLmo/lyPZX8RqUjMPoV5jOOztNg3cv4=; h=Date:From:To:Cc:Subject:Message-ID:References:MIME-Version: Content-Type:Content-Disposition:In-Reply-To; b=I5F0eM+LjaSGAHhruzKk7eyzxitq4G6sGh8eb4wAW6TbfEPohoFv1Qc5gVWA7CXAst/8PHTxZBkosQJpH5l0pUgqrOPFU4y7PaUPetuXNdl8XSmz9tzvnFBMdTA2741Xz4BxCTbuEeJC6uokFJk1ShpMuNq5g6wlBoR7DuMhV3I= ARC-Authentication-Results:i=1; smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=arm.com; spf=pass smtp.mailfrom=arm.com; arc=none smtp.client-ip=217.140.110.172 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=arm.com Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=arm.com Received: from usa-sjc-imap-foss1.foss.arm.com (unknown [10.121.207.14]) by usa-sjc-mx-foss1.foss.arm.com (Postfix) with ESMTP id E406D1E2F; Fri, 27 Dec 2024 07:31:09 -0800 (PST) Received: from bogus (unknown [10.57.92.15]) by usa-sjc-imap-foss1.foss.arm.com (Postfix) with ESMTPSA id E902B3F673; Fri, 27 Dec 2024 07:30:37 -0800 (PST) Date: Fri, 27 Dec 2024 15:30:20 +0000 From: Sudeep Holla To: "Peng Fan (OSS)" Cc: Cristian Marussi , Greg Kroah-Hartman , Saravana Kannan , Sudeep Holla , Linus Walleij , Dong Aisheng , Fabio Estevam , Shawn Guo , Jacky Bai , Pengutronix Kernel Team , Sascha Hauer , arm-scmi@vger.kernel.org, linux-arm-kernel@lists.infradead.org, linux-kernel@vger.kernel.org, linux-gpio@vger.kernel.org, imx@lists.linux.dev, Peng Fan Subject: Re: [PATCH 3/4] pinctrl: scmi: Check fwnode instead of machine compatible Message-ID: <20241227153020.hl6lysid75yquca7@bogus> References: <20241225-scmi-fwdevlink-v1-0-e9a3a5341362@nxp.com> <20241225-scmi-fwdevlink-v1-3-e9a3a5341362@nxp.com> Precedence: bulk X-Mailing-List: imx@lists.linux.dev List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <20241225-scmi-fwdevlink-v1-3-e9a3a5341362@nxp.com> On Wed, Dec 25, 2024 at 04:20:46PM +0800, Peng Fan (OSS) wrote: > From: Peng Fan > > For the platform that not compatible with scmi pinctrl device, the > fwnode will not be set, so checking fwnode will make code simpler > and easy to maintain. > > Signed-off-by: Peng Fan > --- > drivers/pinctrl/pinctrl-scmi.c | 7 +------ > 1 file changed, 1 insertion(+), 6 deletions(-) > > diff --git a/drivers/pinctrl/pinctrl-scmi.c b/drivers/pinctrl/pinctrl-scmi.c > index df4bbcd7d1d59ac2c8ddc320dc10d702ad1ed5b2..aade6df77dbb2c391741e77c0aac3f029991e4bb 100644 > --- a/drivers/pinctrl/pinctrl-scmi.c > +++ b/drivers/pinctrl/pinctrl-scmi.c > @@ -505,11 +505,6 @@ static int pinctrl_scmi_get_pins(struct scmi_pinctrl *pmx, > return 0; > } > > -static const char * const scmi_pinctrl_blocklist[] = { > - "fsl,imx95", > - NULL > -}; > - > static int scmi_pinctrl_probe(struct scmi_device *sdev) > { > int ret; > @@ -521,7 +516,7 @@ static int scmi_pinctrl_probe(struct scmi_device *sdev) > if (!sdev->handle) > return -EINVAL; > > - if (of_machine_compatible_match(scmi_pinctrl_blocklist)) > + if (!dev->fwnode) I would prefer to see the blocklist to be explicit here rather than implicitly hiding it away with this change set. -- Regards, Sudeep