From: Janne Grunau <j@jannau.net>
To: Sasha Finkelstein <fnkl.kernel@gmail.com>
Cc: Sven Peter <sven@svenpeter.dev>,
Alyssa Rosenzweig <alyssa@rosenzweig.io>,
Rob Herring <robh@kernel.org>,
Krzysztof Kozlowski <krzk+dt@kernel.org>,
Conor Dooley <conor+dt@kernel.org>,
Hector Martin <marcan@marcan.st>,
Ulf Hansson <ulf.hansson@linaro.org>,
Mauro Carvalho Chehab <mchehab@kernel.org>,
Shawn Guo <shawnguo@kernel.org>,
Sascha Hauer <s.hauer@pengutronix.de>,
Pengutronix Kernel Team <kernel@pengutronix.de>,
Fabio Estevam <festevam@gmail.com>,
asahi@lists.linux.dev, linux-arm-kernel@lists.infradead.org,
devicetree@vger.kernel.org, linux-kernel@vger.kernel.org,
linux-pm@vger.kernel.org, linux-media@vger.kernel.org,
imx@lists.linux.dev, Eileen Yoon <eyn@gmx.com>,
Asahi Lina <lina@asahilina.net>
Subject: Re: [PATCH 4/5] media: apple: Add Apple ISP driver
Date: Sun, 23 Feb 2025 10:03:09 +0100 [thread overview]
Message-ID: <20250223090309.GA430621@robin.jannau.net> (raw)
In-Reply-To: <CAMT+MTR4yPzC-NBLT6uLhveHFDWpwwn=hUzU6=WDc73+UVEMwQ@mail.gmail.com>
On Sun, Feb 23, 2025 at 09:48:30AM +0100, Sasha Finkelstein wrote:
> On Wed, 19 Feb 2025 at 12:34, Janne Grunau <j@jannau.net> wrote:
> > > + while (maps < end) {
> > > + maps++;
> > > + maps = of_translate_dma_region(dev->of_node, maps, &heap_base,
> > > + &heap_size);
> > > + }
> >
> > The hand-rolled reserved memory parsing looks like it can be replaced
> > with of_iommu_get_resv_region();
>
> I have looked into it, and `of_iommu_get_resv_region` does the wrong
> thing. We fill out `reg`, and it grabs that instead of `iommu-addresses`.
Downstream commit 704ace01cd3c4 [0] ("iommu: Add IOMMU_RESV_TRANSLATED
for non 1:1 mapped reserved regions") adds device virtual addresses to
struct iommu_resv_region. Sorry for the added dependency but it is
required anyway for the isp to work.
ciao Janne
[0] https://github.com/AsahiLinux/linux/commit/704ace01cd3c423b1e2492f0777d9c4c0f3404d8
next prev parent reply other threads:[~2025-02-23 9:03 UTC|newest]
Thread overview: 21+ messages / expand[flat|nested] mbox.gz Atom feed top
2025-02-19 9:26 [PATCH 0/5] Driver for Apple ISP and cameras Sasha Finkelstein via B4 Relay
2025-02-19 9:26 ` [PATCH 1/5] dt-bindings: power: apple,pmgr-pwrstate: Add force-{disable,reset} properties Sasha Finkelstein via B4 Relay
2025-02-19 9:34 ` Krzysztof Kozlowski
2025-02-19 9:43 ` Sasha Finkelstein
2025-02-21 21:41 ` Rob Herring
2025-02-19 9:26 ` [PATCH 2/5] pmdomain: apple: Add force-disable/force-reset Sasha Finkelstein via B4 Relay
2025-02-19 9:26 ` [PATCH 3/5] media: dt-bindings: Add Apple ISP Sasha Finkelstein via B4 Relay
2025-02-19 9:37 ` Krzysztof Kozlowski
2025-02-19 9:54 ` Sasha Finkelstein
2025-02-19 10:53 ` Laurent Pinchart
2025-02-19 11:05 ` Sasha Finkelstein
2025-02-19 13:40 ` Laurent Pinchart
2025-02-19 15:36 ` Asahi Lina
2025-02-19 11:57 ` Janne Grunau
2025-02-19 13:44 ` Laurent Pinchart
2025-02-23 8:58 ` Krzysztof Kozlowski
2025-02-19 9:27 ` [PATCH 4/5] media: apple: Add Apple ISP driver Sasha Finkelstein via B4 Relay
2025-02-19 11:34 ` Janne Grunau
2025-02-23 8:48 ` Sasha Finkelstein
2025-02-23 9:03 ` Janne Grunau [this message]
2025-02-19 9:27 ` [PATCH 5/5] arm64: dts: apple: Add ISP nodes Sasha Finkelstein via B4 Relay
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20250223090309.GA430621@robin.jannau.net \
--to=j@jannau.net \
--cc=alyssa@rosenzweig.io \
--cc=asahi@lists.linux.dev \
--cc=conor+dt@kernel.org \
--cc=devicetree@vger.kernel.org \
--cc=eyn@gmx.com \
--cc=festevam@gmail.com \
--cc=fnkl.kernel@gmail.com \
--cc=imx@lists.linux.dev \
--cc=kernel@pengutronix.de \
--cc=krzk+dt@kernel.org \
--cc=lina@asahilina.net \
--cc=linux-arm-kernel@lists.infradead.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-media@vger.kernel.org \
--cc=linux-pm@vger.kernel.org \
--cc=marcan@marcan.st \
--cc=mchehab@kernel.org \
--cc=robh@kernel.org \
--cc=s.hauer@pengutronix.de \
--cc=shawnguo@kernel.org \
--cc=sven@svenpeter.dev \
--cc=ulf.hansson@linaro.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox