Linux kernel and device drivers for NXP i.MX platforms
 help / color / mirror / Atom feed
From: haibo.chen@nxp.com
To: mkl@pengutronix.de, mailhol.vincent@wanadoo.fr
Cc: haibo.chen@nxp.com, ciprianmarian.costea@oss.nxp.com,
	u.kleine-koenig@baylibre.com, fabio.estevam@nxp.com,
	festevam@gmail.com, linux-can@vger.kernel.org,
	linux-kernel@vger.kernel.org, stable@vger.kernel.org,
	imx@lists.linux.dev, han.xu@nxp.com
Subject: [PATCH v3 2/2] can: flexcan: disable transceiver during system PM
Date: Fri, 14 Mar 2025 19:01:45 +0800	[thread overview]
Message-ID: <20250314110145.899179-2-haibo.chen@nxp.com> (raw)
In-Reply-To: <20250314110145.899179-1-haibo.chen@nxp.com>

From: Haibo Chen <haibo.chen@nxp.com>

During system PM, if no wakeup requirement, disable transceiver to
save power.

Fixes: 4de349e786a3 ("can: flexcan: fix resume function")
Cc: stable@vger.kernel.org
Reviewed-by: Frank Li <frank.li@nxp.com>
Signed-off-by: Haibo Chen <haibo.chen@nxp.com>
---
Changes for V3:
 N/A

Changes for V2:
 - add return check for flexcan_transceiver_disable
 - disable transceiver if flexcan_chip_start() failed

---
 drivers/net/can/flexcan/flexcan-core.c | 11 ++++++++++-
 1 file changed, 10 insertions(+), 1 deletion(-)

diff --git a/drivers/net/can/flexcan/flexcan-core.c b/drivers/net/can/flexcan/flexcan-core.c
index d4d342d8f490..491f9548c7ae 100644
--- a/drivers/net/can/flexcan/flexcan-core.c
+++ b/drivers/net/can/flexcan/flexcan-core.c
@@ -2292,6 +2292,9 @@ static int __maybe_unused flexcan_suspend(struct device *device)
 				return err;
 
 			flexcan_chip_interrupts_disable(dev);
+			err = flexcan_transceiver_disable(priv);
+			if (err)
+				return err;
 
 			err = pinctrl_pm_select_sleep_state(device);
 			if (err)
@@ -2324,10 +2327,16 @@ static int __maybe_unused flexcan_resume(struct device *device)
 			if (err)
 				return err;
 
-			err = flexcan_chip_start(dev);
+			err = flexcan_transceiver_enable(priv);
 			if (err)
 				return err;
 
+			err = flexcan_chip_start(dev);
+			if (err) {
+				flexcan_transceiver_disable(priv);
+				return err;
+			}
+
 			flexcan_chip_interrupts_enable(dev);
 		}
 		priv->can.state = CAN_STATE_ERROR_ACTIVE;
-- 
2.34.1


  reply	other threads:[~2025-03-14 11:00 UTC|newest]

Thread overview: 3+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2025-03-14 11:01 [PATCH v3 1/2] can: flexcan: only change CAN state when link up in system PM haibo.chen
2025-03-14 11:01 ` haibo.chen [this message]
2025-03-14 12:27 ` Marc Kleine-Budde

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20250314110145.899179-2-haibo.chen@nxp.com \
    --to=haibo.chen@nxp.com \
    --cc=ciprianmarian.costea@oss.nxp.com \
    --cc=fabio.estevam@nxp.com \
    --cc=festevam@gmail.com \
    --cc=han.xu@nxp.com \
    --cc=imx@lists.linux.dev \
    --cc=linux-can@vger.kernel.org \
    --cc=linux-kernel@vger.kernel.org \
    --cc=mailhol.vincent@wanadoo.fr \
    --cc=mkl@pengutronix.de \
    --cc=stable@vger.kernel.org \
    --cc=u.kleine-koenig@baylibre.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox