From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from relay5-d.mail.gandi.net (relay5-d.mail.gandi.net [217.70.183.197]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id 4CD69206F23 for ; Tue, 18 Mar 2025 15:58:35 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=217.70.183.197 ARC-Seal:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1742313518; cv=none; b=tehphZy3x+opQb5LXSSctyHuCrYozCSoS5mSZ+QZGxxSmewGqc1RJIfMP+u1bfRTmHpM546FEoQzXHEJe98A1h2c1n9s/jJY6ZYWTk6X6Rbzm/LMdZLnRYsEW1C+sZ3zx0KCDa9mg4v70+aktPnm+en+qepo8hb4jjjk92mXAzg= ARC-Message-Signature:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1742313518; c=relaxed/simple; bh=oiLsLLlStK47sOZdC3VVn2G5zwWXnqET/C5jjC0qvmA=; h=Date:From:To:Cc:Subject:Message-ID:References:MIME-Version: Content-Type:Content-Disposition:In-Reply-To; b=KN7XdWO0945KK5kmdAwKdWv2w5Sv6po0Dzu6qol21q1mX1wmEsaeNdLtEHgi/hH2MfoFhG/VVJ3i3Yq8qqLU15SyBX61GmIk0BTIBKcdlNHaC1q4LoQsPDZvCaJ6dwWwQAhjfPXLaLBMMm6urgACymnYV4t9DiV4C2YMpbFmWnY= ARC-Authentication-Results:i=1; smtp.subspace.kernel.org; dmarc=pass (p=reject dis=none) header.from=bootlin.com; spf=pass smtp.mailfrom=bootlin.com; dkim=pass (2048-bit key) header.d=bootlin.com header.i=@bootlin.com header.b=l7+txS75; arc=none smtp.client-ip=217.70.183.197 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=reject dis=none) header.from=bootlin.com Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=bootlin.com Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=bootlin.com header.i=@bootlin.com header.b="l7+txS75" Received: by mail.gandi.net (Postfix) with ESMTPSA id 532C944338; Tue, 18 Mar 2025 15:58:32 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=bootlin.com; s=gm1; t=1742313514; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:cc:mime-version:mime-version:content-type:content-type: in-reply-to:in-reply-to:references:references; bh=fP4ry+VLHXbxhxlQCKXjcIOOhVgHzKoDLPahcV+SBW8=; b=l7+txS75TzzQJ7j92uC3S7/c6sUR3CfA5jujJbbhZz/oXe5isRcJz4X2F5qL6dbvoWTYBj ggOKABa3a9W6tiMG4hAWo1g0n3OWrpWU3LpEvK/aDaTC4v2p4wneOh5hIPgjKSxuihO7hp OTl8hgKCTVGm2fX3Mvb+Ue46JgaVeOl6OEso39CFOYKZ9K24H4ZsunzicHRJTAJLw2NlGb 7Lk6UdwO1UD/u/Gjp/iHmLcGA7XN4T8i+9UNt+Jhz04Uwfu/PMSFzIc7l9324gUTDaaqNm cx4mk9a5zkcfXlCTLrtPtCm2haiTRL+cJVQXu6vHb3aIn6u9xLyuhn82gaDDfg== Date: Tue, 18 Mar 2025 16:58:31 +0100 From: Alexandre Belloni To: Qasim Ijaz Cc: miquel.raynal@bootlin.com, Frank.Li@nxp.com, linux-i3c@lists.infradead.org, imx@lists.linux.dev, linux-kernel@vger.kernel.org Subject: Re: [PATCH v1 1/1] i3c: master: svc: Fix i3c_master_get_free_addr return check Message-ID: <202503181558316ef27a06@mail.local> References: <20250310023304.2335792-1-yschu@nuvoton.com> <174225158210.1593610.10018812780731849409.b4-ty@bootlin.com> Precedence: bulk X-Mailing-List: imx@lists.linux.dev List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: X-GND-State: clean X-GND-Score: 0 X-GND-Cause: gggruggvucftvghtrhhoucdtuddrgeefvddrtddtgddugedvkeeiucetufdoteggodetrfdotffvucfrrhhofhhilhgvmecuifetpfffkfdpucggtfgfnhhsuhgsshgtrhhisggvnecuuegrihhlohhuthemuceftddunecunecujfgurhepfffhvfevuffkfhggtggujgesthdtredttddtvdenucfhrhhomheptehlvgigrghnughrvgcuuegvlhhlohhnihcuoegrlhgvgigrnhgurhgvrdgsvghllhhonhhisegsohhothhlihhnrdgtohhmqeenucggtffrrghtthgvrhhnpeeijeefhfffkeejueehveeuveejvdelveejteduffehuedtffdufeejudffuedvtdenucffohhmrghinhepkhgvrhhnvghlrdhorhhgpdgsohhothhlihhnrdgtohhmnecukfhppedvrgdtudemtggsudegmeehheeimeejrgdttdemugdujeefmegsjegstdemjeeitgegmeefudefgeenucevlhhushhtvghrufhiiigvpedtnecurfgrrhgrmhepihhnvghtpedvrgdtudemtggsudegmeehheeimeejrgdttdemugdujeefmegsjegstdemjeeitgegmeefudefgedphhgvlhhopehlohgtrghlhhhoshhtpdhmrghilhhfrhhomheprghlvgigrghnughrvgdrsggvlhhlohhnihessghoohhtlhhinhdrtghomhdpnhgspghrtghpthhtohepiedprhgtphhtthhopehqrghsuggvvhdttdesghhmrghilhdrtghomhdprhgtphhtthhopehmihhquhgvlhdrrhgrhihnrghlsegsohhothhlihhnrdgtohhmpdhrtghpthhtohephfhrrghnkhdrnfhisehng ihprdgtohhmpdhrtghpthhtoheplhhinhhugidqiheftgeslhhishhtshdrihhnfhhrrgguvggrugdrohhrghdprhgtphhtthhopehimhigsehlihhsthhsrdhlihhnuhigrdguvghvpdhrtghpthhtoheplhhinhhugidqkhgvrhhnvghlsehvghgvrhdrkhgvrhhnvghlrdhorhhg X-GND-Sasl: alexandre.belloni@bootlin.com On 18/03/2025 14:51:49+0000, Qasim Ijaz wrote: > On Mon, Mar 17, 2025 at 11:46:29PM +0100, Alexandre Belloni wrote: > > On Mon, 10 Mar 2025 10:33:04 +0800, Stanley Chu wrote: > > > The return value of i3c_master_get_free_addr is assigned to a variable > > > with wrong type, so it can't be negative. Use a signed integer for the > > > return value. If the value is negative, break the process and propagate > > > the error code. > > > > > > This commit also fixes the uninitialized symbol 'dyn_addr', reported > > > by Smatch static checker. > > > > > > [...] > > > > Applied, thanks! > > > > [1/1] i3c: master: svc: Fix i3c_master_get_free_addr return check > > https://git.kernel.org/abelloni/c/d6cb667b8e15 > > > > Best regards, > > > > -- > > Alexandre Belloni, co-owner and COO, Bootlin > > Embedded Linux and Kernel engineering > > https://bootlin.com > > Hi Alexandre, > > I sent a fix for this issue on the 9th March, which is before the patch > Stanley sent which was sent on the 10th March. > > You can view my orignal patch here: > > https://lore.kernel.org/all/20250309164314.15039-1-qasdev00@gmail.com/ > The issue is that you then resent the patch with the same topic which superseded your original patch. But the resend was missing a blank line so I could not apply it immediately and I later applied the other one. -- Alexandre Belloni, co-owner and COO, Bootlin Embedded Linux and Kernel engineering https://bootlin.com