From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from relay4-d.mail.gandi.net (relay4-d.mail.gandi.net [217.70.183.196]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id 6F7C5266B62 for ; Wed, 9 Apr 2025 14:14:56 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=217.70.183.196 ARC-Seal:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1744208098; cv=none; b=XHOd4KAcBG3b0HmwUdJXV5NSZiJqDhbBDOnva2kog54L8aQOGl88Tvwyvo8xW8YrelT91tqjRyagGqpreyESanc021kcvIUb0gxz1Uzh0eLahqWJC8I0s6DOQt624ze+SKllE95UDH/ASVfFKfyHjmyErkEGlYs8MS3raP3Ppfo= ARC-Message-Signature:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1744208098; c=relaxed/simple; bh=hya6kzCYQiQ71aaCFHe80q4Y/3EjgCzGRkoayCtGRJI=; h=Date:From:To:Cc:Subject:Message-ID:In-Reply-To:References: MIME-Version:Content-Type; b=Gj1MNUbCTCWyvp+niduwBtSBBN5ZcHHU36P1qGfDipz30GzvKuWMZ835Qz4x/nh+XrNHMUgLkVw5heDsH+vXKNIxuQ6grFTxoIVGNeOe7olRLaX6fr8i+jLT5U+xrMmDbHbu/J7IOvk+sovZtPq2D+efyHVPGoq/hinDiMuInJE= ARC-Authentication-Results:i=1; smtp.subspace.kernel.org; dmarc=pass (p=reject dis=none) header.from=bootlin.com; spf=pass smtp.mailfrom=bootlin.com; dkim=pass (2048-bit key) header.d=bootlin.com header.i=@bootlin.com header.b=mZxItQWe; arc=none smtp.client-ip=217.70.183.196 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=reject dis=none) header.from=bootlin.com Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=bootlin.com Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=bootlin.com header.i=@bootlin.com header.b="mZxItQWe" Received: by mail.gandi.net (Postfix) with ESMTPSA id 567EC444F9; Wed, 9 Apr 2025 14:14:45 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=bootlin.com; s=gm1; t=1744208089; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:cc:mime-version:mime-version:content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references; bh=PLxwTHRi7+pphCiz5HHyw3cwRGM2mE+0rupeRS3R5Jc=; b=mZxItQWeYtS91WG0xrklvKrgMDJ4xi4zviw2Z6yvob6kxgVmrZ7m8Z3LZdFat82D5la9OK 4rqcNF2OZoXNsjUFcr2TMwdSoHdwIP18APId2aUrU7zRyzjehA8hOzcGb95U/CX7oqPQq1 uSodaepIui1Q7wXxR+AoPwQ6y+EDmpnh1vV1KNJID3sE0cB4l0ThgYrGplSm5L9T3MlGbD fCGkwYfM3QhVZuvSdatV3g5AihihEe9tOCKeX7Tdnx7In7Rop58FOygkXQuUyQsurThxKS i4e4LV/8a7sZ4qO2DCa2o8RtfomG2PP9gPcTSgcBW37KeEEqY0mqnUtLr+Xfgw== Date: Wed, 9 Apr 2025 16:14:44 +0200 From: Thomas Petazzoni To: Andrew Lunn Cc: Herve Codina , Greg Kroah-Hartman , "Rafael J. Wysocki" , Danilo Krummrich , Shawn Guo , Sascha Hauer , Pengutronix Kernel Team , Fabio Estevam , Michael Turquette , Stephen Boyd , Andi Shyti , Wolfram Sang , Peter Rosin , Derek Kiernan , Dragan Cvetic , Arnd Bergmann , Rob Herring , Saravana Kannan , Bjorn Helgaas , Mark Brown , Len Brown , Andy Shevchenko , Daniel Scally , Heikki Krogerus , Sakari Ailus , Wolfram Sang , Geert Uytterhoeven , linux-kernel@vger.kernel.org, imx@lists.linux.dev, linux-arm-kernel@lists.infradead.org, linux-clk@vger.kernel.org, linux-i2c@vger.kernel.org, devicetree@vger.kernel.org, linux-pci@vger.kernel.org, linux-spi@vger.kernel.org, linux-acpi@vger.kernel.org, Allan Nielsen , Horatiu Vultur , Steen Hegelund , Luca Ceresoli Subject: Re: [PATCH 15/16] misc: lan966x_pci: Add dtso nodes in order to support SFPs Message-ID: <20250409161444.6158d388@windsurf> In-Reply-To: References: <20250407145546.270683-1-herve.codina@bootlin.com> <20250407145546.270683-16-herve.codina@bootlin.com> <19f1a382-1b6b-42bd-a548-a1a5644c9a1b@lunn.ch> <20250408162603.02d6c3a1@bootlin.com> Organization: Bootlin X-Mailer: Claws Mail 4.3.0 (GTK 3.24.43; x86_64-redhat-linux-gnu) Precedence: bulk X-Mailing-List: imx@lists.linux.dev List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 Content-Type: text/plain; charset=US-ASCII Content-Transfer-Encoding: 7bit X-GND-State: clean X-GND-Score: -100 X-GND-Cause: gggruggvucftvghtrhhoucdtuddrgeefvddrtddtgddvtdeivdduucetufdoteggodetrfdotffvucfrrhhofhhilhgvmecuifetpfffkfdpucggtfgfnhhsuhgsshgtrhhisggvnecuuegrihhlohhuthemuceftddunecusecvtfgvtghiphhivghnthhsucdlqddutddtmdenucfjughrpeffhffvvefukfgjfhhoofggtgfgsehtjeertdertddvnecuhfhrohhmpefvhhhomhgrshcurfgvthgriiiiohhnihcuoehthhhomhgrshdrphgvthgriiiiohhnihessghoohhtlhhinhdrtghomheqnecuggftrfgrthhtvghrnhepledtgedvjeehgeetgfeufffglefhkedvfeduveeiieelteeliedtfefguefggffhnecuffhomhgrihhnpegsohhothhlihhnrdgtohhmnecukfhppedvrgdtudemtggsudelmeekleegsgemheehtddtmedvudgtvgemsggvheeimegrsgefvdemtggrrggvnecuvehluhhsthgvrhfuihiivgeptdenucfrrghrrghmpehinhgvthepvdgrtddumegtsgduleemkeelgegsmeehhedttdemvddutggvmegsvgehieemrggsfedvmegtrggrvgdphhgvlhhopeifihhnughsuhhrfhdpmhgrihhlfhhrohhmpehthhhomhgrshdrphgvthgriiiiohhnihessghoohhtlhhinhdrtghomhdpnhgspghrtghpthhtohepgedupdhrtghpthhtoheprghnughrvgifsehluhhnnhdrtghhpdhrtghpthhtohephhgvrhhvvgdrtghoughinhgrsegsohhothhlihhnrdgtohhmpdhrtghpthhtohepghhrvghgkhhhs ehlihhnuhigfhhouhhnuggrthhiohhnrdhorhhgpdhrtghpthhtoheprhgrfhgrvghlsehkvghrnhgvlhdrohhrghdprhgtphhtthhopegurghkrheskhgvrhhnvghlrdhorhhgpdhrtghpthhtohepshhhrgifnhhguhhosehkvghrnhgvlhdrohhrghdprhgtphhtthhopehsrdhhrghuvghrsehpvghnghhuthhrohhnihigrdguvgdprhgtphhtthhopehkvghrnhgvlhesphgvnhhguhhtrhhonhhigidruggv X-GND-Sasl: thomas.petazzoni@bootlin.com On Wed, 9 Apr 2025 16:04:51 +0200 Andrew Lunn wrote: > And you need some way to map the PCI ID to the correct .dtso file. > Maybe that is just a lookup table in the driver, or maybe you can pack > the .dtso file into a kernel module with the correct > MODULE_DEVICE_TABLE(pci, ...) so that PCI probing pulls in the > specific driver module with the .dtso, which via dependencies pulls in > the core driver which can actually make use of the .dtso? Well, check the already upstream driver: https://elixir.bootlin.com/linux/v6.13.7/source/drivers/misc/lan966x_pci.c It indeed binds on the PCI ID, and the driver bundles the .dtbo. Best regards, Thomas -- Thomas Petazzoni, co-owner and CEO, Bootlin Embedded Linux and Kernel engineering and training https://bootlin.com