From: ming.qian@oss.nxp.com
To: mchehab@kernel.org, hverkuil-cisco@xs4all.nl
Cc: nicolas@ndufresne.ca, sebastian.fricke@collabora.com,
shawnguo@kernel.org, s.hauer@pengutronix.de,
kernel@pengutronix.de, festevam@gmail.com, linux-imx@nxp.com,
xiahong.bao@nxp.com, eagle.zhou@nxp.com, imx@lists.linux.dev,
linux-media@vger.kernel.org, linux-kernel@vger.kernel.org,
linux-arm-kernel@lists.infradead.org
Subject: [PATCH v3 2/4] media: docs: dev-decoder: Trigger dynamic source change for colorspace
Date: Fri, 18 Apr 2025 16:54:17 +0800 [thread overview]
Message-ID: <20250418085422.193-2-ming.qian@oss.nxp.com> (raw)
In-Reply-To: <20250418085422.193-1-ming.qian@oss.nxp.com>
From: Ming Qian <ming.qian@oss.nxp.com>
If colorspace changes, the client needs to renegotiate the pipeline,
otherwise the decoded frame may not be displayed correctly.
When a colorspace change in the stream, the decoder sends a
V4L2_EVENT_SOURCE_CHANGE event with changes set to
V4L2_EVENT_SRC_CH_COLORSPACE. After client receive this source change
event, then client can switch to the correct stream setting. And each
frame can be displayed properly.
So add colorspace as a trigger parameter for dynamic resolution change.
Signed-off-by: Ming Qian <ming.qian@oss.nxp.com>
---
v2
- Add V4L2_EVENT_SRC_CH_COLORSPACE for colorspace source change event
.../userspace-api/media/v4l/dev-decoder.rst | 17 +++++++++++++----
1 file changed, 13 insertions(+), 4 deletions(-)
diff --git a/Documentation/userspace-api/media/v4l/dev-decoder.rst b/Documentation/userspace-api/media/v4l/dev-decoder.rst
index ef8e8cf31f90..51d6da3eea4a 100644
--- a/Documentation/userspace-api/media/v4l/dev-decoder.rst
+++ b/Documentation/userspace-api/media/v4l/dev-decoder.rst
@@ -784,8 +784,8 @@ before the sequence started. Last of the buffers will have the
must check if there is any pending event and:
* if a ``V4L2_EVENT_SOURCE_CHANGE`` event with ``changes`` set to
- ``V4L2_EVENT_SRC_CH_RESOLUTION`` is pending, the `Dynamic Resolution
- Change` sequence needs to be followed,
+ ``V4L2_EVENT_SRC_CH_RESOLUTION`` or ``V4L2_EVENT_SRC_CH_COLORSPACE`` is pending,
+ the `Dynamic Resolution Change` sequence needs to be followed,
* if a ``V4L2_EVENT_EOS`` event is pending, the `End of Stream` sequence needs
to be followed.
@@ -932,13 +932,17 @@ reflected by corresponding queries):
* the minimum number of buffers needed for decoding,
-* bit-depth of the bitstream has been changed.
+* bit-depth of the bitstream has been changed,
+
+* colorspace of the bitstream has been changed.
Whenever that happens, the decoder must proceed as follows:
1. After encountering a resolution change in the stream, the decoder sends a
``V4L2_EVENT_SOURCE_CHANGE`` event with ``changes`` set to
- ``V4L2_EVENT_SRC_CH_RESOLUTION``.
+ ``V4L2_EVENT_SRC_CH_RESOLUTION``, or a colorspace change in the stream, the
+ decoder sends a ``V4L2_EVENT_SOURCE_CHANGE`` event with ``changes`` set to
+ ``V4L2_EVENT_SRC_CH_COLORSPACE``.
.. important::
@@ -946,6 +950,11 @@ Whenever that happens, the decoder must proceed as follows:
values applying to the stream after the resolution change, including
queue formats, selection rectangles and controls.
+.. note::
+ A ``V4L2_EVENT_SOURCE_CHANGE`` event with ``changes`` set to
+ ``V4L2_EVENT_SRC_CH_RESOLUTION`` will affect the allocation, but
+ ``V4L2_EVENT_SRC_CH_COLORSPACE`` won't.
+
2. The decoder will then process and decode all remaining buffers from before
the resolution change point.
--
2.43.0-rc1
next prev parent reply other threads:[~2025-04-18 8:55 UTC|newest]
Thread overview: 9+ messages / expand[flat|nested] mbox.gz Atom feed top
2025-04-18 8:54 [PATCH v3 1/4] media: v4l: dev-decoder: Add source change V4L2_EVENT_SRC_CH_COLORSPACE ming.qian
2025-04-18 8:54 ` ming.qian [this message]
2025-08-01 15:23 ` [PATCH v3 2/4] media: docs: dev-decoder: Trigger dynamic source change for colorspace Nicolas Dufresne
2025-11-03 1:45 ` Ming Qian(OSS)
2025-11-07 14:50 ` Nicolas Dufresne
2025-11-10 1:28 ` Ming Qian(OSS)
2025-04-18 8:54 ` [PATCH v3 3/4] media: amphion: Clear last_buffer_dequeued flag for DEC_CMD_START ming.qian
2025-04-18 8:54 ` [PATCH v3 4/4] media: amphion: Trigger source change if colorspace chagned ming.qian
2025-11-07 15:28 ` [PATCH v3 1/4] media: v4l: dev-decoder: Add source change V4L2_EVENT_SRC_CH_COLORSPACE Frank Li
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20250418085422.193-2-ming.qian@oss.nxp.com \
--to=ming.qian@oss.nxp.com \
--cc=eagle.zhou@nxp.com \
--cc=festevam@gmail.com \
--cc=hverkuil-cisco@xs4all.nl \
--cc=imx@lists.linux.dev \
--cc=kernel@pengutronix.de \
--cc=linux-arm-kernel@lists.infradead.org \
--cc=linux-imx@nxp.com \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-media@vger.kernel.org \
--cc=mchehab@kernel.org \
--cc=nicolas@ndufresne.ca \
--cc=s.hauer@pengutronix.de \
--cc=sebastian.fricke@collabora.com \
--cc=shawnguo@kernel.org \
--cc=xiahong.bao@nxp.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox