Re: [PATCH 1/1] Add check to ida_alloc()

[Peng Fan <peng.fan@oss.nxp.com>]

On Tue, May 13, 2025 at 08:37:05PM +0800, Yuanjun Gong wrote:
>Check the return value of ida_alloc() in case it fails.
>This is found by a static checker.
>
>Signed-off-by: Yuanjun Gong <ruc_gongyuanjun@163.com>
>---
> drivers/perf/fsl_imx9_ddr_perf.c | 3 +++
> 1 file changed, 3 insertions(+)
>
>diff --git a/drivers/perf/fsl_imx9_ddr_perf.c b/drivers/perf/fsl_imx9_ddr_perf.c
>index 843f163e6c33..86da027405cf 100644
>--- a/drivers/perf/fsl_imx9_ddr_perf.c
>+++ b/drivers/perf/fsl_imx9_ddr_perf.c
>@@ -790,6 +790,9 @@ static int ddr_perf_probe(struct platform_device *pdev)
> 	platform_set_drvdata(pdev, pmu);
> 
> 	pmu->id = ida_alloc(&ddr_ida, GFP_KERNEL);
>+	if (pmu->id < 0)
>+		return -ENOMEM;

I would write this as:
ret = ida_alloc(&ddr_ida, GFP_KERNEL);
if (ret < 0)
    return ret;

pmu->id = ret;

Regards,
Peng

>+
> 	name = devm_kasprintf(&pdev->dev, GFP_KERNEL, DDR_PERF_DEV_NAME "%d", pmu->id);
> 	if (!name) {
> 		ret = -ENOMEM;
>-- 
>2.25.1
>