From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from out-171.mta0.migadu.com (out-171.mta0.migadu.com [91.218.175.171]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id C0BDB1EB18E for ; Fri, 23 May 2025 20:34:27 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=91.218.175.171 ARC-Seal:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1748032469; cv=none; b=YQgCm15IOiDa2vw79iP0LSzwesbSjJ1VpPyY9s/3HxG4oex4wHxqGhExiK7cnaHdIE2uA3uiwxp8rA0hMmkD8u965R0zna+c/PBgiYSywz7BNYJQzNmLs2V2bI1lF42hi8Blsb1I9Zdxc2d2+/FZNxo8ne7lATSYWDC+IvrbURE= ARC-Message-Signature:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1748032469; c=relaxed/simple; bh=ueLlCxB7kHsCzS+FKlXBXUv0Z3mrWh3ka723h09LaP0=; h=From:To:Cc:Subject:Date:Message-Id:MIME-Version; b=tddxgsbdHTVr0Ejv2AHkxGrJvqv8n0SElPleJGhhemuEZw5iit8YkiKn6TI5AJ78Zcazc6kOQAq5zMlL6XTZk3y/KCXKVyvkRzOXk0+auCxATEU6p+MAhN7QLWWU1FQ8wr++OxOaH+rD1GRJZd+PopbdfFsPl5F4aU5knezDMzU= ARC-Authentication-Results:i=1; smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=linux.dev; spf=pass smtp.mailfrom=linux.dev; dkim=pass (1024-bit key) header.d=linux.dev header.i=@linux.dev header.b=HY9t8SWX; arc=none smtp.client-ip=91.218.175.171 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=linux.dev Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=linux.dev Authentication-Results: smtp.subspace.kernel.org; dkim=pass (1024-bit key) header.d=linux.dev header.i=@linux.dev header.b="HY9t8SWX" X-Report-Abuse: Please report any abuse attempt to abuse@migadu.com and include these headers. DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=linux.dev; s=key1; t=1748032465; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:cc:mime-version:mime-version: content-transfer-encoding:content-transfer-encoding; bh=Gkv6Aih8tfghpst1uOH/eaz1x5tS9HCDhXSpL/WAh5g=; b=HY9t8SWXCaYWANdK08qiXmlWPmaGNC2TNu0c9PqGHlgs7qquMJYGR4f26C5TJ49QNTrPaN NNi6GEc/DC11QFbl6ZQPIq1VHdUAKM3QT4V3ImX9e9aAS60+xhwMoFCg5uor09ghFB/5EI LkCDX/i3P4ksKXfWXFLLC7+cP8YIA0M= From: Sean Anderson To: netdev@vger.kernel.org, Andrew Lunn , "David S . Miller" , Eric Dumazet , Jakub Kicinski , Paolo Abeni , Russell King Cc: Lei Wei , Heiner Kallweit , Christian Marangi , Kory Maincent , Simon Horman , Daniel Golle , Vineeth Karumanchi , linux-kernel@vger.kernel.org, Sean Anderson , Alexandre Belloni , Claudiu Beznea , Claudiu Manoil , Conor Dooley , Ioana Ciornei , Jonathan Corbet , Krzysztof Kozlowski , Michal Simek , Nicolas Ferre , Radhey Shyam Pandey , Rob Herring , Rob Herring , Robert Hancock , Saravana Kannan , UNGLinuxDriver@microchip.com, Vladimir Oltean , devicetree@vger.kernel.org, imx@lists.linux.dev, linux-arm-kernel@lists.infradead.org, linux-doc@vger.kernel.org, linux-stm32@st-md-mailman.stormreply.com Subject: [net-next PATCH v5 00/10] Add PCS core support Date: Fri, 23 May 2025 16:33:29 -0400 Message-Id: <20250523203339.1993685-1-sean.anderson@linux.dev> Precedence: bulk X-Mailing-List: imx@lists.linux.dev List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 Content-Transfer-Encoding: 8bit X-Migadu-Flow: FLOW_OUT This series adds support for creating PCSs as devices on a bus with a driver (patch 3). As initial users, - The Lynx PCS (and all of its users) is converted to this system (patches 4-5) - The Xilinx PCS is broken out from the AXI Ethernet driver (patches 6-7) - The Cadence MACB driver is converted to support external PCSs (namely the Xilinx PCS) (patches 8-9). Care has been taken to ensure backwards-compatibility. The main source of this is that many PCS devices lack compatibles and get detected as PHYs. To address this, pcs_get_by_fwnode_compat allows drivers to edit the devicetree to add appropriate compatibles. There is another series [1] with the same goal by Christian Marangi. In comparison, I believe this series - Implements a simpler and more-robust method of PCS access. - Provides a more-direct upgrade path for existing MAC and PCS drivers. Sending v5 to run CI after rebasing; there are no other major changes. [1] https://lore.kernel.org/netdev/20250511201250.3789083-1-ansuelsmth@gmail.com/ Changes in v5: - Export get_phy_c22_id when it is used - Expose bind attributes, since there is no issue in doing so - Rebase onto net-next - Use MDIO_BUS instead of MDIO_DEVICE Changes in v4: - Add a note about the license - Adjust variable ordering in pcs_find_fwnode - Annotate pcs_wrapper.wrapped with __rcu - Fix PCS lookup functions missing ERR_PTR casts - Fix documentation for devm_pcs_register_full - Fix incorrect condition in pcs_post_config - Fix linking when PCS && !OF_DYNAMIC - Fix linking when PCS && OF_DYNAMIC && PHYLIB=m - Re-add documentation for axienet_xilinx_pcs_get that was accidentally removed - Reduce line lengths to under 80 characters - Remove unused dev parameter to pcs_put - Use a spinlock instead of a mutex to protect pcs_wrappers Changes in v3: - Add '>' modifier for paragraph to description - Adjust axienet_xilinx_pcs_get for changes to pcs_find_fwnode API - Drop patches destined for other trees, as they have either already been applied or are no longer necessary. - Edit description to reference clocks instead of resets - Remove support for #pcs-cells. Upon further investigation, the requested functionality can be accomplished by specifying the PCS's fwnode manually. - Select PCS_XILINX unconditionally Changes in v2: - Add fallbacks for pcs_get* and pcs_put - Add support for #pcs-cells - Change base compatible to just xlnx,pcs - Change compatible to just xlnx,pcs - Defer devicetree updates for another series - Drop #clock-cells description - Drop PCS_ALTERA_TSE which was accidentally added while rebasing - Move #clock-cells after compatible - Move update to macb_pcs_get_state to previous patch - Remove outdated comment - Remove second example - Remove unused variable - Remove unused variable lynx_properties - Rename pcs-modes to xlnx,pcs-modes - Reorder pcs_handle to come before suffix props - Reword commit message - Rework xilinx_pcs_validate to just clear out half-duplex modes instead of constraining modes based on the interface. Sean Anderson (9): dt-bindings: net: Add Xilinx PCS net: phylink: Support setting PCS link change callbacks net: pcs: Add subsystem net: pcs: lynx: Convert to an MDIO driver net: pcs: Add Xilinx PCS driver net: axienet: Convert to use PCS subsystem net: macb: Move most of mac_config to mac_prepare net: macb: Support external PCSs of: property: Add device link support for PCS Vladimir Oltean (1): net: dsa: ocelot: suppress PHY device scanning on the internal MDIO bus .../devicetree/bindings/net/xilinx,pcs.yaml | 114 +++ Documentation/networking/index.rst | 1 + Documentation/networking/kapi.rst | 4 + Documentation/networking/pcs.rst | 102 +++ MAINTAINERS | 8 + drivers/net/dsa/ocelot/Kconfig | 4 + drivers/net/dsa/ocelot/felix_vsc9959.c | 15 +- drivers/net/dsa/ocelot/seville_vsc9953.c | 16 +- drivers/net/ethernet/altera/Kconfig | 2 + drivers/net/ethernet/altera/altera_tse_main.c | 7 +- drivers/net/ethernet/cadence/macb.h | 1 + drivers/net/ethernet/cadence/macb_main.c | 229 ++++-- drivers/net/ethernet/freescale/dpaa/Kconfig | 2 +- drivers/net/ethernet/freescale/dpaa2/Kconfig | 3 + .../net/ethernet/freescale/dpaa2/dpaa2-mac.c | 11 +- drivers/net/ethernet/freescale/enetc/Kconfig | 2 + .../net/ethernet/freescale/enetc/enetc_pf.c | 8 +- .../net/ethernet/freescale/enetc/enetc_pf.h | 1 - .../freescale/enetc/enetc_pf_common.c | 4 +- drivers/net/ethernet/freescale/fman/Kconfig | 4 +- .../net/ethernet/freescale/fman/fman_memac.c | 25 +- drivers/net/ethernet/stmicro/stmmac/Kconfig | 3 + .../ethernet/stmicro/stmmac/dwmac-socfpga.c | 6 +- drivers/net/ethernet/xilinx/Kconfig | 7 + drivers/net/ethernet/xilinx/xilinx_axienet.h | 4 +- .../net/ethernet/xilinx/xilinx_axienet_main.c | 104 +-- drivers/net/pcs/Kconfig | 45 +- drivers/net/pcs/Makefile | 4 + drivers/net/pcs/core.c | 686 ++++++++++++++++++ drivers/net/pcs/pcs-lynx.c | 110 +-- drivers/net/pcs/pcs-xilinx.c | 484 ++++++++++++ drivers/net/phy/phy_device.c | 3 +- drivers/net/phy/phylink.c | 24 +- drivers/of/property.c | 2 + include/linux/pcs-lynx.h | 13 +- include/linux/pcs-xilinx.h | 15 + include/linux/pcs.h | 205 ++++++ include/linux/phy.h | 1 + include/linux/phylink.h | 27 +- 39 files changed, 2010 insertions(+), 296 deletions(-) create mode 100644 Documentation/devicetree/bindings/net/xilinx,pcs.yaml create mode 100644 Documentation/networking/pcs.rst create mode 100644 drivers/net/pcs/core.c create mode 100644 drivers/net/pcs/pcs-xilinx.c create mode 100644 include/linux/pcs-xilinx.h create mode 100644 include/linux/pcs.h -- 2.35.1.1320.gc452695387.dirty