Re: [PATCH 1/1] dt-bindings: interrupt-controller: Add fsl,icoll.yaml

[Conor Dooley <conor@kernel.org>]

[-- Attachment #1: Type: text/plain, Size: 2146 bytes --]

On Fri, May 23, 2025 at 03:20:15PM -0400, Frank Li wrote:
> Add fsl,icoll.yaml for i.MX23 and i.MX28.
> 
> Signed-off-by: Frank Li <Frank.Li@nxp.com>
> ---
>  .../interrupt-controller/fsl,icoll.yaml       | 45 +++++++++++++++++++
>  1 file changed, 45 insertions(+)
>  create mode 100644 Documentation/devicetree/bindings/interrupt-controller/fsl,icoll.yaml
> 
> diff --git a/Documentation/devicetree/bindings/interrupt-controller/fsl,icoll.yaml b/Documentation/devicetree/bindings/interrupt-controller/fsl,icoll.yaml
> new file mode 100644
> index 0000000000000..7b09fd7d588f2
> --- /dev/null
> +++ b/Documentation/devicetree/bindings/interrupt-controller/fsl,icoll.yaml
> @@ -0,0 +1,45 @@
> +# SPDX-License-Identifier: (GPL-2.0-only OR BSD-2-Clause)
> +%YAML 1.2
> +---
> +$id: http://devicetree.org/schemas/interrupt-controller/fsl,icoll.yaml#
> +$schema: http://devicetree.org/meta-schemas/core.yaml#
> +
> +title: Freescale MXS icoll Interrupt controller
> +
> +maintainers:
> +  - Frank Li <Frank.Li@nxp.com>
> +
> +properties:
> +  compatible:
> +    oneOf:
> +      - items:
> +          - enum:
> +              - fsl,imx23-icoll
> +              - fsl,imx28-icoll
> +          - const: fsl,icoll

Given this generic fallback, that would likely not be approved if this
were actually what it is presented as (a binding for some new device),
is only acceptable because it is already in use and this is some 15 year
old device, you should state pretty clearly in your commit message.
With it pointed out,
Reviewed-by: Conor Dooley <conor.dooley@microchip.com>

> +
> +  reg:
> +    maxItems: 1
> +
> +  interrupt-controller: true
> +
> +  '#interrupt-cells':
> +    const: 1
> +
> +required:
> +  - compatible
> +  - reg
> +  - interrupt-controller
> +  - '#interrupt-cells'
> +
> +additionalProperties: false
> +
> +examples:
> +  - |
> +    interrupt-controller@80000000 {
> +        compatible = "fsl,imx28-icoll", "fsl,icoll";
> +        reg = <0x80000000 0x2000>;
> +        interrupt-controller;
> +        #interrupt-cells = <1>;
> +    };
> +
> -- 
> 2.34.1
> 

[-- Attachment #2: signature.asc --]
[-- Type: application/pgp-signature, Size: 228 bytes --]