From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from perceval.ideasonboard.com (perceval.ideasonboard.com [213.167.242.64]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id 6E8EA21578D for ; Mon, 9 Jun 2025 18:20:47 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=213.167.242.64 ARC-Seal:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1749493249; cv=none; b=sAqA8Hx5uaoIdWhC+1uyYe87dWOavPFKngDcW0qlN5mMrmwS3dNOAJ1fAl/CNlr2/NGQNFm/DBUY64eB9A15li0z8ssVxOlZgpWtD3qPF73MOkHf7Cx5Yl8JDhPXCfz0N4Qx82KGvYE/tQU9PKlQuBaSGiot6xSTULc4GQLIK3Q= ARC-Message-Signature:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1749493249; c=relaxed/simple; bh=23SoUu3wIQcfvRG1bgJGbpqnaiUwVDecwTappI368C0=; h=Date:From:To:Cc:Subject:Message-ID:References:MIME-Version: Content-Type:Content-Disposition:In-Reply-To; b=FTjFYiSB2D6L3b3Y3VA31Y+pISwvvKitSRdlav7ZPrf+uNDhK6VYvn+93bDpCkDNQlkq44ht7r2Uc36tVIxfHBajpfi/wmfgRalDFBD+MffLD41Artg8YLrmZ+o1czpBgJJ4/TCVl/HXKr/K7HXeqWgOT+uiz0GHo7GOcBBnlto= ARC-Authentication-Results:i=1; smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=ideasonboard.com; spf=pass smtp.mailfrom=ideasonboard.com; dkim=pass (1024-bit key) header.d=ideasonboard.com header.i=@ideasonboard.com header.b=C9WA4OSr; arc=none smtp.client-ip=213.167.242.64 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=ideasonboard.com Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=ideasonboard.com Authentication-Results: smtp.subspace.kernel.org; dkim=pass (1024-bit key) header.d=ideasonboard.com header.i=@ideasonboard.com header.b="C9WA4OSr" Received: from pendragon.ideasonboard.com (81-175-209-231.bb.dnainternet.fi [81.175.209.231]) by perceval.ideasonboard.com (Postfix) with ESMTPSA id A404E6A8; Mon, 9 Jun 2025 20:20:38 +0200 (CEST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=ideasonboard.com; s=mail; t=1749493238; bh=23SoUu3wIQcfvRG1bgJGbpqnaiUwVDecwTappI368C0=; h=Date:From:To:Cc:Subject:References:In-Reply-To:From; b=C9WA4OSrROhN0R5TIfmGHoiPtT9vdme6Z2hbgLEz18tV4ncCa4I7y9BYs82J6ja37 8z5YgLZi89mrL33SS+dER8idhHO8vWFOrdj1iuCbqTc7sIwLkMC/a21HwDk+IGR8ZL ROF7vTK9T/QbUwz/WjG59IoJ6wftr0BxZxkDU7kQ= Date: Mon, 9 Jun 2025 21:20:33 +0300 From: Laurent Pinchart To: Adam Ford Cc: Frank Li , linux-media@vger.kernel.org, Isaac Scott , Rui Miguel Silva , Martin Kepplinger , Purism Kernel Team , Mauro Carvalho Chehab , Rob Herring , Krzysztof Kozlowski , Conor Dooley , Shawn Guo , Sascha Hauer , Pengutronix Kernel Team , Fabio Estevam , devicetree@vger.kernel.org, imx@lists.linux.dev, linux-arm-kernel@lists.infradead.org Subject: Re: [PATCH 6/8] dt-bindings: media: nxp,imx-mipi-csi2: Add fsl,num-channels property Message-ID: <20250609182033.GA11428@pendragon.ideasonboard.com> References: <20250608235840.23871-1-laurent.pinchart@ideasonboard.com> <20250608235840.23871-7-laurent.pinchart@ideasonboard.com> Precedence: bulk X-Mailing-List: imx@lists.linux.dev List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Disposition: inline Content-Transfer-Encoding: 8bit In-Reply-To: On Mon, Jun 09, 2025 at 12:53:48PM -0500, Adam Ford wrote: > On Mon, Jun 9, 2025 at 10:32 AM Frank Li wrote: > > On Mon, Jun 09, 2025 at 02:58:38AM +0300, Laurent Pinchart wrote: > > > The CSI-2 receiver can be instantiated with up to four output channels. > > > This is an integration-specific property, specify the number of > > > instantiated channels through a new fsl,num-channels property. The > > > property is optional, and defaults to 1 as only one channel is currently > > > supported by drivers. > > > > > > The only known SoC to have more than one channel is the i.MX8MP. As the > > > binding examples do not cover that SoC, don't update them. > > > > > > Signed-off-by: Laurent Pinchart > > > --- > > > .../devicetree/bindings/media/nxp,imx-mipi-csi2.yaml | 7 +++++++ > > > 1 file changed, 7 insertions(+) > > > > > > diff --git a/Documentation/devicetree/bindings/media/nxp,imx-mipi-csi2.yaml b/Documentation/devicetree/bindings/media/nxp,imx-mipi-csi2.yaml > > > index db4889bf881e..41ad5b84eaeb 100644 > > > --- a/Documentation/devicetree/bindings/media/nxp,imx-mipi-csi2.yaml > > > +++ b/Documentation/devicetree/bindings/media/nxp,imx-mipi-csi2.yaml > > > @@ -68,6 +68,13 @@ properties: > > > default: 166000000 > > > deprecated: true > > > > > > + fsl,num-channels: > > > + $ref: /schemas/types.yaml#/definitions/uint32 > > > + description: Number of output channels > > > + minimum: 1 > > > + maximum: 4 > > > + default: 1 > > > + > > > > Look like it is fixed value for each compabiable string, So it is not > > suitable for adding new property. It should be in driver data of each > > compatible strings. > > > > I met similar case before. DT team generally don't agree on add such > > property, unless there are two instances in the same chip, which have > > difference channel number. > > If the DT changes are rejected, can the number of channels be added to > the data structure inside mipi_csis_of_match? We have compatibles for > 8mm and imx7. If we add an imx8mp compatible we could add a reference > to the number of channels. I thought about it, and decided to add a new property because the number of channels is really a synthesis time configuration parameter, and could differ between different CSIS instances in the same SoC. > > > ports: > > > $ref: /schemas/graph.yaml#/properties/ports > > > -- Regards, Laurent Pinchart