Re: [PATCH 1/3 v2] dt-bindings: usb: Add compatible strings for s32g2/s32g3

[Conor Dooley <conor@kernel.org>]

[-- Attachment #1: Type: text/plain, Size: 2349 bytes --]

On Thu, Jun 12, 2025 at 09:50:51PM +0300, Ghennadi Procopciuc wrote:
> From: Ghennadi Procopciuc <ghennadi.procopciuc@nxp.com>
> 
> Add the compatible strings for the NXP s32g2 and s32g3.  These chips
> are mostly compatible.  The one difference is that the s32g2-usbmisc
> device has an errata ERR050474 which requires a special flag to be set
> for handling packages that aren't 4 byte aligned.
> 
> Signed-off-by: Larisa Grigore <larisa.grigore@nxp.com>
> Signed-off-by: Ionut Vicovan <Ionut.Vicovan@nxp.com>
> Signed-off-by: Ghennadi Procopciuc <ghennadi.procopciuc@nxp.com>
> Signed-off-by: Dan Carpenter <dan.carpenter@linaro.org>

This signoff chain is absolutely wrong, what were the contributions of
Larisa, Ionut or Dan to this patch? If they were co-authors (surely not
4 people for a trivial 4 line diff) they need co-developed-by tags.
You sent it, so your name should be last. 
> ---
> Changes since v1:
> 1: Alphabetize
> 2: Update the commit message a bit.
> 
>  Documentation/devicetree/bindings/usb/ci-hdrc-usb2.yaml | 2 ++
>  Documentation/devicetree/bindings/usb/fsl,usbmisc.yaml  | 2 ++
>  2 files changed, 4 insertions(+)
> 
> diff --git a/Documentation/devicetree/bindings/usb/ci-hdrc-usb2.yaml b/Documentation/devicetree/bindings/usb/ci-hdrc-usb2.yaml
> index cc5787a8cfa3..f6372b76ed5a 100644
> --- a/Documentation/devicetree/bindings/usb/ci-hdrc-usb2.yaml
> +++ b/Documentation/devicetree/bindings/usb/ci-hdrc-usb2.yaml
> @@ -23,6 +23,8 @@ properties:
>            - nvidia,tegra30-udc
>            - nvidia,tegra114-udc
>            - nvidia,tegra124-udc
> +          - nxp,s32g2-usb
> +          - nxp,s32g3-usb
>            - qcom,ci-hdrc
>        - items:
>            - enum:
> diff --git a/Documentation/devicetree/bindings/usb/fsl,usbmisc.yaml b/Documentation/devicetree/bindings/usb/fsl,usbmisc.yaml
> index 019435540df0..ca677d1a8274 100644
> --- a/Documentation/devicetree/bindings/usb/fsl,usbmisc.yaml
> +++ b/Documentation/devicetree/bindings/usb/fsl,usbmisc.yaml
> @@ -21,6 +21,8 @@ properties:
>            - fsl,imx53-usbmisc
>            - fsl,imx6q-usbmisc
>            - fsl,vf610-usbmisc
> +          - nxp,s32g2-usbmisc
> +          - nxp,s32g3-usbmisc
>        - items:
>            - enum:
>                - fsl,imx6ul-usbmisc
> -- 
> 2.47.2
> 

[-- Attachment #2: signature.asc --]
[-- Type: application/pgp-signature, Size: 228 bytes --]