From: Frank Li <Frank.Li@nxp.com>
To: Rui Miguel Silva <rmfrfs@gmail.com>,
Laurent Pinchart <laurent.pinchart@ideasonboard.com>,
Martin Kepplinger <martink@posteo.de>,
Purism Kernel Team <kernel@puri.sm>,
Mauro Carvalho Chehab <mchehab@kernel.org>,
Rob Herring <robh@kernel.org>,
Krzysztof Kozlowski <krzk+dt@kernel.org>,
Conor Dooley <conor+dt@kernel.org>,
Eugen Hristev <eugen.hristev@linaro.org>,
Shawn Guo <shawnguo@kernel.org>,
Sascha Hauer <s.hauer@pengutronix.de>,
Pengutronix Kernel Team <kernel@pengutronix.de>,
Fabio Estevam <festevam@gmail.com>, Peng Fan <peng.fan@nxp.com>,
Alice Yuan <alice.yuan@nxp.com>, Vinod Koul <vkoul@kernel.org>,
Kishon Vijay Abraham I <kishon@kernel.org>,
Philipp Zabel <p.zabel@pengutronix.de>,
Steve Longerbeam <slongerbeam@gmail.com>,
Greg Kroah-Hartman <gregkh@linuxfoundation.org>
Cc: linux-media@vger.kernel.org, devicetree@vger.kernel.org,
linux-kernel@vger.kernel.org, imx@lists.linux.dev,
linux-arm-kernel@lists.infradead.org,
linux-phy@lists.infradead.org, linux-staging@lists.linux.dev,
Frank Li <Frank.Li@nxp.com>
Subject: [PATCH v2 19/32] media: synopsys: csi2: Remove deprecated s_stream and use v4l2_subdev_pad_ops
Date: Fri, 08 Aug 2025 18:39:22 -0400 [thread overview]
Message-ID: <20250808-95_cam-v2-19-4b29fa6919a7@nxp.com> (raw)
In-Reply-To: <20250808-95_cam-v2-0-4b29fa6919a7@nxp.com>
Use new v4l2_subdev_pad_ops.enable_streams(disalbe_stream) replace
deprecated s_stream interface.
Signed-off-by: Frank Li <Frank.Li@nxp.com>
---
drivers/media/platform/synopsys/mipi-csi2.c | 52 +++++++++++++++++------------
1 file changed, 31 insertions(+), 21 deletions(-)
diff --git a/drivers/media/platform/synopsys/mipi-csi2.c b/drivers/media/platform/synopsys/mipi-csi2.c
index 0c8022ecdc18d42fa038c721e0c0953e8eb9cd6c..9ea3ae22fecfbb66abc460c40cbbcf15e1a97494 100644
--- a/drivers/media/platform/synopsys/mipi-csi2.c
+++ b/drivers/media/platform/synopsys/mipi-csi2.c
@@ -342,7 +342,9 @@ static void csi2_stop(struct dw_mipi_csi2_dev *csi2)
* V4L2 subdev operations.
*/
-static int csi2_s_stream(struct v4l2_subdev *sd, int enable)
+static int dw_csi2_enable_streams(struct v4l2_subdev *sd,
+ struct v4l2_subdev_state *state, u32 pad,
+ u64 streams_mask)
{
struct dw_mipi_csi2_dev *csi2 = sd_to_dev(sd);
int i, ret = 0;
@@ -359,28 +361,39 @@ static int csi2_s_stream(struct v4l2_subdev *sd, int enable)
if (i >= csi2->num_sink_pads)
return -EPIPE;
- /*
- * enable/disable streaming only if stream_count is
- * going from 0 to 1 / 1 to 0.
- */
- if (csi2->stream_count != !enable)
- goto update_count;
+ if (csi2->stream_count)
+ return 0;
- dev_dbg(csi2->dev, "stream %s\n", enable ? "ON" : "OFF");
- if (enable)
- ret = csi2_start(csi2);
- else
- csi2_stop(csi2);
+ ret = csi2_start(csi2);
if (ret)
return ret;
-update_count:
- csi2->stream_count += enable ? 1 : -1;
- if (csi2->stream_count < 0)
- csi2->stream_count = 0;
+ csi2->stream_count++;
+
return ret;
}
+static int dw_csi2_disable_streams(struct v4l2_subdev *sd,
+ struct v4l2_subdev_state *state, u32 pad,
+ u64 streams_mask)
+{
+ struct dw_mipi_csi2_dev *csi2 = sd_to_dev(sd);
+
+ guard(mutex)(&csi2->lock);
+
+ if (!csi2->stream_count) {
+ dev_err(csi2->dev, "Error: csi2 enable count already be 0\n");
+ return 0;
+ }
+
+ csi2->stream_count--;
+
+ if (!csi2->stream_count)
+ csi2_stop(csi2);
+
+ return 0;
+}
+
static int csi2_link_setup(struct media_entity *entity,
const struct media_pad *local,
const struct media_pad *remote, u32 flags)
@@ -507,18 +520,15 @@ static const struct media_entity_operations csi2_entity_ops = {
.get_fwnode_pad = v4l2_subdev_get_fwnode_pad_1_to_1,
};
-static const struct v4l2_subdev_video_ops csi2_video_ops = {
- .s_stream = csi2_s_stream,
-};
-
static const struct v4l2_subdev_pad_ops csi2_pad_ops = {
.get_fmt = csi2_get_fmt,
.set_fmt = csi2_set_fmt,
+ .enable_streams = dw_csi2_enable_streams,
+ .disable_streams = dw_csi2_disable_streams,
};
static const struct v4l2_subdev_ops csi2_subdev_ops = {
.core = &csi2_core_ops,
- .video = &csi2_video_ops,
.pad = &csi2_pad_ops,
};
--
2.34.1
next prev parent reply other threads:[~2025-08-08 22:41 UTC|newest]
Thread overview: 36+ messages / expand[flat|nested] mbox.gz Atom feed top
2025-08-08 22:39 [PATCH v2 00/32] media: add imx93 mipi/controller csi support Frank Li
2025-08-08 22:39 ` [PATCH v2 01/32] dt-bindings: media: add DW MIPI CSI-2 Host support Frank Li
2025-08-18 14:39 ` Rob Herring
2025-08-08 22:39 ` [PATCH v2 02/32] media: v4l2-common: Add helper function v4l_get_required_align_by_bpp() Frank Li
2025-08-08 22:39 ` [PATCH v2 03/32] media: v4l2-common: Add helper function media_bus_fmt_to_csi2_bpp() Frank Li
2025-08-08 22:39 ` [PATCH v2 04/32] media: v4l2-common: Add helper function media_bus_fmt_to_csi2_dt() Frank Li
2025-08-20 19:16 ` Laurent Pinchart
2025-08-08 22:39 ` [PATCH v2 05/32] media: staging: media: imx6-mipi-csi2: replace space with tab for alignment Frank Li
2025-08-08 22:39 ` [PATCH v2 06/32] media: staging: media: imx6-mipi-csi2: use devm_add_action_or_reset() to simplify code Frank Li
2025-08-08 22:39 ` [PATCH v2 07/32] media: staging: media: imx6-mipi-csi2: use devm_clk_bulk_get_all() to fetch clocks Frank Li
2025-08-08 22:39 ` [PATCH v2 08/32] media: staging: media: imx6-mipi-csi2: use devm_mutex_init() to simplify code Frank Li
2025-08-08 22:39 ` [PATCH v2 09/32] media: staging: media: imx6-mipi-csi2: use guard() " Frank Li
2025-08-08 22:39 ` [PATCH v2 10/32] media: staging: media: imx6-mipi-csi2: use register structure to match hardware Frank Li
2025-08-08 22:39 ` [PATCH v2 11/32] media: staging: media: imx6-mipi-csi2: use devm_platform_ioremap_resource() simplify code Frank Li
2025-08-08 22:39 ` [PATCH v2 12/32] media: staging: media: imx6-mipi-csi2: move probe part to imx6-csi2.c Frank Li
2025-08-08 22:39 ` [PATCH v2 13/32] media: staging: media: imx6-mipi-csi2: move sd imx6's specific initialization into imx6-sci2.c Frank Li
2025-08-08 22:39 ` [PATCH v2 14/32] media: staging: media: imx6-mipi-csi2: move csi2ipu_gasket_init() to imx6-csi2.c Frank Li
2025-08-08 22:39 ` [PATCH v2 15/32] media: staging: media: imx6-mipi-csi2: move number pad macro define into imx6-csi2.c Frank Li
2025-08-08 22:39 ` [PATCH v2 16/32] media: staging: media: imx6-mipi-csi2: move dphy init part to imx6-csi2.c Frank Li
2025-08-08 22:39 ` [PATCH v2 17/32] media: staging: media: imx6-mipi-csi2: use runtime_pm frame to control clks Frank Li
2025-08-08 22:39 ` [PATCH v2 18/32] media: synopsys: move imx6-mipi-csi2.c to synopsys/mipi-csi2.c Frank Li
2025-08-08 22:39 ` Frank Li [this message]
2025-08-08 22:39 ` [PATCH v2 20/32] media: synopsys: csi2: Add phy interface support Frank Li
2025-08-08 22:39 ` [PATCH v2 21/32] media: synopsys: csi2: Add basic v150* version register Frank Li
2025-08-08 22:39 ` [PATCH v2 22/32] media: synopsys: csi2: Add irq support to record error count Frank Li
2025-08-08 22:39 ` [PATCH v2 23/32] media: synopsys: csi2: Handle alignment requirement for width Frank Li
2025-08-08 22:39 ` [PATCH v2 24/32] media: synopsys: csi2: Add register prefix to register field definitions Frank Li
2025-08-08 22:39 ` [PATCH v2 25/32] media: synopsys: csi2: Add need_dphy_reset in config Frank Li
2025-08-08 22:39 ` [PATCH v2 26/32] media: synopsys: csi2: Add default simple dw_csi2_subdev_init_state Frank Li
2025-08-08 22:39 ` [PATCH v2 27/32] media: synopsys: csi2: Add v150 lane stop state register bit define Frank Li
2025-08-08 22:39 ` [PATCH v2 28/32] media: synopsys: csi2: use standard v4l2_subdev_get_fmt() function Frank Li
2025-08-08 22:39 ` [PATCH v2 29/32] media: synopsys: csi2: Add customize get_frame_desc() callback Frank Li
2025-08-08 22:39 ` [PATCH v2 30/32] media: synopsys: csi2: Add Image Pixel Interface (IPI) support for v150 Frank Li
2025-08-08 22:39 ` [PATCH v2 31/32] media: synopsys: csi2: Remove source pad connected check at dw_csi2_enable_streams() Frank Li
2025-08-08 22:39 ` [PATCH v2 32/32] media: synopsys: csi2: Add simple synopsys platform driver Frank Li
2025-08-20 14:39 ` [PATCH v2 00/32] media: add imx93 mipi/controller csi support Frank Li
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20250808-95_cam-v2-19-4b29fa6919a7@nxp.com \
--to=frank.li@nxp.com \
--cc=alice.yuan@nxp.com \
--cc=conor+dt@kernel.org \
--cc=devicetree@vger.kernel.org \
--cc=eugen.hristev@linaro.org \
--cc=festevam@gmail.com \
--cc=gregkh@linuxfoundation.org \
--cc=imx@lists.linux.dev \
--cc=kernel@pengutronix.de \
--cc=kernel@puri.sm \
--cc=kishon@kernel.org \
--cc=krzk+dt@kernel.org \
--cc=laurent.pinchart@ideasonboard.com \
--cc=linux-arm-kernel@lists.infradead.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-media@vger.kernel.org \
--cc=linux-phy@lists.infradead.org \
--cc=linux-staging@lists.linux.dev \
--cc=martink@posteo.de \
--cc=mchehab@kernel.org \
--cc=p.zabel@pengutronix.de \
--cc=peng.fan@nxp.com \
--cc=rmfrfs@gmail.com \
--cc=robh@kernel.org \
--cc=s.hauer@pengutronix.de \
--cc=shawnguo@kernel.org \
--cc=slongerbeam@gmail.com \
--cc=vkoul@kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).