[PATCH 0/3] spi: use min_t() to improve code

[PATCH 0/3] spi: use min_t() to improve code

[Qianfeng Rong]

Use min_t() to reduce the code and improve readability.

No functional changes.

Qianfeng Rong (3):
  spi: spi-fsl-lpspi: use min_t() to improve code
  spi: npcm-fiu: use min_t() to improve code
  spi: spl022: use min_t() to improve code

 drivers/spi/spi-fsl-lpspi.c |  8 ++++----
 drivers/spi/spi-npcm-fiu.c  |  6 ++----
 drivers/spi/spi-pl022.c     | 13 +++++--------
 3 files changed, 11 insertions(+), 16 deletions(-)

-- 
2.34.1

[PATCH 1/3] spi: spi-fsl-lpspi: use min_t() to improve code

[Qianfeng Rong]

Use min_t() to reduce the code in fsl_lpspi_setup_transfer() and
improve its readability.

Signed-off-by: Qianfeng Rong <rongqianfeng@vivo.com>
---
 drivers/spi/spi-fsl-lpspi.c | 8 ++++----
 1 file changed, 4 insertions(+), 4 deletions(-)

diff --git a/drivers/spi/spi-fsl-lpspi.c b/drivers/spi/spi-fsl-lpspi.c
index 313e444a34f3..dbdb9e114022 100644
--- a/drivers/spi/spi-fsl-lpspi.c
+++ b/drivers/spi/spi-fsl-lpspi.c
@@ -25,6 +25,7 @@
 #include <linux/spi/spi.h>
 #include <linux/spi/spi_bitbang.h>
 #include <linux/types.h>
+#include <linux/minmax.h>
 
 #define DRIVER_NAME "fsl_lpspi"
 
@@ -473,10 +474,9 @@ static int fsl_lpspi_setup_transfer(struct spi_controller *controller,
 		fsl_lpspi->tx = fsl_lpspi_buf_tx_u32;
 	}
 
-	if (t->len <= fsl_lpspi->txfifosize)
-		fsl_lpspi->watermark = t->len;
-	else
-		fsl_lpspi->watermark = fsl_lpspi->txfifosize;
+	fsl_lpspi->watermark = min_t(typeof(fsl_lpspi->watermark),
+				     fsl_lpspi->txfifosize,
+				     t->len);
 
 	if (fsl_lpspi_can_dma(controller, spi, t))
 		fsl_lpspi->usedma = true;
-- 
2.34.1

Re: [PATCH 1/3] spi: spi-fsl-lpspi: use min_t() to improve code

[Frank Li]

On Fri, Aug 15, 2025 at 04:21:15PM +0800, Qianfeng Rong wrote:
> Use min_t() to reduce the code in fsl_lpspi_setup_transfer() and
> improve its readability.
>

Nit: No functionality change.

Reviewed-by: Frank Li <Frank.Li@nxp.com>

> Signed-off-by: Qianfeng Rong <rongqianfeng@vivo.com>
> ---
>  drivers/spi/spi-fsl-lpspi.c | 8 ++++----
>  1 file changed, 4 insertions(+), 4 deletions(-)
>
> diff --git a/drivers/spi/spi-fsl-lpspi.c b/drivers/spi/spi-fsl-lpspi.c
> index 313e444a34f3..dbdb9e114022 100644
> --- a/drivers/spi/spi-fsl-lpspi.c
> +++ b/drivers/spi/spi-fsl-lpspi.c
> @@ -25,6 +25,7 @@
>  #include <linux/spi/spi.h>
>  #include <linux/spi/spi_bitbang.h>
>  #include <linux/types.h>
> +#include <linux/minmax.h>
>
>  #define DRIVER_NAME "fsl_lpspi"
>
> @@ -473,10 +474,9 @@ static int fsl_lpspi_setup_transfer(struct spi_controller *controller,
>  		fsl_lpspi->tx = fsl_lpspi_buf_tx_u32;
>  	}
>
> -	if (t->len <= fsl_lpspi->txfifosize)
> -		fsl_lpspi->watermark = t->len;
> -	else
> -		fsl_lpspi->watermark = fsl_lpspi->txfifosize;
> +	fsl_lpspi->watermark = min_t(typeof(fsl_lpspi->watermark),
> +				     fsl_lpspi->txfifosize,
> +				     t->len);
>
>  	if (fsl_lpspi_can_dma(controller, spi, t))
>  		fsl_lpspi->usedma = true;
> --
> 2.34.1
>

Re: [PATCH 0/3] spi: use min_t() to improve code

[Mark Brown]

On Fri, 15 Aug 2025 16:21:14 +0800, Qianfeng Rong wrote:
> Use min_t() to reduce the code and improve readability.
> 
> No functional changes.
> 
> Qianfeng Rong (3):
>   spi: spi-fsl-lpspi: use min_t() to improve code
>   spi: npcm-fiu: use min_t() to improve code
>   spi: spl022: use min_t() to improve code
> 
> [...]

Applied to

   https://git.kernel.org/pub/scm/linux/kernel/git/broonie/spi.git for-next

Thanks!

[1/3] spi: spi-fsl-lpspi: use min_t() to improve code
      commit: a750050349ea138e3e86c66a8a41de736619b9de
[2/3] spi: npcm-fiu: use min_t() to improve code
      commit: 1bdc716023a78c2c41fdcb3fc37f09da1be4b7df
[3/3] spi: spl022: use min_t() to improve code
      commit: 90179609efa421b1ccc7d8eafbc078bafb25777c

All being well this means that it will be integrated into the linux-next
tree (usually sometime in the next 24 hours) and sent to Linus during
the next merge window (or sooner if it is a bug fix), however if
problems are discovered then the patch may be dropped or reverted.

You may get further e-mails resulting from automated or manual testing
and review of the tree, please engage with people reporting problems and
send followup patches addressing any issues that are reported if needed.

If any updates are required or you are submitting further changes they
should be sent as incremental updates against current git, existing
patches will not be replaced.

Please add any relevant lists and maintainers to the CCs when replying
to this mail.

Thanks,
Mark