[PATCH 1/1] dt-bindings: iio: adc: max1238: Add #io-channel-cells property

[PATCH 1/1] dt-bindings: iio: adc: max1238: Add #io-channel-cells property

[Frank Li]

Add #io-channel-cells property because it is multi-channel ADC.

Fix below CHECK_DTBS warnings:
  arch/arm/boot/dts/nxp/ls/ls1021a-iot.dtb: adc@35 (maxim,max1239): '#io-channel-cells' does not match any of the regexes: '^pinctrl-[0-9]+$'
	from schema $id: http://devicetree.org/schemas/iio/adc/maxim,max1238.yaml#

Signed-off-by: Frank Li <Frank.Li@nxp.com>
---
 Documentation/devicetree/bindings/iio/adc/maxim,max1238.yaml | 3 +++
 1 file changed, 3 insertions(+)

diff --git a/Documentation/devicetree/bindings/iio/adc/maxim,max1238.yaml b/Documentation/devicetree/bindings/iio/adc/maxim,max1238.yaml
index 60d7b34e3286f..ae3c89393f1a3 100644
--- a/Documentation/devicetree/bindings/iio/adc/maxim,max1238.yaml
+++ b/Documentation/devicetree/bindings/iio/adc/maxim,max1238.yaml
@@ -53,6 +53,9 @@ properties:
   reg:
     maxItems: 1
 
+  "#io-channel-cells":
+    const: 1
+
   vcc-supply: true
   vref-supply:
     description: Optional external reference.  If not supplied, internal
-- 
2.34.1

Re: [PATCH 1/1] dt-bindings: iio: adc: max1238: Add #io-channel-cells property

[Conor Dooley]

[-- Attachment #1: Type: text/plain, Size: 1848 bytes --]

On Mon, Aug 18, 2025 at 04:00:13PM -0400, Frank Li wrote:
> Add #io-channel-cells property because it is multi-channel ADC.

As far as I understand it, that's not a correct statement. A single
channel ADC can have the property, but it would be set to 0 just as a
single clock provider has #clock-cells of 0.

I did check the devices and they do all appear to be multichannel (not
just the 1238) so the change you're making here looks correct, unless
some of them would actually require 2 cells for some reason - but you
should really state that in your commit message when there's about 30
compatibles so that I don't have to check them.

With an accurate commit message,
Acked-by: Conor Dooley <conor.dooley@microchip.com>
Maybe Jonathan is willing to do that since it's just adding "of 1" to
the first sentence.

> 
> Fix below CHECK_DTBS warnings:
>   arch/arm/boot/dts/nxp/ls/ls1021a-iot.dtb: adc@35 (maxim,max1239): '#io-channel-cells' does not match any of the regexes: '^pinctrl-[0-9]+$'
> 	from schema $id: http://devicetree.org/schemas/iio/adc/maxim,max1238.yaml#
> 
> Signed-off-by: Frank Li <Frank.Li@nxp.com>
> ---
>  Documentation/devicetree/bindings/iio/adc/maxim,max1238.yaml | 3 +++
>  1 file changed, 3 insertions(+)
> 
> diff --git a/Documentation/devicetree/bindings/iio/adc/maxim,max1238.yaml b/Documentation/devicetree/bindings/iio/adc/maxim,max1238.yaml
> index 60d7b34e3286f..ae3c89393f1a3 100644
> --- a/Documentation/devicetree/bindings/iio/adc/maxim,max1238.yaml
> +++ b/Documentation/devicetree/bindings/iio/adc/maxim,max1238.yaml
> @@ -53,6 +53,9 @@ properties:
>    reg:
>      maxItems: 1
>  
> +  "#io-channel-cells":
> +    const: 1
> +
>    vcc-supply: true
>    vref-supply:
>      description: Optional external reference.  If not supplied, internal
> -- 
> 2.34.1
> 

[-- Attachment #2: signature.asc --]
[-- Type: application/pgp-signature, Size: 228 bytes --]

Re: [PATCH 1/1] dt-bindings: iio: adc: max1238: Add #io-channel-cells property

[Jonathan Cameron]

On Tue, 19 Aug 2025 19:12:10 +0100
Conor Dooley <conor@kernel.org> wrote:

> On Mon, Aug 18, 2025 at 04:00:13PM -0400, Frank Li wrote:
> > Add #io-channel-cells property because it is multi-channel ADC.  
> 
> As far as I understand it, that's not a correct statement. A single
> channel ADC can have the property, but it would be set to 0 just as a
> single clock provider has #clock-cells of 0.
> 
> I did check the devices and they do all appear to be multichannel (not
> just the 1238) so the change you're making here looks correct, unless
> some of them would actually require 2 cells for some reason - but you
> should really state that in your commit message when there's about 30
> compatibles so that I don't have to check them.
> 
> With an accurate commit message,
> Acked-by: Conor Dooley <conor.dooley@microchip.com>
> Maybe Jonathan is willing to do that since it's just adding "of 1" to
> the first sentence.
> 
I changed it to say 'with a constant value of 1' to leave the gap
for other values on other devices that you are pointing out.

Applied, thanks.
> > 
> > Fix below CHECK_DTBS warnings:
> >   arch/arm/boot/dts/nxp/ls/ls1021a-iot.dtb: adc@35 (maxim,max1239): '#io-channel-cells' does not match any of the regexes: '^pinctrl-[0-9]+$'
> > 	from schema $id: http://devicetree.org/schemas/iio/adc/maxim,max1238.yaml#
> > 
> > Signed-off-by: Frank Li <Frank.Li@nxp.com>
> > ---
> >  Documentation/devicetree/bindings/iio/adc/maxim,max1238.yaml | 3 +++
> >  1 file changed, 3 insertions(+)
> > 
> > diff --git a/Documentation/devicetree/bindings/iio/adc/maxim,max1238.yaml b/Documentation/devicetree/bindings/iio/adc/maxim,max1238.yaml
> > index 60d7b34e3286f..ae3c89393f1a3 100644
> > --- a/Documentation/devicetree/bindings/iio/adc/maxim,max1238.yaml
> > +++ b/Documentation/devicetree/bindings/iio/adc/maxim,max1238.yaml
> > @@ -53,6 +53,9 @@ properties:
> >    reg:
> >      maxItems: 1
> >  
> > +  "#io-channel-cells":
> > +    const: 1
> > +
> >    vcc-supply: true
> >    vref-supply:
> >      description: Optional external reference.  If not supplied, internal
> > -- 
> > 2.34.1
> >